Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore](compaction) Do not print the stack trace when the compaction task already exists #25597

Merged
merged 2 commits into from
Oct 18, 2023
Merged

[chore](compaction) Do not print the stack trace when the compaction task already exists #25597

merged 2 commits into from
Oct 18, 2023

Conversation

Xiaoccer
Copy link
Contributor

No description provided.

@Xiaoccer
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
Copy link
Contributor

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.00% (8277/22369)
Line Coverage: 29.07% (66384/228342)
Region Coverage: 27.73% (34453/124259)
Branch Coverage: 24.35% (17509/71914)
Coverage Report: http://coverage.selectdb-in.cc/coverage/fbb9f183312e0d76e8398ef12e2529a97553feeb_fbb9f183312e0d76e8398ef12e2529a97553feeb/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 18, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.89 seconds
stream load tsv: 563 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162282642 Bytes

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.00% (8277/22369)
Line Coverage: 29.07% (66382/228342)
Region Coverage: 27.73% (34453/124259)
Branch Coverage: 24.35% (17508/71914)
Coverage Report: http://coverage.selectdb-in.cc/coverage/31f2483170d5d4d06f76ff0a1b84685f5c7d7f8f_31f2483170d5d4d06f76ff0a1b84685f5c7d7f8f/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.38 seconds
stream load tsv: 561 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162279494 Bytes

yiguolei
yiguolei approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei added the usercase Important user case type label label Oct 18, 2023
airborne12
airborne12 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 32fc8a1 into apache:master Oct 18, 2023
24 of 27 checks passed
xiaokang pushed a commit that referenced this pull request Oct 22, 2023
@Xiaoccer @xiaokang
[chore](compaction) Do not print the stack trace when the compaction …
3f5dfbe 
…task already exists (#25597)
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@Xiaoccer
[chore](compaction) Do not print the stack trace when the compaction …
2ab790b 
…task already exists (apache#25597)
wsjz pushed a commit to wsjz/incubator-doris that referenced this pull request Nov 19, 2023
@Xiaoccer @wsjz
[chore](compaction) Do not print the stack trace when the compaction …
3b87763 
…task already exists (apache#25597)
@xiaokang xiaokang mentioned this pull request Dec 4, 2023
Open
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@Xiaoccer
[chore](compaction) Do not print the stack trace when the compaction …
ed7da7c 
…task already exists (apache#25597)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airborne12 airborne12 airborne12 approved these changes

@yiguolei yiguolei yiguolei approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Xiaoccer @dataroaring @doris-robot @airborne12 @yiguolei @xiaokang