Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](auth)Fix can not insert overwrite who have load priv #25711

Merged
merged 11 commits into from
Nov 1, 2023
Merged

[fix](auth)Fix can not insert overwrite who have load priv #25711

merged 11 commits into from
Nov 1, 2023

Conversation

zddr
Copy link
Contributor

@zddr zddr commented Oct 20, 2023

Proposed changes

Issue Number: close #xxx

Fix can not insert overwrite who have load priv

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zddr zddr marked this pull request as draft October 20, 2023 14:11
@zddr zddr marked this pull request as ready for review October 26, 2023 13:55
@zddr
Copy link
Contributor Author

zddr commented Oct 26, 2023

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.75 seconds
stream load tsv: 557 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162126333 Bytes

@zddr
Copy link
Contributor Author

zddr commented Oct 31, 2023

run buildall

morningman
morningman approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 31, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.42 seconds
stream load tsv: 545 seconds loaded 74807831229 Bytes, about 130 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162156385 Bytes

@zddr
Copy link
Contributor Author

zddr commented Oct 31, 2023

run p0

morningman
morningman approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 5efc6c4 into apache:master Nov 1, 2023
28 of 31 checks passed
dutyu pushed a commit to dutyu/doris that referenced this pull request Nov 4, 2023
@zddr
[fix](auth)Fix can not insert overwrite who have load priv (apache#25711
0bf0b06 
)

Fix can not insert overwrite who have load priv
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 13, 2023
@zddr @seawinde
[fix](auth)Fix can not insert overwrite who have load priv (apache#25711
634c048 
)

Fix can not insert overwrite who have load priv
wsjz pushed a commit to wsjz/incubator-doris that referenced this pull request Nov 19, 2023
@zddr @wsjz
[fix](auth)Fix can not insert overwrite who have load priv (apache#25711
68cb4a8 
)

Fix can not insert overwrite who have load priv
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@zddr
[fix](auth)Fix can not insert overwrite who have load priv (apache#25711
5ab22e9 
)

Fix can not insert overwrite who have load priv
@zddr zddr deleted the fix_overwrite_auth branch March 28, 2024 02:35
@zddr zddr mentioned this pull request Jul 31, 2024
Merged
xiaokang pushed a commit that referenced this pull request Aug 2, 2024
@zddr
[fix](auth)fix create table like need create_priv of existed table #3…
05ec11c 
…7879 #25711 (#38569)
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@zddr @Baymine
[fix](auth)fix create table like need create_priv of existed table ap…
d31ab89 
…ache#37879 apache#25711 (apache#38569)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningman morningman morningman approved these changes

@wuwenchi wuwenchi wuwenchi approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.14-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zddr @doris-robot @morningman @wuwenchi @xiaokang @morrySnow