Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pipeline](close) change the close order in pipeline engine #27290

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

HappenLee
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@HappenLee
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 20, 2023
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.53% (8450/23134)
Line Coverage: 28.87% (68686/237888)
Region Coverage: 27.84% (35519/127570)
Branch Coverage: 24.60% (18108/73620)
Coverage Report: http://coverage.selectdb-in.cc/coverage/95d11104e451567d1f3cf7bc7833031cb1868b92_95d11104e451567d1f3cf7bc7833031cb1868b92/report/index.html

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Tpch sf100 test result on commit 95d11104e451567d1f3cf7bc7833031cb1868b92, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4904	4663	4689	4663
q2	370	148	159	148
q3	2045	1935	1890	1890
q4	1393	1273	1253	1253
q5	3998	3948	4039	3948
q6	249	129	131	129
q7	1428	896	908	896
q8	2747	2787	2784	2784
q9	9933	9651	9642	9642
q10	3469	3562	3556	3556
q11	391	245	254	245
q12	441	297	302	297
q13	4548	3802	3764	3764
q14	327	287	285	285
q15	592	541	566	541
q16	660	581	589	581
q17	1144	956	943	943
q18	7880	7359	7392	7359
q19	1683	1694	1688	1688
q20	553	330	317	317
q21	4420	3960	3985	3960
q22	472	365	375	365
Total cold run time: 53647 ms
Total hot run time: 49254 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4582	4574	4615	4574
q2	335	225	264	225
q3	4013	4001	4007	4001
q4	2694	2697	2708	2697
q5	9747	9687	9697	9687
q6	243	126	126	126
q7	3009	2446	2463	2446
q8	4449	4475	4452	4452
q9	13280	13135	13219	13135
q10	4089	4228	4237	4228
q11	758	631	717	631
q12	974	835	823	823
q13	4302	3569	3553	3553
q14	381	352	350	350
q15	573	525	521	521
q16	735	669	663	663
q17	3820	3921	3908	3908
q18	9427	9055	8929	8929
q19	1811	1800	1802	1800
q20	2437	2058	2057	2057
q21	8991	8617	8690	8617
q22	853	832	789	789
Total cold run time: 81503 ms
Total hot run time: 78212 ms

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.67 seconds
stream load tsv: 583 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.3 seconds inserted 10000000 Rows, about 353K ops/s
storage size: 17099640218 Bytes

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit fcf7691 into apache:master Nov 21, 2023
27 of 29 checks passed
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 28, 2023
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants