Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore](config) temporary change fetch_rpc_timeout_seconds to 150s to… #27453

Closed
wants to merge 1 commit into from
Closed

[chore](config) temporary change fetch_rpc_timeout_seconds to 150s to… #27453

wants to merge 1 commit into from

Conversation

eldenmoon
Copy link
Member

… solve rpc timeout

Rpc timeout is due to fetch phase acquire tablet lock, but the related PR(#26151) is now pending to merge to branch-2.0. So change fetch_rpc_timeout_seconds from 30 to 150 to solve the problem temporarily

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@eldenmoon
Copy link
Member Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.95% (7980/21030)
Line Coverage: 29.66% (64723/218213)
Region Coverage: 29.10% (33348/114591)
Branch Coverage: 24.96% (17122/68608)
Coverage Report: http://coverage.selectdb-in.cc/coverage/18da122441eaaaabc45f877febac1230cca34c4f_18da122441eaaaabc45f877febac1230cca34c4f/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.29 seconds
stream load tsv: 584 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size: 17162581258 Bytes

@wm1581066 wm1581066 added the p0_b label Nov 23, 2023
@eldenmoon
Copy link
Member Author

eldenmoon commented Nov 23, 2023 •
edited
Loading

#27482
#27478 由这两PR解决超时问题

@eldenmoon
Copy link
Member Author

这个PR不合入

@eldenmoon eldenmoon closed this Nov 23, 2023
@eldenmoon eldenmoon reopened this Nov 28, 2023
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@eldenmoon
[chore](config) temporary change fetch_rpc_timeout_seconds to 150s to…
f6663d0 
… solve rpc timeout

Rpc timeout is due to fetch phase acquire tablet lock, but the related PR(apache#26151) is now pending to merge to branch-2.0.
So change fetch_rpc_timeout_seconds from 30 to 150 to solve the problem temporarily
@eldenmoon eldenmoon force-pushed the branch-2.0 branch 3 times, most recently from 154ad8c to f6663d0 Compare November 28, 2023 03:19
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@eldenmoon eldenmoon closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eldenmoon @doris-robot @wm1581066