Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](pipelineX) fix nullptr in loca exchange dependency #27488

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

Mryange
Copy link
Contributor

@Mryange Mryange commented Nov 23, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Mryange
Copy link
Contributor Author

Mryange commented Nov 23, 2023

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.86 seconds
stream load tsv: 569 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17098800118 Bytes

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Tpch sf100 test result on commit ba574c5798c66f708fa5b3cca4e7fae533054bac, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4932	4656	4638	4638
q2	377	140	136	136
q3	2084	1927	1901	1901
q4	1478	1313	1344	1313
q5	4049	4046	4125	4046
q6	276	129	128	128
q7	1476	874	881	874
q8	2947	2946	2932	2932
q9	9901	9796	9584	9584
q10	3487	3562	3590	3562
q11	400	248	251	248
q12	460	285	290	285
q13	4656	3786	3791	3786
q14	324	282	290	282
q15	586	535	520	520
q16	674	576	588	576
q17	1202	999	1029	999
q18	7833	7426	7424	7424
q19	1780	1766	1762	1762
q20	586	297	283	283
q21	4568	4089	4086	4086
q22	480	380	369	369
Total cold run time: 54556 ms
Total hot run time: 49734 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4642	4584	4627	4584
q2	348	223	249	223
q3	4031	4000	4002	4000
q4	2741	2735	2747	2735
q5	9596	9603	9617	9603
q6	272	122	119	119
q7	3021	2473	2497	2473
q8	4399	4437	4401	4401
q9	13022	12914	12837	12837
q10	4054	4195	4218	4195
q11	790	654	666	654
q12	1001	803	814	803
q13	4427	3568	3561	3561
q14	377	344	342	342
q15	579	528	510	510
q16	731	667	667	667
q17	3893	3904	3920	3904
q18	9520	9095	9092	9092
q19	1943	1912	1903	1903
q20	2399	2092	2053	2053
q21	8903	8700	8698	8698
q22	920	840	827	827
Total cold run time: 81609 ms
Total hot run time: 78184 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.58% (8449/23098)
Line Coverage: 28.86% (68672/237929)
Region Coverage: 27.83% (35515/127608)
Branch Coverage: 24.57% (18121/73760)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ba574c5798c66f708fa5b3cca4e7fae533054bac_ba574c5798c66f708fa5b3cca4e7fae533054bac/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 24, 2023
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 126714a into apache:master Nov 24, 2023
27 of 30 checks passed
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 28, 2023
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants