Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pick][feature](inverted index) add ignore_above property to prevent long string from indexing #29002

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

qidaye
Copy link
Contributor

@qidaye qidaye commented Dec 25, 2023

Proposed changes

Issue Number: close #xxx
pick from master: #28585, #28819

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

apache#28585)

When string is too long, clucene will throw an error.
And the string is too long to analyze. So we ignore the string in index process when the string is longer than 256 bytes by default.
We add an poperty `ignore_above` for user to customize.
@github-actions github-actions bot added area/planner Issues or PRs related to the query planner kind/docs Categorizes issue or PR as related to documentation. labels Dec 25, 2023
@qidaye
Copy link
Contributor Author

qidaye commented Dec 25, 2023

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.76% (7996/21174)
Line Coverage: 29.45% (64948/220522)
Region Coverage: 28.93% (33417/115523)
Branch Coverage: 24.79% (17143/69142)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b3ac33ffb90f16d36d8c2a341b5d927f98111e19_b3ac33ffb90f16d36d8c2a341b5d927f98111e19/report/index.html

@xiaokang xiaokang merged commit de95e76 into apache:branch-2.0 Dec 25, 2023
21 of 25 checks passed
@qidaye qidaye deleted the ignore_above branch December 26, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/planner Issues or PRs related to the query planner kind/docs Categorizes issue or PR as related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants