Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](hash join) fix column ref DCHECK failure of hash join node block mem reuse (#28991) #29018

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

jacktengg
Copy link
Contributor

Proposed changes

Pick from #28991

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@jacktengg
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.75% (7993/21175)
Line Coverage: 29.44% (64939/220554)
Region Coverage: 28.91% (33404/115541)
Branch Coverage: 24.79% (17142/69154)
Coverage Report: http://coverage.selectdb-in.cc/coverage/dfb4a0a343b9d6dc87ac73153e273579faad5256_dfb4a0a343b9d6dc87ac73153e273579faad5256/report/index.html

@jacktengg
Copy link
Contributor Author

run p0

@jacktengg
Copy link
Contributor Author

run clickbench

1 similar comment
@jacktengg
Copy link
Contributor Author

run clickbench

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.13 seconds
stream load tsv: 562 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.8 seconds inserted 10000000 Rows, about 335K ops/s
storage size: 17162501623 Bytes

@yiguolei yiguolei merged commit 76b5470 into apache:branch-2.0 Dec 26, 2023
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants