Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](tablet stat) fix tablet stat thread block #29151

Merged
merged 1 commit into from
Dec 27, 2023
Merged

[fix](tablet stat) fix tablet stat thread block #29151

merged 1 commit into from
Dec 27, 2023

Conversation

yujun777
Copy link
Collaborator

tablet stat thread was block due to fork pool thread exit abnormal

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@yujun777
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.17 seconds
stream load tsv: 562 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17183893862 Bytes

dataroaring
dataroaring approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 27, 2023
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Tpch sf100 test result on commit de34ae275bc60ede7a1a9b021c164cb1357c45a0, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4985	4626	4638	4626
q2	362	153	159	153
q3	1474	1286	1222	1222
q4	1128	951	905	905
q5	3147	3167	3144	3144
q6	249	128	127	127
q7	1033	486	492	486
q8	2311	2279	2255	2255
q9	6705	6700	6671	6671
q10	3195	3292	3266	3266
q11	328	217	216	216
q12	351	210	205	205
q13	4166	3451	3408	3408
q14	242	213	217	213
q15	569	527	523	523
q16	442	389	385	385
q17	1026	666	527	527
q18	7088	6720	6930	6720
q19	1622	1641	1649	1641
q20	570	323	304	304
q21	3175	2731	2700	2700
q22	368	303	313	303
Total cold run time: 44536 ms
Total hot run time: 40000 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4594	4554	4540	4540
q2	272	163	169	163
q3	3373	3356	3354	3354
q4	2229	2221	2218	2218
q5	5707	5710	5713	5710
q6	241	119	119	119
q7	2378	1861	1842	1842
q8	3622	3634	3609	3609
q9	9082	8969	9013	8969
q10	3814	3912	3886	3886
q11	477	375	364	364
q12	768	600	586	586
q13	3917	3209	3178	3178
q14	293	240	249	240
q15	582	519	531	519
q16	492	441	468	441
q17	2005	1960	1954	1954
q18	8627	8262	8397	8262
q19	1769	1787	1757	1757
q20	2270	1954	1923	1923
q21	6188	5786	5838	5786
q22	537	490	478	478
Total cold run time: 63237 ms
Total hot run time: 59898 ms

caiconghui
caiconghui approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@caiconghui caiconghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 0bff387 into apache:master Dec 27, 2023
27 of 30 checks passed
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Dec 28, 2023
@yujun777 @eldenmoon
[fix](tablet stat) fix tablet stat thread block apache#29151
16cc587
hello-stephen pushed a commit to hello-stephen/doris that referenced this pull request Dec 28, 2023
@yujun777
[fix](tablet stat) fix tablet stat thread block apache#29151
0e400a9
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Jan 12, 2024
@yujun777 @HappenLee
[fix](tablet stat) fix tablet stat thread block apache#29151
338a8d5
yujun777 added a commit to yujun777/doris that referenced this pull request Feb 21, 2024
@yujun777
[fix](tablet stat) fix tablet stat thread block apache#29151
06fe681
@yujun777 yujun777 mentioned this pull request Feb 21, 2024
Merged
dataroaring pushed a commit that referenced this pull request Mar 4, 2024
@yujun777
[fix](tablet stat) fix tablet stat thread block #29151 (#31190)
02b6e30
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@yujun777
[fix](tablet stat) fix tablet stat thread block apache#29151 (apache#…
226501c 
…31190)

Conflicts:
	fe/fe-core/src/main/java/org/apache/doris/catalog/TabletStatMgr.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caiconghui caiconghui caiconghui approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.6-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yujun777 @doris-robot @caiconghui @dataroaring @yiguolei @wm1581066