-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](JDK17) Fixed that BE could not be started using JDK17 #30286
Conversation
run buildall |
TPC-H: Total hot run time: 39003 ms
|
TPC-DS: Total hot run time: 186460 ms
|
ClickBench: Total hot run time: 31.34 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run buildall |
TPC-H: Total hot run time: 37232 ms
|
TPC-DS: Total hot run time: 173380 ms
|
ClickBench: Total hot run time: 30.75 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
b8a3d9d
to
7da83fb
Compare
run buildall |
TPC-H: Total hot run time: 36796 ms
|
TPC-DS: Total hot run time: 175562 ms
|
ClickBench: Total hot run time: 30.9 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
Issue Number: #30484 This is because hadoop-client-api relies on hadoop-common. In the case of JDK17, it will still include hadoop-common.
Proposed changes
Issue Number: #30484
This is because hadoop-client-api relies on hadoop-common.
In the case of JDK17, it will still include hadoop-common.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...