Skip to content

Conversation

@imay
Copy link
Contributor

@imay imay commented Nov 13, 2018

Issue: #303

Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lide-reed lide-reed merged commit c6df9b1 into apache:master Nov 13, 2018
@imay imay deleted the fix-be-ut branch November 13, 2018 11:26
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Sep 26, 2025
deardeng pushed a commit to deardeng/incubator-doris that referenced this pull request Dec 19, 2025
…ache#304)

### What problem does this PR solve?

Problem Summary:
When creating s3 resource with endpoint, it user already specify
`https://` schema in endpoint url,
we should not replace it with `http://`.

### Release note

[fix](s3) fix bug that s3 resource do not support `https://`

Co-authored-by: Mingyu Chen (Rayner) <morningman@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants