-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[enhance](function) refactor from_format_str and support more format #30452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
TPC-H: Total hot run time: 39451 ms |
TPC-DS: Total hot run time: 176495 ms |
ClickBench: Total hot run time: 30.63 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
34dd865 to
c800387
Compare
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
TPC-H: Total hot run time: 37654 ms |
TPC-DS: Total hot run time: 173056 ms |
ClickBench: Total hot run time: 30.82 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
c800387 to
903f069
Compare
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 37351 ms |
TPC-DS: Total hot run time: 172764 ms |
ClickBench: Total hot run time: 31.34 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
|
TeamCity be ut coverage result: |
2302339 to
5daf0a6
Compare
|
run buildall |
TPC-H: Total hot run time: 36996 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 175469 ms |
ClickBench: Total hot run time: 30.39 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
HappenLee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
Proposed changes
Issue Number: close #xxx
now support incomplete date parsing with any legal format, like:
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...