-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](JDK17) Start Fe with JDK17 #30485
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run buildall |
7 tasks
TPC-H: Total hot run time: 37894 ms
|
TPC-DS: Total hot run time: 173702 ms
|
ClickBench: Total hot run time: 31.12 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
morningman
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions
bot
added
the
approved
Indicates a PR has been approved by one committer.
label
Jan 29, 2024
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
kaka11chen
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yiguolei
pushed a commit
that referenced
this pull request
Jan 30, 2024
Issue Number: close #30484 problem: gson will use Java's reflection mechanism to generate a default Adapter, but JDK17 is prohibited from visiting such an access. solution: gson has provided solutions since 2.9.1, which can bypass this problem: Add support for reflection access filter by Marcono1234 · Pull Request #1905 · google/gson We need to upgrade the gson version and use this solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: #30484
problem:
gson
will use Java's reflection mechanism to generate a default Adapter, but JDK17 is prohibited from visiting such an access.solution:
gson
has provided solutions since 2.9.1, which can bypass this problem: Add support for reflection access filter by Marcono1234 · Pull Request #1905 · google/gsonWe need to upgrade the gson version and use this solution
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...