[fix](JDK17) The objects stored in PriorityQueue must implement the Comparable interface #30625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `Comparable` interface (apache#30050)
7 tasks
|
run buildall |
TPC-H: Total hot run time: 36662 ms |
yiguolei
approved these changes
Jan 31, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-DS: Total hot run time: 173057 ms |
ClickBench: Total hot run time: 31.45 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
yiguolei
pushed a commit
that referenced
this pull request
Jan 31, 2024
… `Comparable` interface (#30050) (#30625) Issue Number: #30484 The objects stored in PriorityQueue must implement the Comparable interface or passed into the customized `Comparator`. If we don't do this, run the program in the JDK17 environment will report an exception: ```java Caused by: java.lang.AssertionError: Expect exception msg contains 'query wait timeout', but meet 'java.sql.SQLException: ClassCastException, msg: class org.apache.doris.resource.workloadgroup.QueueToken cannot be cast to class java.lang.Comparable (org.apache.doris.resource.workloadgroup.QueueToken is in unnamed module of loader 'app'; java.lang.Comparable is in module java.base of loader 'bootstrap')' ```
yiguolei
pushed a commit
that referenced
this pull request
Jan 31, 2024
… `Comparable` interface (#30050) (#30625) Issue Number: #30484 The objects stored in PriorityQueue must implement the Comparable interface or passed into the customized `Comparator`. If we don't do this, run the program in the JDK17 environment will report an exception: ```java Caused by: java.lang.AssertionError: Expect exception msg contains 'query wait timeout', but meet 'java.sql.SQLException: ClassCastException, msg: class org.apache.doris.resource.workloadgroup.QueueToken cannot be cast to class java.lang.Comparable (org.apache.doris.resource.workloadgroup.QueueToken is in unnamed module of loader 'app'; java.lang.Comparable is in module java.base of loader 'bootstrap')' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: #30484
The objects stored in PriorityQueue must implement the Comparable interface or passed into the customized
Comparator.If we don't do this, run the program in the JDK17 environment will report an exception:
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...