Skip to content

[branch-2.0](datetime) refactor and support more format for str_to_date #30719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 2 commits into from
Feb 7, 2024
Merged

[branch-2.0](datetime) refactor and support more format for str_to_date #30719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcaaec9
two pr
zclllyybb Feb 4, 2024
e7a9bd4
fix case
zclllyybb Feb 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions be/src/vec/functions/function.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,9 +367,11 @@ class FunctionBuilderImpl : public IFunctionBuilder {
bool is_stateful() const override { return false; }
bool is_variadic() const override { return false; }

/// Default implementation. Will check only in non-variadic case.
// Default implementation. Will check only in non-variadic case.
void check_number_of_arguments(size_t number_of_arguments) const override;

// the return type should be same with what FE plans.
// it returns: `get_return_type_impl` if `use_default_implementation_for_nulls` = false
// `get_return_type_impl` warpped in NULL if `use_default_implementation_for_nulls` = true and input has NULL
DataTypePtr get_return_type(const ColumnsWithTypeAndName& arguments) const;

DataTypes get_variadic_argument_types() const override {
Expand All @@ -383,7 +385,9 @@ class FunctionBuilderImpl : public IFunctionBuilder {
}

protected:
/// Get the result type by argument type. If the function does not apply to these arguments, throw an exception.
// Get the result type by argument type. If the function does not apply to these arguments, throw an exception.
// the get_return_type_impl and its overrides should only return the nested type if `use_default_implementation_for_nulls` is true.
// whether to wrap in nullable type will be automatically decided.
virtual DataTypePtr get_return_type_impl(const ColumnsWithTypeAndName& arguments) const {
DataTypes data_types(arguments.size());
for (size_t i = 0; i < arguments.size(); ++i) data_types[i] = arguments[i].type;
Expand All @@ -400,7 +404,7 @@ class FunctionBuilderImpl : public IFunctionBuilder {
* if some of arguments are Nullable(Nothing) then don't call get_return_type(), call build_impl() with return_type = Nullable(Nothing),
* if some of arguments are Nullable, then:
* - Nullable types are substituted with nested types for get_return_type() function
* - wrap get_return_type() result in Nullable type and pass to build_impl
* - WRAP get_return_type() RESULT IN NULLABLE type and pass to build_impl
*
* Otherwise build returns build_impl(arguments, get_return_type(arguments));
*/
Expand Down
Loading