Skip to content

[fix](arrow-flight) Fix arrow flight sql compatible with JDK 17 and upgrade arrow 15.0.2 #32796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xinyiZzz merged 5 commits into from
Mar 28, 2024
Merged

[fix](arrow-flight) Fix arrow flight sql compatible with JDK 17 and upgrade arrow 15.0.2 #32796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5d62840
1
xinyiZzz Mar 25, 2024
9245c54
2
xinyiZzz Mar 27, 2024
015bb7a
3
xinyiZzz Mar 27, 2024
7428302
5
xinyiZzz Mar 27, 2024
73ee55b
6
xinyiZzz Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion fe/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,13 @@ under the License.
</plugin>
</plugins>
</pluginManagement>
<extensions>
<extension>
<groupId>kr.motd.maven</groupId>
<artifactId>os-maven-plugin</artifactId>
<version>1.7.0</version>
</extension>
</extensions>
</build>
<modules>
<module>fe-common</module>
Expand Down Expand Up @@ -305,7 +312,7 @@ under the License.
<iceberg.version>1.4.3</iceberg.version>
<maxcompute.version>0.45.2-public</maxcompute.version>
<avro.version>1.11.3</avro.version>
<arrow.version>15.0.0</arrow.version>
<arrow.version>15.0.2</arrow.version>
<!-- hudi -->
<hudi.version>0.14.1</hudi.version>
<presto.hadoop.version>2.7.4-11</presto.hadoop.version>
Expand Down
2 changes: 1 addition & 1 deletion regression-test/framework/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ under the License.
<antlr.version>4.9.3</antlr.version>
<hadoop.version>2.8.0</hadoop.version>
<aws-java-sdk-s3.version>1.11.95</aws-java-sdk-s3.version>
<arrow.version>15.0.0</arrow.version>
<arrow.version>15.0.2</arrow.version>
</properties>
<build>
<plugins>
Expand Down
2 changes: 1 addition & 1 deletion regression-test/suites/query_p0/sql_functions/test_in_expr.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
// specific language governing permissions and limitations
// under the License.

suite("test_in_expr", "query,arrow_flight_sql") {
suite("test_in_expr", "query") { // "arrow_flight_sql", groovy not support print arrow array type, throw IndexOutOfBoundsException.
def nullTableName = "in_expr_test_null"
def notNullTableName = "in_expr_test_not_null"

Expand Down
4 changes: 3 additions & 1 deletion regression-test/suites/query_p0/sql_functions/window_functions/test_window_fn.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
suite("test_window_fn", "arrow_flight_sql") {
suite("test_window_fn") {
// "arrow_flight_sql", groovy use flight sql connection to execute query `SUM(MAX(c1) OVER (PARTITION BY))` report error:
// `AGGREGATE clause must not contain analytic expressions`, but no problem in Java execute it with `jdbc::arrow-flight-sql`.
def tbName1 = "empsalary"
def tbName2 = "tenk1"
sql """ DROP TABLE IF EXISTS ${tbName1} """
Expand Down
2 changes: 1 addition & 1 deletion regression-test/suites/query_p0/test_two_phase_read_with_having.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
suite("test_two_phase_read_with_having", "arrow_flight_sql") {
suite("test_two_phase_read_with_having") { // "arrow_flight_sql" not support two phase read

sql """ set enable_partition_topn = 1; """
sql """ set topn_opt_limit_threshold = 1024; """
Expand Down
1 change: 1 addition & 0 deletions run-regression-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ fi

echo "===== Run Regression Test ====="

# if use jdk17, add java option "--add-opens=java.base/java.nio=ALL-UNNAMED"
if [[ "${TEAMCITY}" -eq 1 ]]; then
JAVA_OPTS="${JAVA_OPTS} -DstdoutAppenderType=teamcity -Xmx2048m"
fi
Expand Down