Skip to content

[Function](exec) replace SipHash in function by XXHash #32919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HappenLee merged 1 commit into from
Mar 28, 2024
Merged

[Function](exec) replace SipHash in function by XXHash #32919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions be/src/vec/aggregate_functions/aggregate_function_uniq.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
#include "vec/common/assert_cast.h"
#include "vec/common/hash_table/hash.h"
#include "vec/common/hash_table/phmap_fwd_decl.h"
#include "vec/common/sip_hash.h"
#include "vec/common/string_ref.h"
#include "vec/common/uint128.h"
#include "vec/core/types.h"
Expand Down Expand Up @@ -64,16 +63,13 @@ template <typename T>
struct AggregateFunctionUniqExactData {
static constexpr bool is_string_key = std::is_same_v<T, String>;
using Key = std::conditional_t<is_string_key, UInt128, T>;
using Hash = std::conditional_t<is_string_key, UInt128TrivialHash, HashCRC32<Key>>;
using Hash = HashCRC32<Key>;

using Set = flat_hash_set<Key, Hash>;

static UInt128 ALWAYS_INLINE get_key(const StringRef& value) {
UInt128 key;
SipHash hash;
hash.update(value.data, value.size);
hash.get128(key.low, key.high);
return key;
auto hash_value = XXH_INLINE_XXH128(value.data, value.size, 0);
return UInt128 {hash_value.high64, hash_value.low64};
}

Set set;
Expand Down
20 changes: 9 additions & 11 deletions be/src/vec/functions/uuid_numeric.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,7 @@
#include "common/status.h"
#include "runtime/large_int_value.h"
#include "vec/columns/column_vector.h"
#include "vec/columns/columns_number.h"
#include "vec/common/hash_table/hash.h"
#include "vec/common/sip_hash.h"
#include "vec/common/uint128.h"
#include "vec/core/block.h"
#include "vec/core/types.h"
#include "vec/data_types/data_type_number.h"
Expand Down Expand Up @@ -100,7 +97,6 @@ class UuidNumeric : public IFunction {
}

// TODO(zhiqiang): May be override open function?

Status execute_impl(FunctionContext* /*context*/, Block& block,
const ColumnNumbers& /*arguments*/, size_t result,
size_t input_rows_count) const override {
Expand Down Expand Up @@ -140,14 +136,16 @@ class UuidNumeric : public IFunction {
UInt64 randomSeed() const {
struct timespec times {};

clock_gettime(CLOCK_MONOTONIC, &times);
/// Not cryptographically secure as time, pid and stack address can be predictable.

SipHash hash;
hash.update(times.tv_nsec);
hash.update(times.tv_sec);
hash.update((uintptr_t)pthread_self());

return hash.get64();
auto ret = HashUtil::xxHash64WithSeed(reinterpret_cast<const char*>(&times.tv_nsec),
sizeof(times.tv_nsec), 0);
ret = HashUtil::xxHash64WithSeed(reinterpret_cast<const char*>(&times.tv_sec),
sizeof(times.tv_sec), ret);
ret = HashUtil::xxHash64WithSeed(reinterpret_cast<const char*>((uintptr_t)pthread_self()),
sizeof(pthread_t), ret);

return ret;
}
};

Expand Down