-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[enhancement](cloud) Only update table version when drop a non-empty partition #32989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 37726 ms |
TPC-DS: Total hot run time: 181798 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38220 ms |
|
run buildall |
1 similar comment
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38706 ms |
TPC-DS: Total hot run time: 182060 ms |
ClickBench: Total hot run time: 29.99 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38036 ms |
TPC-DS: Total hot run time: 183593 ms |
ClickBench: Total hot run time: 29.74 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
68b00c6 to
4b13113
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38865 ms |
7acec33 to
a20c9b1
Compare
|
run buildall |
TPC-H: Total hot run time: 38700 ms |
TPC-DS: Total hot run time: 183202 ms |
ClickBench: Total hot run time: 29.5 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
run buildall |
TPC-H: Total hot run time: 38442 ms |
TPC-DS: Total hot run time: 182938 ms |
ClickBench: Total hot run time: 30.06 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39651 ms |
TPC-DS: Total hot run time: 180305 ms |
ClickBench: Total hot run time: 30.45 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
run feut |
cambyzju
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
…partition (apache#32989) 1.fix regression test test-table-version. 2.when dropping partition, only update table version when dropping a non-empty partition. 3.complete some unfinished work in apache#32738
Proposed changes
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...