[opt](rowcount) refresh external table's rowcount async #32997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 37447 ms |
TPC-DS: Total hot run time: 183183 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
morningman
force-pushed
the
rowcount_cache
branch
from
9f8840a to
b5cded1
Compare
morningman
force-pushed
the
rowcount_cache
branch
from
b5cded1 to
5a3a996
Compare
|
run buildall |
TPC-H: Total hot run time: 38668 ms |
TPC-DS: Total hot run time: 180923 ms |
ClickBench: Total hot run time: 30.12 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
morningman
force-pushed
the
rowcount_cache
branch
from
5a3a996 to
17fa9f4
Compare
|
run buildall |
TPC-H: Total hot run time: 38258 ms |
TPC-DS: Total hot run time: 183530 ms |
ClickBench: Total hot run time: 29.43 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
wuwenchi
approved these changes
Mar 30, 2024
|
PR approved by anyone and no changes requested. |
Jibing-Li
approved these changes
Mar 30, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
morningman
added a commit
to morningman/doris
that referenced
this pull request
Mar 31, 2024
In previous implementation, the row count cache will be expired after 10min(by default), and after expiration, the next row count request will miss the cache, causing unstable query plan. In this PR, the cache will be refreshed after Config.external_cache_expire_time_minutes_after_access, so that the cache entry will remain fresh.
morningman
added a commit
that referenced
this pull request
Apr 1, 2024
morningman
added a commit
to morningman/doris
that referenced
this pull request
Apr 7, 2024
In previous implementation, the row count cache will be expired after 10min(by default), and after expiration, the next row count request will miss the cache, causing unstable query plan. In this PR, the cache will be refreshed after Config.external_cache_expire_time_minutes_after_access, so that the cache entry will remain fresh.
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In previous implementation, the row count cache will be expired after 10min(by default),
and after expiration, the next row count request will miss the cache, causing unstable query plan.
In this PR, the cache will be refreshed after
Config.external_cache_expire_time_minutes_after_access,so that the cache entry will remain fresh.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...