[Fix](grace-exit) Fix threadpool hang on grace exit #33132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38668 ms |
TPC-DS: Total hot run time: 182727 ms |
ClickBench: Total hot run time: 30.75 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
yiguolei
reviewed
Apr 2, 2024
yiguolei
requested changes
Apr 2, 2024
Contributor
yiguolei
left a comment
yiguolei
left a comment
There was a problem hiding this comment.
Refactor WriteCooldownMetaExecutors
Contributor
|
run buildall |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 38948 ms |
TPC-DS: Total hot run time: 182116 ms |
ClickBench: Total hot run time: 30.15 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
github-actions
bot
removed
approved
TPC-H: Total hot run time: 39054 ms |
|
TeamCity be ut coverage result: |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38684 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 182599 ms |
ClickBench: Total hot run time: 30.04 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
yiguolei
previously approved these changes
Apr 4, 2024
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38657 ms |
TPC-DS: Total hot run time: 181938 ms |
ClickBench: Total hot run time: 29.36 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
BiteTheDDDDt
approved these changes
Apr 8, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Apr 10, 2024
Fix threadpool hang on grace exit
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Apr 11, 2024
Fix threadpool hang on grace exit
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Apr 11, 2024
Fix threadpool hang on grace exit
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Apr 11, 2024
Fix threadpool hang on grace exit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
stack like:
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...