[opt](nereids)clear min/max column stats if table is partially analyzed #33685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38619 ms |
TPC-DS: Total hot run time: 185922 ms |
ClickBench: Total hot run time: 29.95 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38812 ms |
TPC-DS: Total hot run time: 183063 ms |
ClickBench: Total hot run time: 30.34 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morrySnow
reviewed
Apr 17, 2024
Contributor
morrySnow
left a comment
morrySnow
left a comment
There was a problem hiding this comment.
could we add some test?
fe/fe-core/src/main/java/org/apache/doris/nereids/stats/StatsCalculator.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 38219 ms |
TPC-DS: Total hot run time: 184199 ms |
ClickBench: Total hot run time: 30.27 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
morrySnow
approved these changes
Apr 18, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Jibing-Li
approved these changes
Apr 18, 2024
yiguolei
pushed a commit
that referenced
this pull request
Apr 18, 2024
dataroaring
pushed a commit
to dataroaring/incubator-doris
that referenced
this pull request
Apr 20, 2024
ByteYue
pushed a commit
to ByteYue/doris
that referenced
this pull request
May 15, 2024
…valid or not (apache#34263) This is a following pr of apache#33685 After apache#33703 merged, need to check update rows in column level instead of table level.
3 tasks
englefly
added a commit
to englefly/incubator-doris
that referenced
this pull request
May 28, 2024
…ed (apache#33685) (cherry picked from commit 3d14f66)
morrySnow
pushed a commit
that referenced
this pull request
May 29, 2024
…zed (#35533) cherry picked from master PR #33685 commit 3d14f66 if user queries newly loaded data (the new data are not analyzed), optimizer may generate inefficient plan because the newly loaded data is out of column stats min-max range. In this pr, we will ignore min-max if there are newly loaded data.
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…zed (apache#35533) cherry picked from master PR apache#33685 commit 3d14f66 if user queries newly loaded data (the new data are not analyzed), optimizer may generate inefficient plan because the newly loaded data is out of column stats min-max range. In this pr, we will ignore min-max if there are newly loaded data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
if user queries newly loaded data (the new data are not analyzed), optimizer may generate inefficient plan because the newly loaded data is out of column stats min-max range.
In this pr, we will ignore min-max if there are newly loaded data.
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...