Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore](log) Avoid too many 'token parser result is empty' #33921

Merged
merged 1 commit into from
Apr 21, 2024
Merged

[chore](log) Avoid too many 'token parser result is empty' #33921

merged 1 commit into from
Apr 21, 2024

Conversation

gavinchou
Copy link
Collaborator

there may be too many logs
image

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@gavinchou
Copy link
Collaborator Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39142 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 07680a22267538488cf56d6bce789f4ccacf9511, data reload: false

------ Round 1 ----------------------------------
q1	17696	5149	4379	4379
q2	2423	216	191	191
q3	10699	1152	1226	1152
q4	10734	832	709	709
q5	7715	2793	2705	2705
q6	226	137	138	137
q7	1059	660	617	617
q8	9364	2096	2083	2083
q9	7685	6587	6580	6580
q10	8554	3559	3571	3559
q11	451	244	235	235
q12	441	232	226	226
q13	17779	2913	2947	2913
q14	261	221	237	221
q15	525	477	478	477
q16	518	385	386	385
q17	965	707	669	669
q18	7539	6911	7047	6911
q19	7883	1539	1555	1539
q20	701	343	315	315
q21	3722	2830	2839	2830
q22	382	318	309	309
Total cold run time: 117322 ms
Total hot run time: 39142 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4346	4320	4196	4196
q2	382	275	279	275
q3	2993	2741	2774	2741
q4	1983	1624	1591	1591
q5	5394	5369	5323	5323
q6	210	124	126	124
q7	2222	1861	1884	1861
q8	3234	3391	3346	3346
q9	8670	8671	8613	8613
q10	3936	3707	3735	3707
q11	580	493	503	493
q12	763	613	616	613
q13	17322	2999	2939	2939
q14	300	289	283	283
q15	520	471	483	471
q16	484	439	431	431
q17	1798	1497	1484	1484
q18	7620	7381	7283	7283
q19	1645	1517	1522	1517
q20	1973	1749	1770	1749
q21	5100	4881	4834	4834
q22	554	472	470	470
Total cold run time: 72029 ms
Total hot run time: 54344 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184946 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 07680a22267538488cf56d6bce789f4ccacf9511, data reload: false

query1	902	385	370	370
query2	6479	2512	2369	2369
query3	6649	206	209	206
query4	24601	21214	21223	21214
query5	4160	427	424	424
query6	261	182	184	182
query7	4589	290	294	290
query8	237	179	189	179
query9	8869	2326	2317	2317
query10	569	270	267	267
query11	14863	14126	14172	14126
query12	151	87	93	87
query13	1641	368	365	365
query14	9055	8159	7664	7664
query15	275	180	195	180
query16	8185	268	291	268
query17	1867	584	547	547
query18	2104	273	268	268
query19	282	156	154	154
query20	94	88	97	88
query21	197	129	123	123
query22	5121	4842	4902	4842
query23	33799	33023	33173	33023
query24	10967	2988	2934	2934
query25	621	371	378	371
query26	1485	168	157	157
query27	2931	306	311	306
query28	7683	2029	1999	1999
query29	913	607	604	604
query30	266	172	168	168
query31	957	725	739	725
query32	100	54	55	54
query33	747	246	246	246
query34	1041	475	501	475
query35	857	693	689	689
query36	1085	890	926	890
query37	141	71	71	71
query38	3332	3184	3203	3184
query39	1602	1577	1529	1529
query40	257	123	126	123
query41	69	43	45	43
query42	107	98	99	98
query43	587	531	528	528
query44	1210	737	758	737
query45	267	253	266	253
query46	1084	751	752	751
query47	1932	1855	1857	1855
query48	374	290	291	290
query49	1134	399	390	390
query50	752	397	381	381
query51	6608	6600	6585	6585
query52	103	90	96	90
query53	352	283	279	279
query54	303	238	224	224
query55	78	73	71	71
query56	254	228	224	224
query57	1188	1102	1130	1102
query58	226	200	208	200
query59	3272	3253	3426	3253
query60	259	230	237	230
query61	93	86	88	86
query62	648	443	443	443
query63	300	272	277	272
query64	6407	4075	4044	4044
query65	3111	3040	3045	3040
query66	1393	343	348	343
query67	15546	15111	15352	15111
query68	5202	547	544	544
query69	484	301	322	301
query70	1254	1145	1134	1134
query71	1386	1272	1273	1272
query72	6473	2563	2408	2408
query73	715	322	324	322
query74	6989	6439	6447	6439
query75	3401	2666	2559	2559
query76	3256	985	1057	985
query77	446	264	262	262
query78	10954	10132	10214	10132
query79	3160	531	534	531
query80	1941	458	457	457
query81	538	251	245	245
query82	781	102	102	102
query83	327	167	171	167
query84	273	88	81	81
query85	2003	258	255	255
query86	534	309	267	267
query87	3401	3289	3232	3232
query88	4449	2338	2335	2335
query89	490	359	377	359
query90	2032	185	184	184
query91	128	108	100	100
query92	59	48	49	48
query93	4977	530	510	510
query94	1251	181	181	181
query95	392	306	295	295
query96	638	264	258	258
query97	3152	2942	2966	2942
query98	237	228	211	211
query99	1263	827	866	827
Total cold run time: 290178 ms
Total hot run time: 184946 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.67 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 07680a22267538488cf56d6bce789f4ccacf9511, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.03	0.04
query3	0.23	0.05	0.05
query4	1.66	0.09	0.10
query5	0.49	0.49	0.50
query6	1.48	0.72	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.05
query9	0.55	0.50	0.50
query10	0.55	0.56	0.56
query11	0.15	0.12	0.11
query12	0.15	0.12	0.12
query13	0.61	0.58	0.58
query14	0.75	0.78	0.77
query15	0.84	0.80	0.81
query16	0.36	0.37	0.37
query17	0.93	0.98	0.93
query18	0.21	0.23	0.24
query19	1.78	1.71	1.66
query20	0.02	0.01	0.01
query21	15.43	0.65	0.64
query22	4.38	6.38	2.18
query23	18.33	1.48	1.34
query24	2.02	0.22	0.20
query25	0.14	0.09	0.08
query26	0.25	0.16	0.15
query27	0.08	0.08	0.08
query28	13.31	1.00	0.98
query29	12.60	3.27	3.27
query30	0.25	0.07	0.06
query31	2.85	0.39	0.39
query32	3.26	0.46	0.47
query33	2.87	2.82	2.85
query34	17.01	4.40	4.54
query35	4.47	4.49	4.48
query36	0.65	0.47	0.47
query37	0.18	0.15	0.15
query38	0.16	0.15	0.14
query39	0.04	0.04	0.03
query40	0.16	0.14	0.13
query41	0.10	0.05	0.05
query42	0.05	0.04	0.04
query43	0.04	0.03	0.04
Total cold run time: 109.58 s
Total hot run time: 30.67 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.39% (8920/25208)
Line Coverage: 27.10% (73302/270529)
Region Coverage: 26.24% (37874/144358)
Branch Coverage: 23.03% (19276/83684)
Coverage Report: http://coverage.selectdb-in.cc/coverage/07680a22267538488cf56d6bce789f4ccacf9511_07680a22267538488cf56d6bce789f4ccacf9511/report/index.html

xiaokang
xiaokang approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 4f06106 into apache:master Apr 21, 2024
25 of 29 checks passed
yiguolei pushed a commit that referenced this pull request Apr 21, 2024
@gavinchou @Doris-Extras
[chore](log) Avoid too many 'token parser result is empty' (#33921)
00ff5f0
gavinchou added a commit to gavinchou/doris that referenced this pull request Jun 7, 2024
@gavinchou
[chore](log) Avoid too many 'token parser result is empty' (apache#33921
7cc93d2 
)
@gavinchou gavinchou mentioned this pull request Jun 7, 2024
Merged
dataroaring pushed a commit that referenced this pull request Jun 7, 2024
@gavinchou
[chore](log) Avoid too many 'token parser result is empty' (#33921) (#…
06ba383 
…36054)

pick master #33921
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@gavinchou
[chore](log) Avoid too many 'token parser result is empty' (apache#33921
e982f73 
) (apache#36054)

pick master apache#33921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaokang xiaokang xiaokang approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.12-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gavinchou @doris-robot @xiaokang @dataroaring