Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function 'get_next_data' has cognitive complexity of 62 (threshold 50) [readability-function-cognitive-complexity]
Additional context
be/src/vec/runtime/vsorted_run_merger.cpp:114: +1, including nesting penalty of 0, nesting level increased to 1
be/src/vec/runtime/vsorted_run_merger.cpp:116: +2, including nesting penalty of 1, nesting level increased to 2
if (has_next_block(cursor)) { ^
be/src/vec/runtime/vsorted_run_merger.cpp:122: +1, including nesting penalty of 0, nesting level increased to 1
if (_priority_queue.empty()) { ^
be/src/vec/runtime/vsorted_run_merger.cpp:125: +1, nesting level increased to 1
be/src/vec/runtime/vsorted_run_merger.cpp:127: +2, including nesting penalty of 1, nesting level increased to 2
be/src/vec/runtime/vsorted_run_merger.cpp:127: +1
be/src/vec/runtime/vsorted_run_merger.cpp:128: +3, including nesting penalty of 2, nesting level increased to 3
if (_offset >= current->rows - current->pos) { ^
be/src/vec/runtime/vsorted_run_merger.cpp:130: +4, including nesting penalty of 3, nesting level increased to 4
if (_pipeline_engine_enabled) { ^
be/src/vec/runtime/vsorted_run_merger.cpp:136: +1, nesting level increased to 3
} else { ^
be/src/vec/runtime/vsorted_run_merger.cpp:142: +2, including nesting penalty of 1, nesting level increased to 2
be/src/vec/runtime/vsorted_run_merger.cpp:143: +3, including nesting penalty of 2, nesting level increased to 3
be/src/vec/runtime/vsorted_run_merger.cpp:145: +4, including nesting penalty of 3, nesting level increased to 4
if (_pipeline_engine_enabled) { ^
be/src/vec/runtime/vsorted_run_merger.cpp:151: +1, nesting level increased to 3
} else { ^
be/src/vec/runtime/vsorted_run_merger.cpp:154: +1, nesting level increased to 2
} else { ^
be/src/vec/runtime/vsorted_run_merger.cpp:155: +3, including nesting penalty of 2, nesting level increased to 3
be/src/vec/runtime/vsorted_run_merger.cpp:156: +4, including nesting penalty of 3, nesting level increased to 4
be/src/vec/runtime/vsorted_run_merger.cpp:162: +4, including nesting penalty of 3, nesting level increased to 4
if (_pipeline_engine_enabled) { ^
be/src/vec/runtime/vsorted_run_merger.cpp:168: +1, nesting level increased to 3
} else { ^
be/src/vec/runtime/vsorted_run_merger.cpp:172: +1, nesting level increased to 1
} else { ^
be/src/vec/runtime/vsorted_run_merger.cpp:178: +2, including nesting penalty of 1, nesting level increased to 2
if (num_columns != merged_columns.size()) { ^
be/src/vec/runtime/vsorted_run_merger.cpp:187: +2, including nesting penalty of 1, nesting level increased to 2
while (!_priority_queue.empty()) { ^
be/src/vec/runtime/vsorted_run_merger.cpp:191: +3, including nesting penalty of 2, nesting level increased to 3
be/src/vec/runtime/vsorted_run_merger.cpp:193: +1, nesting level increased to 3
} else { ^
be/src/vec/runtime/vsorted_run_merger.cpp:194: +4, including nesting penalty of 3, nesting level increased to 4
be/src/vec/runtime/vsorted_run_merger.cpp:201: +3, including nesting penalty of 2, nesting level increased to 3
if (!next_heap(current)) { ^
be/src/vec/runtime/vsorted_run_merger.cpp:205: +3, including nesting penalty of 2, nesting level increased to 3
if (merged_rows == _batch_size) { ^
be/src/vec/runtime/vsorted_run_merger.cpp:211: +2, including nesting penalty of 1, nesting level increased to 2
be/src/vec/runtime/vsorted_run_merger.cpp:218: +1, including nesting penalty of 0, nesting level increased to 1
be/src/vec/runtime/vsorted_run_merger.cpp:218: +1