Skip to content

[Improvement](set) enable admin_set_frontend_config can apply to all fe #34751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lide-reed merged 1 commit into from
May 14, 2024
Merged

[Improvement](set) enable admin_set_frontend_config can apply to all fe #34751

lide-reed merged 1 commit into from
May 14, 2024

Conversation

@Yulei-Yang
Copy link
Contributor

@Yulei-Yang Yulei-Yang commented May 13, 2024

Proposed changes

bp: #34685

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented May 13, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label May 13, 2024
@Yulei-Yang
Copy link
Contributor Author

Yulei-Yang commented May 13, 2024

run buildall

@doris-robot
Copy link

doris-robot commented May 13, 2024

TPC-H: Total hot run time: 49564 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9edb2fbdfcfde4e36a7be95ebf1ac6f59f0f30ad, data reload: false

------ Round 1 ----------------------------------
q1	17658	4368	4297	4297
q2	2054	155	143	143
q3	10280	1891	1898	1891
q4	10383	1246	1324	1246
q5	8451	3868	3888	3868
q6	235	124	122	122
q7	2015	1575	1630	1575
q8	9495	2719	2689	2689
q9	10891	10341	10421	10341
q10	8616	3527	3501	3501
q11	429	232	243	232
q12	460	295	306	295
q13	18338	3957	4048	3957
q14	354	331	335	331
q15	505	452	466	452
q16	649	562	578	562
q17	1130	983	963	963
q18	7314	6948	6807	6807
q19	1684	1554	1492	1492
q20	541	309	314	309
q21	4431	4122	4146	4122
q22	489	369	395	369
Total cold run time: 116402 ms
Total hot run time: 49564 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4293	4290	4280	4280
q2	320	220	226	220
q3	4189	4153	4139	4139
q4	2753	2746	2760	2746
q5	7160	7163	7140	7140
q6	233	116	116	116
q7	3205	2912	2868	2868
q8	4364	4423	4518	4423
q9	17356	17009	17252	17009
q10	4236	4237	4263	4237
q11	735	687	726	687
q12	1028	857	847	847
q13	6686	3762	3713	3713
q14	444	434	423	423
q15	511	467	450	450
q16	733	677	677	677
q17	3815	3926	3809	3809
q18	8916	8843	8793	8793
q19	1714	1723	1682	1682
q20	2414	2134	2143	2134
q21	8522	8683	8583	8583
q22	1083	980	975	975
Total cold run time: 84710 ms
Total hot run time: 79951 ms

@doris-robot
Copy link

doris-robot commented May 13, 2024

TPC-DS: Total hot run time: 204808 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9edb2fbdfcfde4e36a7be95ebf1ac6f59f0f30ad, data reload: false

query1	947	405	398	398
query2	6651	3120	2980	2980
query3	7270	215	209	209
query4	20925	18302	18031	18031
query5	19784	6506	6516	6506
query6	418	217	232	217
query7	5257	307	295	295
query8	264	249	254	249
query9	3150	2750	2672	2672
query10	441	316	291	291
query11	11306	11029	10883	10883
query12	124	75	72	72
query13	5620	687	672	672
query14	18948	13676	13483	13483
query15	361	225	227	225
query16	6427	283	260	260
query17	1358	1492	869	869
query18	2281	406	403	403
query19	205	149	147	147
query20	87	78	84	78
query21	198	102	93	93
query22	5292	5170	5177	5170
query23	32337	31934	31810	31810
query24	6791	6551	6506	6506
query25	505	427	426	426
query26	534	165	161	161
query27	1684	302	293	293
query28	6196	2359	2339	2339
query29	2945	2758	2808	2758
query30	247	163	165	163
query31	899	752	742	742
query32	69	65	64	64
query33	402	257	244	244
query34	865	462	507	462
query35	1103	963	922	922
query36	1210	1194	1121	1121
query37	88	60	59	59
query38	3072	2922	2931	2922
query39	1367	1340	1315	1315
query40	202	97	95	95
query41	38	37	36	36
query42	87	77	82	77
query43	682	641	741	641
query44	1120	703	716	703
query45	242	231	231	231
query46	1218	992	977	977
query47	1817	1915	1693	1693
query48	998	703	690	690
query49	614	380	363	363
query50	857	598	611	598
query51	4769	4639	4687	4639
query52	94	71	85	71
query53	455	330	321	321
query54	2645	2447	2487	2447
query55	85	78	84	78
query56	249	226	218	218
query57	1229	1141	1084	1084
query58	221	202	209	202
query59	4518	3955	4033	3955
query60	228	209	199	199
query61	89	85	86	85
query62	841	455	470	455
query63	490	333	342	333
query64	2477	1519	1439	1439
query65	3641	3567	3569	3567
query66	754	376	376	376
query67	15784	15966	15747	15747
query68	8397	646	659	646
query69	579	350	365	350
query70	1791	1500	1668	1500
query71	400	315	319	315
query72	6483	3508	3473	3473
query73	752	328	337	328
query74	6326	5871	5873	5871
query75	4650	3651	3712	3651
query76	4783	1176	1187	1176
query77	654	254	262	254
query78	12768	11798	11653	11653
query79	7759	656	639	639
query80	1010	395	408	395
query81	500	231	229	229
query82	1617	96	93	93
query83	168	142	140	140
query84	253	69	70	69
query85	900	300	296	296
query86	339	298	307	298
query87	3240	3005	3082	3005
query88	4930	2357	2342	2342
query89	340	297	291	291
query90	1890	205	211	205
query91	171	149	134	134
query92	58	53	61	53
query93	3917	569	586	569
query94	766	202	206	202
query95	1092	1065	1048	1048
query96	650	343	328	328
query97	6563	6347	6429	6347
query98	185	180	170	170
query99	2930	908	914	908
Total cold run time: 310933 ms
Total hot run time: 204808 ms

@doris-robot
Copy link

doris-robot commented May 13, 2024

ClickBench: Total hot run time: 30.77 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9edb2fbdfcfde4e36a7be95ebf1ac6f59f0f30ad, data reload: false

query1	0.02	0.02	0.02
query2	0.07	0.02	0.03
query3	0.24	0.04	0.04
query4	1.79	0.06	0.07
query5	0.54	0.53	0.51
query6	1.24	0.62	0.65
query7	0.01	0.01	0.01
query8	0.03	0.02	0.02
query9	0.52	0.49	0.48
query10	0.55	0.53	0.54
query11	0.12	0.09	0.09
query12	0.11	0.10	0.09
query13	0.62	0.61	0.60
query14	0.77	0.78	0.77
query15	0.77	0.76	0.77
query16	0.37	0.36	0.39
query17	1.01	1.01	1.00
query18	0.22	0.26	0.24
query19	1.92	1.88	1.86
query20	0.02	0.01	0.00
query21	15.52	0.56	0.57
query22	2.04	2.30	1.63
query23	17.16	0.99	0.96
query24	6.71	0.74	1.09
query25	0.33	0.14	0.05
query26	0.78	0.15	0.16
query27	0.04	0.04	0.03
query28	6.60	0.76	0.76
query29	12.62	2.40	2.36
query30	0.55	0.52	0.52
query31	2.80	0.38	0.37
query32	3.39	0.49	0.50
query33	3.05	3.09	3.08
query34	15.25	4.82	4.78
query35	4.88	4.89	4.93
query36	1.07	1.05	1.06
query37	0.06	0.05	0.05
query38	0.03	0.02	0.02
query39	0.02	0.02	0.01
query40	0.16	0.14	0.14
query41	0.06	0.02	0.02
query42	0.02	0.01	0.02
query43	0.02	0.02	0.02
Total cold run time: 104.1 s
Total hot run time: 30.77 s

@doris-robot
Copy link

doris-robot commented May 13, 2024

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 9edb2fbdfcfde4e36a7be95ebf1ac6f59f0f30ad with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.8 seconds inserted 10000000 Rows, about 458K ops/s

@Yulei-Yang
Copy link
Contributor Author

Yulei-Yang commented May 13, 2024

run p0

@Yulei-Yang
Copy link
Contributor Author

Yulei-Yang commented May 13, 2024

rerun p0

2 similar comments
@Yulei-Yang
Copy link
Contributor Author

Yulei-Yang commented May 13, 2024

rerun p0

@Yulei-Yang
Copy link
Contributor Author

Yulei-Yang commented May 13, 2024

rerun p0

nextdreamblue
nextdreamblue approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@nextdreamblue nextdreamblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 13, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2024

PR approved by anyone and no changes requested.

lide-reed
lide-reed approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lide-reed lide-reed merged commit 17b1df5 into apache:branch-2.0 May 14, 2024
@Yulei-Yang Yulei-Yang deleted the admin_set_all_for_v2 branch June 6, 2024 02:12
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@Yulei-Yang
[Improvement](set) enable admin_set_frontend_config can apply to all …
07273f9 
…fe (apache#34751)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lide-reed lide-reed lide-reed approved these changes

@nextdreamblue nextdreamblue nextdreamblue approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Yulei-Yang @doris-robot @lide-reed @nextdreamblue @morningman