Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt](memory) QueryMemTracker not equal to 0 will crash at query end when Debug compile #35014

Merged
merged 1 commit into from
May 17, 2024

Conversation

xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented May 17, 2024

Proposed changes

to eliminate query memory leak !!!

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@xinyiZzz
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.70% (9006/25226)
Line Coverage: 27.38% (74534/272238)
Region Coverage: 26.62% (38538/144773)
Branch Coverage: 23.45% (19664/83872)
Coverage Report: http://coverage.selectdb-in.cc/coverage/75131a2d533e90fb87b97a6df7ce991d601ad46c_75131a2d533e90fb87b97a6df7ce991d601ad46c/report/index.html

@xinyiZzz xinyiZzz changed the title [opt](memory) In Debug compile, QueryMemTracker not equal to 0 will crash at query end [opt](memory) QueryMemTracker not equal to 0 will crash at query end when Debug compile May 17, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 17, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@xinyiZzz xinyiZzz merged commit 3002964 into apache:master May 17, 2024
27 of 31 checks passed
dataroaring pushed a commit that referenced this pull request May 26, 2024
…when Debug compile (#35014)

to eliminate query memory leak !!!
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request Sep 9, 2024
…when Debug compile (apache#35014)

to eliminate query memory leak !!!
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request Sep 9, 2024
…when Debug compile (apache#35014)

to eliminate query memory leak !!!
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request Sep 10, 2024
…when Debug compile (apache#35014)

to eliminate query memory leak !!!
yiguolei pushed a commit to xinyiZzz/incubator-doris that referenced this pull request Sep 10, 2024
…when Debug compile (apache#35014)

to eliminate query memory leak !!!
yiguolei pushed a commit to xinyiZzz/incubator-doris that referenced this pull request Sep 11, 2024
…when Debug compile (apache#35014)

to eliminate query memory leak !!!
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request Sep 13, 2024
…when Debug compile (apache#35014)

to eliminate query memory leak !!!
yiguolei added a commit that referenced this pull request Sep 14, 2024
pick
#33396
#33862
#33853
#33732
#33841
#33933
#34901
#35014

---------

Co-authored-by: yiguolei <676222867@qq.com>
Co-authored-by: yiguolei <yiguolei@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.0-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants