[improve](cloud) make tablet sync_rowsets async to reduce calculating delete bitmap time #35838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 43750 ms |
TPC-DS: Total hot run time: 173280 ms |
ClickBench: Total hot run time: 30.11 s |
|
TeamCity be ut coverage result: |
hust-hhb
force-pushed
the
async-sync-rowsets
branch
from
c0992d9 to
5396dab
Compare
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40837 ms |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-DS: Total hot run time: 172699 ms |
ClickBench: Total hot run time: 30.03 s |
|
TeamCity be ut coverage result: |
Yukang-Lian
approved these changes
Jun 5, 2024
… delete bitmap time sync_rowsets may cost too much time, make sync_rowsets async can reduce more than 90% times on calculating delete bitmap time in publish phase.
hust-hhb
force-pushed
the
async-sync-rowsets
branch
from
5396dab to
91141d0
Compare
github-actions
bot
removed
the
approved
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| void CloudTabletCalcDeleteBitmapTask::handle() const { | ||
| Status CloudTabletCalcDeleteBitmapTask::handle() const { |
Contributor
There was a problem hiding this comment.
warning: function 'handle' exceeds recommended size/complexity thresholds [readability-function-size]
Status CloudTabletCalcDeleteBitmapTask::handle() const {
^Additional context
be/src/cloud/cloud_engine_calc_delete_bitmap_task.cpp:109: 84 lines including whitespace and comments (threshold 80)
Status CloudTabletCalcDeleteBitmapTask::handle() const {
^
TPC-H: Total hot run time: 40355 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 172208 ms |
ClickBench: Total hot run time: 30.71 s |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
dataroaring
pushed a commit
that referenced
this pull request
Jun 13, 2024
… delete bitmap time (#35838) sync_rowsets may cost too much time, make sync_rowsets async can reduce more than 90% times on calculating delete bitmap time in publish phase.
dataroaring
pushed a commit
that referenced
this pull request
Jul 13, 2024
…phase if compaction on other BE finished during this load (#37670) ## Proposed changes Due to #35838, when executing load job, BE will not `sync_rowsets()` in publish phase if a compaction job is finished on another BE on the same tablet between the commit phase and the publish phase of the current load job. This PR let the meta service return the tablet compaction stats along with the getDeleteBitmapUpdateLockResponse to FE and FE will send them to BE to let the BE know whether it should `sync_rowsets()` due to compaction on other BEs.
dataroaring
pushed a commit
that referenced
this pull request
Jul 13, 2024
…phase if compaction on other BE finished during this load (#37670) ## Proposed changes Due to #35838, when executing load job, BE will not `sync_rowsets()` in publish phase if a compaction job is finished on another BE on the same tablet between the commit phase and the publish phase of the current load job. This PR let the meta service return the tablet compaction stats along with the getDeleteBitmapUpdateLockResponse to FE and FE will send them to BE to let the BE know whether it should `sync_rowsets()` due to compaction on other BEs.
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jul 17, 2024
…phase if compaction on other BE finished during this load (apache#37670) ## Proposed changes Due to apache#35838, when executing load job, BE will not `sync_rowsets()` in publish phase if a compaction job is finished on another BE on the same tablet between the commit phase and the publish phase of the current load job. This PR let the meta service return the tablet compaction stats along with the getDeleteBitmapUpdateLockResponse to FE and FE will send them to BE to let the BE know whether it should `sync_rowsets()` due to compaction on other BEs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync_rowsets may cost too much time, make sync_rowsets async can reduce more than 90% times on calculating delete bitmap time in publish phase.