Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](multicast) should not ignore Status of block::merge #35886

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

jacktengg
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@jacktengg
Copy link
Contributor Author

run buildall

Copy link
Contributor

github-actions bot commented Jun 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

@jacktengg
Copy link
Contributor Author

run buildall

Copy link
Contributor

github-actions bot commented Jun 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

github-actions bot commented Jun 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Jun 5, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 41584 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5c92ee0dd9213095719b21a5aa400df9462c6dbc, data reload: false

------ Round 1 ----------------------------------
q1	17665	4453	4280	4280
q2	2032	194	187	187
q3	10521	1136	1160	1136
q4	10218	810	860	810
q5	7487	2696	2808	2696
q6	217	133	137	133
q7	973	632	610	610
q8	9221	2126	2108	2108
q9	9352	6721	6733	6721
q10	9382	3948	3846	3846
q11	474	257	239	239
q12	453	233	234	233
q13	17326	3147	3249	3147
q14	275	221	228	221
q15	521	457	478	457
q16	493	380	395	380
q17	979	716	578	578
q18	8326	7818	7829	7818
q19	4859	1375	1451	1375
q20	642	316	314	314
q21	5160	3954	4122	3954
q22	385	341	346	341
Total cold run time: 116961 ms
Total hot run time: 41584 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4705	4457	4572	4457
q2	370	274	264	264
q3	3157	2978	2815	2815
q4	1874	1592	1655	1592
q5	5491	5502	5513	5502
q6	228	124	124	124
q7	2211	1784	1835	1784
q8	3267	3415	3416	3415
q9	8635	8619	8639	8619
q10	4093	3824	3721	3721
q11	586	485	493	485
q12	779	612	609	609
q13	17280	3154	3123	3123
q14	306	266	265	265
q15	527	472	476	472
q16	490	440	427	427
q17	1834	1483	1486	1483
q18	8195	7435	7396	7396
q19	1757	1574	1600	1574
q20	3025	1789	1783	1783
q21	4867	4835	4646	4646
q22	869	551	512	512
Total cold run time: 74546 ms
Total hot run time: 55068 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 171788 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5c92ee0dd9213095719b21a5aa400df9462c6dbc, data reload: false

query1	905	367	368	367
query2	6505	2357	2328	2328
query3	6651	201	208	201
query4	19247	17309	17132	17132
query5	4100	443	450	443
query6	255	179	160	160
query7	4599	289	290	289
query8	295	264	282	264
query9	8487	2418	2375	2375
query10	440	313	274	274
query11	10468	10048	9963	9963
query12	133	90	87	87
query13	1642	357	361	357
query14	8523	6908	7080	6908
query15	228	184	180	180
query16	7149	263	257	257
query17	1030	520	529	520
query18	1857	265	267	265
query19	201	148	158	148
query20	93	81	87	81
query21	216	140	134	134
query22	4453	4052	4019	4019
query23	33414	32786	32906	32786
query24	11261	2839	2813	2813
query25	612	349	351	349
query26	1184	152	151	151
query27	2450	309	315	309
query28	7181	2063	2049	2049
query29	915	616	617	616
query30	275	153	152	152
query31	971	743	743	743
query32	88	54	55	54
query33	780	273	270	270
query34	990	461	468	461
query35	731	609	608	608
query36	1090	912	925	912
query37	139	69	68	68
query38	2885	2777	2725	2725
query39	849	770	806	770
query40	202	121	120	120
query41	52	49	54	49
query42	119	101	99	99
query43	573	534	543	534
query44	1281	721	746	721
query45	198	166	165	165
query46	1073	712	696	696
query47	1871	1756	1745	1745
query48	388	295	286	286
query49	1019	401	395	395
query50	783	385	382	382
query51	7006	6709	6624	6624
query52	100	93	91	91
query53	352	298	292	292
query54	853	440	431	431
query55	73	70	73	70
query56	271	250	251	250
query57	1128	1068	1030	1030
query58	259	238	241	238
query59	3329	3112	3148	3112
query60	286	275	283	275
query61	112	106	127	106
query62	640	431	435	431
query63	313	280	281	280
query64	8922	2178	1737	1737
query65	3400	3083	3140	3083
query66	1236	330	326	326
query67	15458	15042	14864	14864
query68	4487	538	529	529
query69	464	312	319	312
query70	1177	1097	1127	1097
query71	380	293	286	286
query72	7162	5682	5708	5682
query73	741	322	318	318
query74	5897	5481	5469	5469
query75	3359	2653	2614	2614
query76	2343	960	886	886
query77	486	304	295	295
query78	10504	9837	9596	9596
query79	2810	506	513	506
query80	2354	484	481	481
query81	589	219	224	219
query82	835	97	105	97
query83	324	181	196	181
query84	284	88	91	88
query85	1583	336	315	315
query86	470	310	301	301
query87	3297	3057	3073	3057
query88	4049	2358	2346	2346
query89	482	395	377	377
query90	1857	194	189	189
query91	140	109	110	109
query92	70	50	52	50
query93	1950	519	496	496
query94	1298	193	190	190
query95	411	323	319	319
query96	591	263	263	263
query97	3181	3021	3012	3012
query98	238	229	221	221
query99	1359	867	882	867
Total cold run time: 269761 ms
Total hot run time: 171788 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.58 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5c92ee0dd9213095719b21a5aa400df9462c6dbc, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.23	0.06	0.06
query4	1.66	0.10	0.08
query5	0.51	0.49	0.50
query6	1.13	0.72	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.54	0.48	0.49
query10	0.54	0.54	0.55
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.59	0.59	0.60
query14	0.79	0.79	0.78
query15	0.82	0.81	0.83
query16	0.34	0.36	0.36
query17	0.95	0.95	0.96
query18	0.21	0.23	0.26
query19	1.78	1.65	1.67
query20	0.01	0.02	0.01
query21	15.48	0.68	0.67
query22	3.89	7.42	1.98
query23	18.23	1.35	1.24
query24	1.70	0.24	0.23
query25	0.14	0.08	0.07
query26	0.27	0.17	0.17
query27	0.08	0.08	0.08
query28	13.41	1.02	1.00
query29	12.98	3.39	3.35
query30	0.25	0.05	0.05
query31	2.90	0.38	0.39
query32	3.27	0.47	0.47
query33	2.87	2.95	2.91
query34	17.03	4.47	4.41
query35	4.48	4.44	4.66
query36	0.68	0.46	0.45
query37	0.18	0.16	0.16
query38	0.16	0.14	0.14
query39	0.05	0.03	0.04
query40	0.17	0.14	0.15
query41	0.09	0.05	0.04
query42	0.06	0.04	0.05
query43	0.04	0.04	0.03
Total cold run time: 109.01 s
Total hot run time: 30.58 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.42% (8986/24670)
Line Coverage: 27.93% (73384/262697)
Region Coverage: 27.38% (38008/138838)
Branch Coverage: 23.96% (19291/80500)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5c92ee0dd9213095719b21a5aa400df9462c6dbc_5c92ee0dd9213095719b21a5aa400df9462c6dbc/report/index.html

Copy link
Member

@mrhhsg mrhhsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacktengg jacktengg merged commit 5a8ea30 into apache:master Jun 5, 2024
26 of 29 checks passed
jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Jun 6, 2024
dataroaring pushed a commit that referenced this pull request Jun 7, 2024
## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Jul 16, 2024
jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Jul 16, 2024
jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants