Skip to content

[fix](schema-change) Fix schema-change from non-null to null #36389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 3 commits into from
Jun 26, 2024
Merged

[fix](schema-change) Fix schema-change from non-null to null #36389

dataroaring merged 3 commits into from
Jun 26, 2024

Conversation

@Lchangliang
Copy link
Contributor

@Lchangliang Lchangliang commented Jun 17, 2024

@doris-robot
Copy link

doris-robot commented Jun 17, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Lchangliang
Copy link
Contributor Author

Lchangliang commented Jun 17, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jun 17, 2024

TeamCity be ut coverage result:
Function Coverage: 36.30% (9132/25156)
Line Coverage: 27.78% (74228/267225)
Region Coverage: 26.72% (38310/143384)
Branch Coverage: 23.40% (19406/82918)
Coverage Report: http://coverage.selectdb-in.cc/coverage/216ec09940484c64c5f2c05b6c5857d8f68fa4ba_216ec09940484c64c5f2c05b6c5857d8f68fa4ba/report/index.html

dataroaring
dataroaring approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 17, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2024

PR approved by anyone and no changes requested.

@Lchangliang
Copy link
Contributor Author

Lchangliang commented Jun 21, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jun 21, 2024

TeamCity be ut coverage result:
Function Coverage: 36.34% (9148/25171)
Line Coverage: 27.87% (74586/267584)
Region Coverage: 26.79% (38479/143620)
Branch Coverage: 23.48% (19495/83018)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d857f09db163fc1e6b771899b92c230cdfab0c92_d857f09db163fc1e6b771899b92c230cdfab0c92/report/index.html

gavinchou
gavinchou reviewed Jun 22, 2024
View reviewed changes
be/src/olap/schema_change.cpp Outdated

if (null_map_column.size() != new_column->size() ||
nested_column.size() != new_column->size()) {
DCHECK(false);
Copy link
Contributor

@gavinchou gavinchou Jun 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Print more details like size and some ids or names

@Lchangliang
Copy link
Contributor Author

Lchangliang commented Jun 25, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jun 25, 2024

TeamCity be ut coverage result:
Function Coverage: 36.35% (9150/25172)
Line Coverage: 27.88% (74607/267634)
Region Coverage: 26.79% (38488/143656)
Branch Coverage: 23.47% (19494/83046)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9746d4fbfa46ed36f34ff3f14e82fbc96f641c69_9746d4fbfa46ed36f34ff3f14e82fbc96f641c69/report/index.html

@dataroaring dataroaring merged commit 23cf494 into apache:branch-2.1 Jun 26, 2024
@yiguolei yiguolei mentioned this pull request Jul 19, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou left review comments

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Lchangliang @doris-robot @gavinchou @dataroaring