Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](function) Optimize the trim function for single-char inputs #36497

Merged
merged 5 commits into from
Jun 28, 2024
Merged

[opt](function) Optimize the trim function for single-char inputs #36497

merged 5 commits into from
Jun 28, 2024
+92 −161

Conversation

Mryange
Copy link
Contributor

@Mryange Mryange commented Jun 18, 2024 •
edited
Loading

Proposed changes

before

mysql [test]>select count(ltrim(str,"1")) from stringDb2;
+------------------------+
| count(ltrim(str, '1')) |
+------------------------+
|               64000000 |
+------------------------+
1 row in set (7.79 sec)

now

mysql [test]>select count(ltrim(str,"1")) from stringDb2;
+------------------------+
| count(ltrim(str, '1')) |
+------------------------+
|               64000000 |
+------------------------+
1 row in set (0.73 sec)

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Mryange
Copy link
Contributor Author

Mryange commented Jun 18, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.48% (9004/24680)
Line Coverage: 28.04% (73780/263168)
Region Coverage: 27.50% (38321/139334)
Branch Coverage: 24.20% (19525/80698)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4750b8ff7e8e43090714e2e5693f64ea0f62e803_4750b8ff7e8e43090714e2e5693f64ea0f62e803/report/index.html

@Mryange
Copy link
Contributor Author

Mryange commented Jun 18, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.48% (9004/24680)
Line Coverage: 28.03% (73760/263168)
Region Coverage: 27.49% (38304/139334)
Branch Coverage: 24.19% (19520/80698)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4750b8ff7e8e43090714e2e5693f64ea0f62e803_4750b8ff7e8e43090714e2e5693f64ea0f62e803/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 40130 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4750b8ff7e8e43090714e2e5693f64ea0f62e803, data reload: false

------ Round 1 ----------------------------------
q1	18149	4395	4273	4273
q2	2030	194	188	188
q3	10456	1109	1179	1109
q4	10732	807	878	807
q5	8245	2692	2639	2639
q6	228	139	136	136
q7	985	612	597	597
q8	9234	2073	2125	2073
q9	9090	6643	6570	6570
q10	9104	3916	3864	3864
q11	453	242	254	242
q12	484	238	242	238
q13	19238	3042	3037	3037
q14	280	226	238	226
q15	527	500	498	498
q16	1033	416	389	389
q17	1060	728	649	649
q18	8193	7450	7259	7259
q19	7429	1536	1501	1501
q20	653	310	326	310
q21	5031	3186	3867	3186
q22	388	342	339	339
Total cold run time: 123022 ms
Total hot run time: 40130 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4386	4230	4338	4230
q2	401	276	281	276
q3	3153	2876	2928	2876
q4	1993	1704	1693	1693
q5	5443	5428	5543	5428
q6	224	138	128	128
q7	2172	1847	1853	1847
q8	3282	3424	3390	3390
q9	8727	8726	8717	8717
q10	3895	3983	3857	3857
q11	591	481	491	481
q12	791	643	617	617
q13	17115	3171	3245	3171
q14	307	268	266	266
q15	530	486	477	477
q16	485	415	425	415
q17	1804	1500	1531	1500
q18	8046	7931	7671	7671
q19	1821	1566	1598	1566
q20	2188	1836	1832	1832
q21	5133	4672	4972	4672
q22	633	543	579	543
Total cold run time: 73120 ms
Total hot run time: 55653 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173555 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4750b8ff7e8e43090714e2e5693f64ea0f62e803, data reload: false

query1	931	384	372	372
query2	6360	2599	2556	2556
query3	6637	207	205	205
query4	21822	17343	17401	17343
query5	3632	452	464	452
query6	244	160	152	152
query7	4584	289	283	283
query8	353	308	312	308
query9	8516	2386	2372	2372
query10	562	315	310	310
query11	10466	9974	10167	9974
query12	119	87	84	84
query13	1639	363	371	363
query14	10153	7754	6890	6890
query15	237	196	189	189
query16	7809	290	268	268
query17	1871	528	511	511
query18	1983	272	268	268
query19	206	154	156	154
query20	93	83	81	81
query21	211	126	126	126
query22	4418	4022	4031	4022
query23	33772	33501	33733	33501
query24	11101	2902	2760	2760
query25	613	387	368	368
query26	951	150	152	150
query27	2433	334	321	321
query28	6750	2121	2102	2102
query29	886	649	617	617
query30	248	154	154	154
query31	996	775	755	755
query32	87	51	52	51
query33	751	294	272	272
query34	993	494	485	485
query35	766	687	636	636
query36	1154	970	959	959
query37	136	71	79	71
query38	2930	2862	2776	2776
query39	914	860	799	799
query40	206	122	117	117
query41	59	46	50	46
query42	117	95	97	95
query43	593	569	590	569
query44	1139	711	728	711
query45	197	164	164	164
query46	1062	693	708	693
query47	1866	1752	1766	1752
query48	369	299	291	291
query49	848	399	421	399
query50	756	388	388	388
query51	6718	6725	6711	6711
query52	103	88	98	88
query53	363	291	283	283
query54	874	451	445	445
query55	71	74	71	71
query56	311	251	266	251
query57	1124	1025	1039	1025
query58	244	238	247	238
query59	3658	3373	3505	3373
query60	297	266	284	266
query61	95	91	93	91
query62	597	433	447	433
query63	313	283	282	282
query64	8753	2225	1815	1815
query65	3190	3099	3092	3092
query66	736	325	332	325
query67	15669	15083	14940	14940
query68	5880	537	531	531
query69	631	460	383	383
query70	1158	1122	1100	1100
query71	467	281	269	269
query72	7490	5293	5828	5293
query73	770	325	325	325
query74	5816	5528	5465	5465
query75	3741	2737	2667	2667
query76	3160	899	970	899
query77	598	293	296	293
query78	10452	9862	9668	9668
query79	2489	513	511	511
query80	1666	466	464	464
query81	528	215	214	214
query82	1448	102	104	102
query83	257	170	162	162
query84	263	90	87	87
query85	1277	300	335	300
query86	460	325	294	294
query87	3216	3068	3079	3068
query88	3592	2385	2397	2385
query89	483	373	381	373
query90	1687	201	191	191
query91	123	103	101	101
query92	58	48	52	48
query93	2371	530	519	519
query94	1030	182	179	179
query95	396	316	305	305
query96	592	272	261	261
query97	3256	3063	3044	3044
query98	210	194	200	194
query99	1214	860	846	846
Total cold run time: 275434 ms
Total hot run time: 173555 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.34 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4750b8ff7e8e43090714e2e5693f64ea0f62e803, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.67	0.10	0.10
query5	0.48	0.50	0.49
query6	1.12	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.53	0.49	0.48
query10	0.54	0.54	0.53
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.59	0.59	0.60
query14	0.78	0.78	0.79
query15	0.83	0.80	0.81
query16	0.37	0.35	0.38
query17	1.01	0.93	0.94
query18	0.21	0.28	0.23
query19	1.84	1.69	1.68
query20	0.01	0.01	0.01
query21	15.44	0.66	0.65
query22	4.09	7.69	1.93
query23	18.35	1.32	1.28
query24	2.16	0.21	0.22
query25	0.15	0.08	0.09
query26	0.27	0.19	0.18
query27	0.09	0.08	0.07
query28	13.20	1.00	0.99
query29	12.64	3.26	3.24
query30	0.25	0.06	0.06
query31	2.86	0.38	0.38
query32	3.29	0.46	0.46
query33	2.91	2.87	2.87
query34	16.96	4.40	4.37
query35	4.47	4.44	4.47
query36	0.65	0.46	0.50
query37	0.18	0.15	0.16
query38	0.15	0.14	0.13
query39	0.04	0.04	0.03
query40	0.17	0.14	0.15
query41	0.09	0.05	0.06
query42	0.06	0.04	0.04
query43	0.05	0.03	0.03
Total cold run time: 109.23 s
Total hot run time: 30.34 s

@Mryange
Copy link
Contributor Author

Mryange commented Jun 19, 2024

run buildall

@Mryange
Copy link
Contributor Author

Mryange commented Jun 19, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.48% (9004/24680)
Line Coverage: 28.03% (73769/263166)
Region Coverage: 27.50% (38315/139334)
Branch Coverage: 24.19% (19523/80698)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f7bd50debad462c7e3ac70c61e95b26b38e40041_f7bd50debad462c7e3ac70c61e95b26b38e40041/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 39469 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f7bd50debad462c7e3ac70c61e95b26b38e40041, data reload: false

------ Round 1 ----------------------------------
q1	17615	4258	4238	4238
q2	2020	187	190	187
q3	10462	1147	1055	1055
q4	10181	760	768	760
q5	7463	2633	2574	2574
q6	215	133	132	132
q7	939	615	598	598
q8	9221	2042	2065	2042
q9	8942	6501	6418	6418
q10	8957	3668	3650	3650
q11	462	234	234	234
q12	512	228	216	216
q13	17763	3006	2965	2965
q14	256	213	220	213
q15	506	476	475	475
q16	526	373	392	373
q17	954	652	731	652
q18	7970	7539	7475	7475
q19	4683	1447	1450	1447
q20	650	313	330	313
q21	4844	3115	3900	3115
q22	411	337	345	337
Total cold run time: 115552 ms
Total hot run time: 39469 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4392	4215	4263	4215
q2	361	277	269	269
q3	2938	2720	2951	2720
q4	1926	1686	1690	1686
q5	5506	5511	5500	5500
q6	236	133	131	131
q7	2178	1832	1815	1815
q8	3270	3393	3381	3381
q9	9098	9007	9206	9007
q10	4050	3946	3680	3680
q11	584	511	487	487
q12	833	645	639	639
q13	17016	3126	3123	3123
q14	319	279	265	265
q15	539	483	486	483
q16	520	424	441	424
q17	1831	1525	1503	1503
q18	8072	7927	7843	7843
q19	1878	1677	1567	1567
q20	3024	1913	1856	1856
q21	5078	4978	4630	4630
q22	624	541	555	541
Total cold run time: 74273 ms
Total hot run time: 55765 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174132 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f7bd50debad462c7e3ac70c61e95b26b38e40041, data reload: false

query1	933	383	384	383
query2	6456	2483	2357	2357
query3	6627	205	206	205
query4	20241	17202	17273	17202
query5	3631	479	460	460
query6	236	162	159	159
query7	4586	293	292	292
query8	315	298	288	288
query9	8570	2413	2397	2397
query10	572	294	289	289
query11	10517	9949	10023	9949
query12	121	94	86	86
query13	1664	376	369	369
query14	9335	7677	7600	7600
query15	224	191	188	188
query16	7916	271	271	271
query17	1883	557	540	540
query18	2037	284	276	276
query19	199	159	158	158
query20	93	84	90	84
query21	210	126	126	126
query22	4316	3980	4054	3980
query23	33876	33735	33629	33629
query24	10894	2924	2893	2893
query25	645	377	372	372
query26	730	161	159	159
query27	2324	344	317	317
query28	6325	2107	2133	2107
query29	891	635	621	621
query30	232	162	156	156
query31	959	769	773	769
query32	97	50	57	50
query33	756	291	290	290
query34	1014	485	485	485
query35	739	640	646	640
query36	1164	965	981	965
query37	136	70	71	70
query38	2916	2868	2848	2848
query39	854	802	831	802
query40	203	128	128	128
query41	54	56	52	52
query42	105	120	102	102
query43	604	559	533	533
query44	1235	712	726	712
query45	197	156	161	156
query46	1079	722	735	722
query47	1859	1765	1797	1765
query48	370	287	292	287
query49	847	404	409	404
query50	766	391	387	387
query51	6853	6626	6661	6626
query52	96	90	91	90
query53	379	293	288	288
query54	893	442	446	442
query55	75	73	72	72
query56	277	256	260	256
query57	1104	1029	1066	1029
query58	276	244	237	237
query59	3564	3253	3225	3225
query60	286	263	276	263
query61	127	91	89	89
query62	608	435	439	435
query63	314	292	292	292
query64	8686	2226	1716	1716
query65	3208	3116	3143	3116
query66	738	324	326	324
query67	15251	14988	14964	14964
query68	4512	538	542	538
query69	650	453	366	366
query70	1120	1156	1102	1102
query71	436	273	265	265
query72	6731	5320	5495	5320
query73	747	323	324	323
query74	5911	5441	5560	5441
query75	3428	2659	2642	2642
query76	2788	952	995	952
query77	662	301	311	301
query78	10507	9915	9752	9752
query79	2331	512	503	503
query80	1519	474	451	451
query81	600	217	225	217
query82	807	103	99	99
query83	291	166	167	166
query84	259	89	86	86
query85	1428	277	272	272
query86	465	309	325	309
query87	3290	3198	3081	3081
query88	3835	2366	2349	2349
query89	482	443	377	377
query90	1746	186	189	186
query91	130	96	97	96
query92	65	48	47	47
query93	2310	502	502	502
query94	1086	189	193	189
query95	411	318	312	312
query96	602	270	270	270
query97	3217	3054	3118	3054
query98	217	200	212	200
query99	1175	820	829	820
Total cold run time: 269046 ms
Total hot run time: 174132 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.84 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f7bd50debad462c7e3ac70c61e95b26b38e40041, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.05
query3	0.22	0.05	0.05
query4	1.69	0.08	0.09
query5	0.50	0.47	0.49
query6	1.13	0.72	0.72
query7	0.02	0.02	0.02
query8	0.05	0.04	0.04
query9	0.54	0.48	0.49
query10	0.54	0.55	0.55
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.59	0.58	0.60
query14	0.76	0.77	0.76
query15	0.81	0.82	0.81
query16	0.35	0.36	0.37
query17	0.97	0.98	0.96
query18	0.21	0.25	0.22
query19	1.81	1.69	1.72
query20	0.01	0.01	0.01
query21	15.41	0.64	0.63
query22	4.24	7.70	1.37
query23	18.30	1.32	1.26
query24	2.13	0.23	0.21
query25	0.15	0.10	0.10
query26	0.27	0.18	0.17
query27	0.09	0.09	0.08
query28	13.20	1.02	1.00
query29	12.58	3.31	3.26
query30	0.27	0.06	0.06
query31	2.90	0.38	0.38
query32	3.86	0.47	0.47
query33	2.88	2.87	2.92
query34	17.09	4.44	4.40
query35	4.44	4.46	4.49
query36	0.66	0.47	0.46
query37	0.18	0.14	0.15
query38	0.16	0.15	0.14
query39	0.04	0.03	0.04
query40	0.17	0.15	0.14
query41	0.10	0.05	0.04
query42	0.06	0.04	0.04
query43	0.05	0.03	0.04
Total cold run time: 109.86 s
Total hot run time: 29.84 s

HappenLee
HappenLee previously approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Mryange
Copy link
Contributor Author

Mryange commented Jun 19, 2024

run p0

@Mryange
Copy link
Contributor Author

Mryange commented Jun 19, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.46% (8999/24680)
Line Coverage: 28.01% (73750/263318)
Region Coverage: 27.48% (38290/139326)
Branch Coverage: 24.18% (19518/80704)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d50b6d394ce2146a7a27b7140f6888c9783aac6b_d50b6d394ce2146a7a27b7140f6888c9783aac6b/report/index.html

@doris-robot
Copy link

ClickBench: Total hot run time: 30.95 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d50b6d394ce2146a7a27b7140f6888c9783aac6b, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.67	0.10	0.09
query5	0.49	0.49	0.48
query6	1.13	0.75	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.55	0.49	0.50
query10	0.54	0.55	0.54
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.60	0.58	0.60
query14	0.78	0.78	0.78
query15	0.83	0.82	0.81
query16	0.36	0.37	0.36
query17	0.97	0.99	1.03
query18	0.20	0.26	0.25
query19	1.91	1.77	1.85
query20	0.01	0.01	0.01
query21	15.41	0.66	0.66
query22	4.08	6.96	2.16
query23	18.32	1.33	1.26
query24	2.14	0.23	0.21
query25	0.15	0.08	0.09
query26	0.26	0.18	0.18
query27	0.08	0.09	0.08
query28	13.24	1.02	1.00
query29	12.63	3.32	3.31
query30	0.27	0.07	0.07
query31	2.86	0.38	0.38
query32	3.27	0.48	0.47
query33	2.93	2.90	2.91
query34	17.16	4.44	4.41
query35	4.47	4.46	4.48
query36	0.63	0.49	0.47
query37	0.17	0.15	0.14
query38	0.15	0.15	0.14
query39	0.05	0.04	0.03
query40	0.18	0.15	0.13
query41	0.10	0.05	0.05
query42	0.06	0.05	0.04
query43	0.05	0.04	0.04
Total cold run time: 109.42 s
Total hot run time: 30.95 s

@Mryange
Copy link
Contributor Author

Mryange commented Jun 19, 2024

run p0

@Mryange
Copy link
Contributor Author

Mryange commented Jun 20, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Mryange
Copy link
Contributor Author

Mryange commented Jun 20, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.48% (9005/24688)
Line Coverage: 28.02% (73812/263438)
Region Coverage: 27.50% (38332/139393)
Branch Coverage: 24.20% (19537/80744)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3c8689b657f569882788764bed0d14688ef91fb4_3c8689b657f569882788764bed0d14688ef91fb4/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 40468 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3c8689b657f569882788764bed0d14688ef91fb4, data reload: false

------ Round 1 ----------------------------------
q1	10794	4347	4290	4290
q2	1137	202	194	194
q3	1385	1118	1178	1118
q4	1032	820	829	820
q5	2658	2672	2628	2628
q6	222	136	161	136
q7	1067	721	648	648
q8	2024	2087	2082	2082
q9	7003	6968	6927	6927
q10	3874	3749	3736	3736
q11	357	239	248	239
q12	392	243	233	233
q13	17109	2993	2984	2984
q14	270	215	219	215
q15	524	475	471	471
q16	488	404	387	387
q17	964	683	682	682
q18	7996	7706	7359	7359
q19	1619	1558	1478	1478
q20	543	312	337	312
q21	5630	3185	3272	3185
q22	413	344	347	344
Total cold run time: 67501 ms
Total hot run time: 40468 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4292	4239	4267	4239
q2	370	267	273	267
q3	3041	2834	2710	2710
q4	1883	1625	1687	1625
q5	5294	5300	5309	5300
q6	216	127	129	127
q7	2151	1743	1711	1711
q8	3203	3335	3360	3335
q9	8846	8861	8797	8797
q10	3901	3705	3717	3705
q11	557	485	492	485
q12	776	628	588	588
q13	3558	3035	2987	2987
q14	293	248	263	248
q15	521	478	472	472
q16	453	428	416	416
q17	1753	1459	1483	1459
q18	7577	7626	7441	7441
q19	1676	1594	1580	1580
q20	1987	1797	1779	1779
q21	4851	4834	4700	4700
q22	595	520	548	520
Total cold run time: 57794 ms
Total hot run time: 54491 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 169343 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3c8689b657f569882788764bed0d14688ef91fb4, data reload: false

query1	925	393	379	379
query2	6465	2379	2305	2305
query3	6655	208	209	208
query4	19037	17253	17112	17112
query5	4165	492	452	452
query6	250	162	163	162
query7	4594	300	288	288
query8	315	287	288	287
query9	8609	2430	2424	2424
query10	636	283	268	268
query11	10513	9987	10136	9987
query12	134	91	80	80
query13	1634	366	358	358
query14	10084	7588	7167	7167
query15	232	187	190	187
query16	7886	269	258	258
query17	1906	529	516	516
query18	1985	265	267	265
query19	200	166	179	166
query20	95	87	85	85
query21	205	133	124	124
query22	4263	4021	4179	4021
query23	33843	33151	32966	32966
query24	10866	2830	2764	2764
query25	588	369	362	362
query26	707	151	149	149
query27	2254	319	314	314
query28	5942	2055	2060	2055
query29	891	615	600	600
query30	286	149	152	149
query31	932	734	770	734
query32	95	53	54	53
query33	661	275	273	273
query34	866	463	459	459
query35	749	608	622	608
query36	1131	931	935	931
query37	139	68	67	67
query38	2854	2725	2730	2725
query39	846	789	785	785
query40	213	131	126	126
query41	57	53	55	53
query42	132	100	101	100
query43	591	563	542	542
query44	1096	725	733	725
query45	195	168	170	168
query46	1120	711	745	711
query47	1855	1752	1771	1752
query48	382	290	301	290
query49	1036	400	398	398
query50	763	403	370	370
query51	6753	6690	6607	6607
query52	107	95	89	89
query53	357	292	286	286
query54	876	433	435	433
query55	77	75	72	72
query56	303	257	247	247
query57	1144	1054	1061	1054
query58	254	238	279	238
query59	3461	3236	3153	3153
query60	292	274	270	270
query61	93	90	86	86
query62	643	442	455	442
query63	316	285	285	285
query64	8655	2339	1751	1751
query65	3221	3110	3133	3110
query66	821	333	338	333
query67	15517	14842	15079	14842
query68	4627	533	528	528
query69	542	440	394	394
query70	1151	1170	1126	1126
query71	401	282	268	268
query72	7144	2753	2540	2540
query73	745	321	320	320
query74	5888	5458	5486	5458
query75	3502	2646	2657	2646
query76	2491	970	868	868
query77	632	294	285	285
query78	10266	9985	9744	9744
query79	2089	504	506	504
query80	2272	467	461	461
query81	593	221	222	221
query82	971	102	106	102
query83	304	178	167	167
query84	257	90	83	83
query85	1110	288	276	276
query86	379	321	284	284
query87	3275	3103	3031	3031
query88	3392	2346	2367	2346
query89	496	386	397	386
query90	1708	190	187	187
query91	126	103	97	97
query92	57	48	51	48
query93	1582	519	495	495
query94	1178	191	183	183
query95	405	313	317	313
query96	640	265	266	265
query97	3261	3035	3074	3035
query98	214	193	191	191
query99	1253	865	894	865
Total cold run time: 267719 ms
Total hot run time: 169343 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.57 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3c8689b657f569882788764bed0d14688ef91fb4, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.69	0.07	0.06
query5	0.50	0.49	0.47
query6	1.14	0.72	0.72
query7	0.02	0.01	0.01
query8	0.05	0.05	0.04
query9	0.54	0.49	0.49
query10	0.55	0.54	0.54
query11	0.15	0.11	0.12
query12	0.15	0.12	0.12
query13	0.60	0.58	0.60
query14	0.78	0.77	0.78
query15	0.84	0.81	0.82
query16	0.37	0.37	0.35
query17	1.00	0.95	1.03
query18	0.22	0.27	0.25
query19	1.83	1.78	1.81
query20	0.01	0.01	0.02
query21	15.45	0.66	0.64
query22	3.70	6.80	3.02
query23	18.26	1.40	1.29
query24	2.14	0.22	0.22
query25	0.15	0.07	0.07
query26	0.26	0.17	0.17
query27	0.08	0.08	0.09
query28	13.20	1.01	1.01
query29	12.60	3.25	3.23
query30	0.26	0.08	0.06
query31	2.84	0.38	0.39
query32	3.28	0.46	0.46
query33	2.89	2.82	2.91
query34	17.32	4.47	4.39
query35	4.51	4.58	4.50
query36	0.66	0.46	0.46
query37	0.19	0.16	0.16
query38	0.15	0.15	0.14
query39	0.04	0.03	0.04
query40	0.17	0.14	0.15
query41	0.09	0.04	0.04
query42	0.06	0.05	0.05
query43	0.05	0.03	0.03
Total cold run time: 109.14 s
Total hot run time: 31.57 s

@Mryange
Copy link
Contributor Author

Mryange commented Jun 23, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39461 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3c8689b657f569882788764bed0d14688ef91fb4, data reload: false

------ Round 1 ----------------------------------
q1	17610	4326	4250	4250
q2	2012	188	187	187
q3	10460	1149	1058	1058
q4	10199	713	688	688
q5	7467	2676	2589	2589
q6	219	133	136	133
q7	935	603	597	597
q8	9223	2087	2035	2035
q9	8985	6482	6434	6434
q10	8933	3697	3695	3695
q11	432	245	229	229
q12	540	226	219	219
q13	18681	2950	2951	2950
q14	278	220	231	220
q15	527	467	485	467
q16	521	375	380	375
q17	972	721	692	692
q18	7977	7547	7466	7466
q19	8153	1421	1456	1421
q20	652	319	324	319
q21	4967	3107	3831	3107
q22	400	330	337	330
Total cold run time: 120143 ms
Total hot run time: 39461 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4413	4260	4232	4232
q2	386	276	271	271
q3	3054	2816	2940	2816
q4	1937	1724	1692	1692
q5	5490	5491	5430	5430
q6	221	138	130	130
q7	2262	1865	1800	1800
q8	3258	3440	3368	3368
q9	8667	8753	8693	8693
q10	4164	3776	3817	3776
q11	590	502	481	481
q12	840	651	624	624
q13	17047	3111	3188	3111
q14	296	278	272	272
q15	540	484	471	471
q16	485	435	447	435
q17	1779	1485	1459	1459
q18	8148	8127	7941	7941
q19	1772	1640	1613	1613
q20	2109	1851	1857	1851
q21	8473	4653	4853	4653
q22	638	542	559	542
Total cold run time: 76569 ms
Total hot run time: 55661 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173909 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3c8689b657f569882788764bed0d14688ef91fb4, data reload: false

query1	908	387	371	371
query2	6440	2415	2322	2322
query3	6632	208	213	208
query4	19205	17216	17133	17133
query5	3720	462	471	462
query6	237	166	167	166
query7	4582	294	289	289
query8	330	299	279	279
query9	8625	2339	2312	2312
query10	556	303	285	285
query11	10643	10102	10079	10079
query12	113	81	81	81
query13	1634	374	361	361
query14	10170	7640	7637	7637
query15	230	194	190	190
query16	7838	278	262	262
query17	1905	566	531	531
query18	2019	291	297	291
query19	199	154	161	154
query20	94	84	82	82
query21	220	128	129	128
query22	4308	4026	4119	4026
query23	33717	33806	33549	33549
query24	10779	2958	2841	2841
query25	617	411	387	387
query26	705	157	153	153
query27	2218	316	329	316
query28	6039	2122	2134	2122
query29	906	652	652	652
query30	256	157	154	154
query31	970	755	763	755
query32	95	58	56	56
query33	692	300	308	300
query34	910	502	480	480
query35	753	661	668	661
query36	1132	992	969	969
query37	145	79	76	76
query38	2985	2862	2842	2842
query39	888	837	842	837
query40	214	138	129	129
query41	54	51	55	51
query42	115	102	98	98
query43	582	561	546	546
query44	1075	731	748	731
query45	195	164	169	164
query46	1078	717	703	703
query47	1879	1797	1764	1764
query48	375	299	299	299
query49	857	429	428	428
query50	756	393	401	393
query51	6920	6847	6702	6702
query52	103	97	93	93
query53	362	283	286	283
query54	921	447	534	447
query55	74	74	73	73
query56	286	252	265	252
query57	1133	1033	1055	1033
query58	237	238	232	232
query59	3446	3063	3045	3045
query60	310	262	270	262
query61	91	91	87	87
query62	602	418	445	418
query63	315	293	292	292
query64	8503	2184	1749	1749
query65	3168	3101	3093	3093
query66	745	331	327	327
query67	15536	14846	14757	14757
query68	8158	546	563	546
query69	727	450	369	369
query70	1159	1146	1134	1134
query71	528	268	271	268
query72	8999	5389	5628	5389
query73	1004	325	320	320
query74	6114	5509	5489	5489
query75	4797	2650	2639	2639
query76	4408	934	922	922
query77	757	306	306	306
query78	10483	9916	9672	9672
query79	8276	508	515	508
query80	989	463	460	460
query81	566	217	222	217
query82	529	104	102	102
query83	344	168	164	164
query84	273	87	85	85
query85	923	320	282	282
query86	358	311	273	273
query87	3293	3105	3066	3066
query88	4736	2430	2436	2430
query89	517	369	391	369
query90	1991	180	187	180
query91	128	99	101	99
query92	61	49	47	47
query93	6662	502	501	501
query94	1276	187	183	183
query95	400	306	308	306
query96	618	268	268	268
query97	3227	3038	3053	3038
query98	213	210	191	191
query99	1175	836	846	836
Total cold run time: 288036 ms
Total hot run time: 173909 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.1 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3c8689b657f569882788764bed0d14688ef91fb4, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.04	0.04
query3	0.22	0.05	0.06
query4	1.66	0.10	0.07
query5	0.51	0.49	0.49
query6	1.15	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.04	0.05
query9	0.54	0.49	0.50
query10	0.54	0.53	0.55
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.59	0.58	0.59
query14	0.77	0.77	0.77
query15	0.85	0.81	0.82
query16	0.37	0.35	0.34
query17	1.04	1.04	1.02
query18	0.22	0.23	0.26
query19	1.78	1.71	1.74
query20	0.02	0.01	0.01
query21	15.41	0.66	0.66
query22	4.39	6.66	2.51
query23	18.29	1.32	1.22
query24	2.14	0.21	0.22
query25	0.16	0.08	0.08
query26	0.26	0.18	0.18
query27	0.08	0.08	0.09
query28	13.25	1.01	0.98
query29	12.58	3.33	3.31
query30	0.26	0.07	0.06
query31	2.86	0.38	0.38
query32	3.30	0.46	0.47
query33	2.85	2.92	2.91
query34	17.17	4.41	4.36
query35	4.48	4.46	4.45
query36	0.65	0.51	0.46
query37	0.18	0.15	0.15
query38	0.16	0.15	0.14
query39	0.04	0.04	0.04
query40	0.18	0.15	0.15
query41	0.09	0.06	0.05
query42	0.07	0.05	0.05
query43	0.04	0.03	0.04
Total cold run time: 109.63 s
Total hot run time: 31.1 s

HappenLee
HappenLee approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 24, 2024
wangbo
wangbo approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel39 Gabriel39 merged commit f836147 into apache:master Jun 28, 2024
25 of 29 checks passed
dataroaring pushed a commit that referenced this pull request Jun 28, 2024
@Mryange @dataroaring
[opt](function) Optimize the trim function for single-char inputs (#3…
b64a84d 
…6497)

before
```
mysql [test]>select count(ltrim(str,"1")) from stringDb2;
+------------------------+
| count(ltrim(str, '1')) |
+------------------------+
|               64000000 |
+------------------------+
1 row in set (7.79 sec)
```

now
```
mysql [test]>select count(ltrim(str,"1")) from stringDb2;
+------------------------+
| count(ltrim(str, '1')) |
+------------------------+
|               64000000 |
+------------------------+
1 row in set (0.73 sec)
```
@Mryange Mryange mentioned this pull request Jul 2, 2024
Merged
Mryange added a commit to Mryange/doris that referenced this pull request Jul 15, 2024
@Mryange
[opt](function) Optimize the trim function for single-char inputs (ap…
4c05861 
…ache#36497)

before
```
mysql [test]>select count(ltrim(str,"1")) from stringDb2;
+------------------------+
| count(ltrim(str, '1')) |
+------------------------+
|               64000000 |
+------------------------+
1 row in set (7.79 sec)
```

now
```
mysql [test]>select count(ltrim(str,"1")) from stringDb2;
+------------------------+
| count(ltrim(str, '1')) |
+------------------------+
|               64000000 |
+------------------------+
1 row in set (0.73 sec)
```
@Mryange Mryange mentioned this pull request Jul 15, 2024
Merged
yiguolei pushed a commit that referenced this pull request Jul 16, 2024
@Mryange
[opt](function) Optimize the trim function for single-char inputs (#3… (
cc6ff12 
#37799)

#36497

before
```
mysql [test]>select count(ltrim(str,"1")) from stringDb2;
+------------------------+
| count(ltrim(str, '1')) |
+------------------------+
|               64000000 |
+------------------------+
1 row in set (7.79 sec)
```

now
```
mysql [test]>select count(ltrim(str,"1")) from stringDb2;
+------------------------+
| count(ltrim(str, '1')) |
+------------------------+
|               64000000 |
+------------------------+
1 row in set (0.73 sec)
```

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zclllyybb zclllyybb zclllyybb left review comments

@HappenLee HappenLee HappenLee approved these changes

@wangbo wangbo wangbo approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.x dev/2.1.5-merged dev/3.0.0-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Mryange @doris-robot @HappenLee @wangbo @zclllyybb @yiguolei @Gabriel39 @dataroaring