Support create materialized view with bitmap or hll #3651
Conversation
|
For Review , add UT later |
HangyuanLiu
added
area/materialized-view
morningman
left a comment
morningman
left a comment
There was a problem hiding this comment.
And by the way, when the bitmap and hll types are not yet supported on the BE side, should these new operations be prohibited first?
fe/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
Outdated
Show resolved
Hide resolved
fe/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
Show resolved
Hide resolved
| Preconditions.checkState(functionCallExpr.getChildren().size() == 1); | ||
| Expr functionChild0 = functionCallExpr.getChild(0); | ||
|
|
||
| if (functionName.equalsIgnoreCase("bitmap_union") || functionName.equalsIgnoreCase("hll_union")) { |
There was a problem hiding this comment.
I think we need an extensible framework to handle the expression part of the materialized view more elegantly, rather than simply judging a few functions.
This can prepare for more complex expressions later.
There was a problem hiding this comment.
I agree with you. But schema change and expression compute logical is non-universal. so we can only support few function now.
| } else { | ||
| throw new DdlException("The define expr of column is only support bitmap_union or hll_union"); | ||
| } | ||
| newMVColumn.setIsKey(false); |
There was a problem hiding this comment.
The isKey has been set.
There was a problem hiding this comment.
If the aggregate function is computed for the original column, it should be not key whether the original column is a key column or a value column
fe/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
Outdated
Show resolved
Hide resolved
fe/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
Outdated
Show resolved
Hide resolved
fe/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
Outdated
Show resolved
Hide resolved
|
The commit msg is too short. |
3 participants
For #3344