Support materialized view load and insert #3677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HangyuanLiu
added
area/materialized-view
imay
reviewed
Jun 5, 2020
HangyuanLiu
changed the title
EmmyMiao87
requested changes
Jun 8, 2020
| } | ||
| // The extension column of the materialized view is added to the expression evaluation of load | ||
| for (Column column : tbl.getFullSchema()) { | ||
| if (column.getDefineExpr() != null) { |
Contributor
There was a problem hiding this comment.
Are you sure that this is correctcolumn(a, tmp_c) set(b=f(c), c=b)？
Contributor
Author
There was a problem hiding this comment.
Are you sure that this is correct
column(a, tmp_c) set(b=f(c), c=b)？
Fix done
EmmyMiao87
requested changes
Jun 8, 2020
Contributor
|
Is it possible to unify the columns of schema change and materialized view into one logical process in insert stmt? |
EmmyMiao87
reviewed
Jun 8, 2020
EmmyMiao87
requested changes
Jun 15, 2020
| * we should add them to the end of targetColumns. | ||
| * eg: origin targetColumns: (A,B,C), shadow column: __doris_materialized_view_bitmap_union_C | ||
| * after processing, targetColumns: (A, B, C, __doris_materialized_view_bitmap_union_C), and | ||
| * origColIdx2MVColumn has 1 element: "3, __doris_materialized_view_bitmap_union_C" |
Contributor
There was a problem hiding this comment.
Suggested change
| * origColIdx2MVColumn has 1 element: "3, __doris_materialized_view_bitmap_union_C" | |
| * origColIdx2MVColumn has 1 element: "2, __doris_materialized_view_bitmap_union_C" |
| String origName = ((SlotRef) slots.get(0)).getColumnName(); | ||
| SlotRef refColumn = column.getRefColumn(); | ||
| if (refColumn == null) { | ||
| ErrorReport.reportAnalysisException(ErrorCode.ERR_BAD_FIELD_ERROR); |
Contributor
There was a problem hiding this comment.
Better to show which field is error.
| queryStmt.getResultExprs().add(Expr.substituteList(Lists.newArrayList(expr), smap, analyzer, false).get(0)); | ||
| Expr e = Expr.substituteList(Lists.newArrayList(mvColumn.getDefineExpr()), smap, analyzer, false).get(0); | ||
| queryStmt.getResultExprs().add(e); | ||
| queryStmt.getBaseTblResultExprs().add(e); |
Contributor
There was a problem hiding this comment.
What's different between resultExpr and baseTblResultExpr
EmmyMiao87
reviewed
Jul 16, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit mainly supports load bitmap_union, hll_union, and count materialized views.
The main changes are as follows:
1、insert stmt support load extend column
2、load stmt support load extend column
Issue : #3344