Fix large string val allocation failure #3724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large bitmap will need use StringVal to allocate large memory, which is large than MAX_INT. The overflow will cause serialization failure of bitmap. Fixed apache#3600 Change-Id: I720b9ea4646188a8e1402630601928b5f16fedb2
EmmyMiao87
added
area/udf
morningman
reviewed
May 30, 2020
be/src/exprs/bitmap_function.cpp
Outdated
|
|
||
| std::vector<uint64_t> bits; | ||
| if (!SplitStringAndParse({(const char*)input.ptr, input.len}, ",", &safe_strtou64, &bits)) { | ||
| // TODO(hkp): I think StringPiece's len should also be uint64_t |
Contributor
There was a problem hiding this comment.
Could you explain why not changing this to int64? You can just add comment here
Change-Id: Ie84b2071ee063e174bf019ebf0a95d3c02dc16fb
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Jun 4, 2020
* Fix large string val allocation failure Large bitmap will need use StringVal to allocate large memory, which is large than MAX_INT. The overflow will cause serialization failure of bitmap. Fixed apache#3600
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large bitmap will need use StringVal to allocate large memory, which is large than MAX_INT.
The overflow will cause serialization failure of bitmap.
Fixed #3600
Change-Id: I720b9ea4646188a8e1402630601928b5f16fedb2