[Feat](nereids) add pull up literal when infer predicates #37314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 40341 ms |
TPC-DS: Total hot run time: 172571 ms |
ClickBench: Total hot run time: 30.93 s |
morrySnow
previously approved these changes
Jul 5, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
feiniaofeiafei
force-pushed
the
fix_pull_up_predicate
branch
from
5c5d44f
to
7441edc
Compare
|
run buildall |
github-actions
bot
removed
the
approved
feiniaofeiafei
force-pushed
the
fix_pull_up_predicate
branch
from
7441edc
to
017f777
Compare
|
run buildall |
TPC-H: Total hot run time: 40407 ms |
TPC-DS: Total hot run time: 174090 ms |
ClickBench: Total hot run time: 30.58 s |
|
run buildall |
TPC-H: Total hot run time: 40272 ms |
TPC-DS: Total hot run time: 176320 ms |
ClickBench: Total hot run time: 30.1 s |
feiniaofeiafei
force-pushed
the
fix_pull_up_predicate
branch
from
017f777
to
2a22f94
Compare
|
run buildall |
TPC-H: Total hot run time: 39999 ms |
TPC-DS: Total hot run time: 172823 ms |
ClickBench: Total hot run time: 31.47 s |
feiniaofeiafei
force-pushed
the
fix_pull_up_predicate
branch
from
573f05b
to
7ba966a
Compare
|
run buildall |
TPC-H: Total hot run time: 39909 ms |
TPC-DS: Total hot run time: 173003 ms |
ClickBench: Total hot run time: 31.71 s |
|
run buildall |
TPC-H: Total hot run time: 39666 ms |
TPC-DS: Total hot run time: 173925 ms |
ClickBench: Total hot run time: 30.74 s |
|
run external |
924060929
approved these changes
Jul 17, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
morrySnow
approved these changes
Jul 17, 2024
| ----hashJoin[INNER_JOIN] hashCondition=((col1 = ds.col1) and (col2 = ds.col2)) otherCondition=() | ||
| ------PhysicalProject | ||
| --------PhysicalOneRowRelation | ||
| ------filter((ds.col1 = 'abc') and (ds.col1 = ds.col1) and (ds.col2 = 'def') and (ds.col2 = ds.col2)) |
There was a problem hiding this comment.
ds.col1 = ds.col1 is another bug in infer fiter?
dataroaring
pushed a commit
that referenced
this pull request
Jul 19, 2024
This pr add pull up literal when infer predicates, we can infer
tmp.col1='abc' and tmp.col2 = 'def' from subquery tmp, pull up to inner
join, and combined with join on condition, we can infer ds.col1='abc'
and ds.col2='def'
select
*
from
(
select
tmp.col1,
tmp.col2
from
(
select
'abc' as col1,
'def' as col2
from
test_pull_up_predicate_literal
) tmp
inner join test_pull_up_predicate_literal ds
on tmp.col1 = ds.col1 and tmp.col2 = ds.col2
) t
where col1 = 'abc' and col2 = 'def';
---------
Co-authored-by: feiniaofeiafei <moailing@selectdb.com>
feiniaofeiafei
added a commit
to feiniaofeiafei/doris
that referenced
this pull request
Jul 19, 2024
This pr add pull up literal when infer predicates, we can infer
tmp.col1='abc' and tmp.col2 = 'def' from subquery tmp, pull up to inner
join, and combined with join on condition, we can infer ds.col1='abc'
and ds.col2='def'
select
*
from
(
select
tmp.col1,
tmp.col2
from
(
select
'abc' as col1,
'def' as col2
from
test_pull_up_predicate_literal
) tmp
inner join test_pull_up_predicate_literal ds
on tmp.col1 = ds.col1 and tmp.col2 = ds.col2
) t
where col1 = 'abc' and col2 = 'def';
---------
Co-authored-by: feiniaofeiafei <moailing@selectdb.com>
feiniaofeiafei
added a commit
to feiniaofeiafei/doris
that referenced
this pull request
Jul 25, 2024
morrySnow
pushed a commit
that referenced
this pull request
Jul 30, 2024
morrySnow
added
dev/2.1.6-merged
and removed
need more test
dataroaring
added
dev/3.0.1-merged
dev/2.1.6-merged
and removed
dev/2.1.6-merged
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr add pull up literal when infer predicates, we can infer tmp.col1='abc' and tmp.col2 = 'def' from subquery tmp, pull up to inner join, and combined with join on condition, we can infer ds.col1='abc' and ds.col2='def'