[Doris On ES][Bug-Fix] Incorrect result for docvalue scan mode #3751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ake usage of total
wuyunfeng
changed the title
Contributor
|
lgtm |
wuyunfeng
changed the title
wuyunfeng
changed the title
imay
added
approved
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Jun 7, 2020
…ake usage of total (apache#3751) The other PR : apache#3513 (apache#3479) try to resolved the `inner hits node is not an array` because when a query( batch-size) run against new segment without this field, as-well the filter_path just only take `hits.hits.fields` 、`hits.hits._source` into account, this would appear an null inner hits node: ``` { "_scroll_id": "DXF1ZXJ5QW5kRmV0Y2gBAAAAAAAAHaUWY1ExUVd0ZWlRY2", "hits": { "total": 1 } } ``` Unfortunately this PR introduce another serious inconsistent result with different batch_size because of misusing the `total`. To avoid this two problem, we just add `hits.hits._score` to filter_path when `docvalue_mode` is true, `_score` would always `null` , and populate the inner hits node: ``` { "_scroll_id": "DXF1ZXJ5QW5kRmV0Y2gBAAAAAAAAHaUWY1ExUVd0ZWlRY2", "hits": { "total": 1, "hits": [ { "_score": null } ] } } ``` related issue: apache#3752
wuyunfeng
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other PR : #3513 (#3479) try to resolved the
inner hits node is not an arraybecause when a query( batch-size) run against new segment without this field, as-well the filter_path just only takehits.hits.fields、hits.hits._sourceinto account, this would appear an null inner hits node:Unfortunately this PR introduce another serious inconsistent result with different batch_size because of misusing the
total.To avoid this two problem, we just add
hits.hits._scoreto filter_path whendocvalue_modeis true,_scorewould alwaysnull, and populate the inner hits node:related issue: #3752