[fix](hive) Make doris read hive text table parameters and behavior consistent with hive #37638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 39798 ms |
TPC-DS: Total hot run time: 175888 ms |
ClickBench: Total hot run time: 31.11 s |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
Jul 12, 2024
This was referenced Jul 12, 2024
suxiaogang223
added a commit
to suxiaogang223/doris
that referenced
this pull request
Jul 15, 2024
…onsistent with hive (apache#37638) ## Proposed changes When hive reads the text table, it will first try to parse "field.delim" into Byte type. If it fails, it will take the first character as Byte. If "field.delim" is not set, use the same method to parse "serialization.format". ```java separatorCandidates.add(LazyUtils.getByte(tableProperties.getProperty(serdeConstants.FIELD_DELIM, tableProperties.getProperty(serdeConstants.SERIALIZATION_FORMAT)), DefaultSeparators[0])); ... public static byte getByte(String altValue, byte defaultVal) { if (altValue != null && altValue.length() > 0) { try { return Byte.parseByte(altValue); } catch (NumberFormatException e) { return (byte) altValue.charAt(0); } } return defaultVal; } ```
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jul 17, 2024
…onsistent with hive (apache#37638) ## Proposed changes When hive reads the text table, it will first try to parse "field.delim" into Byte type. If it fails, it will take the first character as Byte. If "field.delim" is not set, use the same method to parse "serialization.format". ```java separatorCandidates.add(LazyUtils.getByte(tableProperties.getProperty(serdeConstants.FIELD_DELIM, tableProperties.getProperty(serdeConstants.SERIALIZATION_FORMAT)), DefaultSeparators[0])); ... public static byte getByte(String altValue, byte defaultVal) { if (altValue != null && altValue.length() > 0) { try { return Byte.parseByte(altValue); } catch (NumberFormatException e) { return (byte) altValue.charAt(0); } } return defaultVal; } ```
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
…onsistent with hive (#37638) ## Proposed changes When hive reads the text table, it will first try to parse "field.delim" into Byte type. If it fails, it will take the first character as Byte. If "field.delim" is not set, use the same method to parse "serialization.format". ```java separatorCandidates.add(LazyUtils.getByte(tableProperties.getProperty(serdeConstants.FIELD_DELIM, tableProperties.getProperty(serdeConstants.SERIALIZATION_FORMAT)), DefaultSeparators[0])); ... public static byte getByte(String altValue, byte defaultVal) { if (altValue != null && altValue.length() > 0) { try { return Byte.parseByte(altValue); } catch (NumberFormatException e) { return (byte) altValue.charAt(0); } } return defaultVal; } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When hive reads the text table, it will first try to parse "field.delim" into Byte type. If it fails, it will take the first character as Byte. If "field.delim" is not set, use the same method to parse "serialization.format".