Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](function) the bucket number arg of width_bucket should be a positive integer value #37892

Merged
merged 1 commit into from
Jul 18, 2024
Merged

[fix](function) the bucket number arg of width_bucket should be a positive integer value #37892

merged 1 commit into from
Jul 18, 2024

Conversation

mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Jul 16, 2024

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@mrhhsg
Copy link
Member Author

mrhhsg commented Jul 16, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39995 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9349284e1f6dc60e97953a132ea0576afc5f1b0c, data reload: false

------ Round 1 ----------------------------------
q1	18143	4438	4339	4339
q2	2798	209	188	188
q3	11144	1230	1115	1115
q4	10731	772	820	772
q5	8197	2767	2701	2701
q6	229	134	137	134
q7	973	596	616	596
q8	9223	2051	2072	2051
q9	8779	6589	6560	6560
q10	8824	3770	3793	3770
q11	452	236	239	236
q12	396	214	217	214
q13	18776	2971	2996	2971
q14	278	237	248	237
q15	524	477	496	477
q16	490	387	383	383
q17	962	748	736	736
q18	8132	7461	7383	7383
q19	6929	1360	1431	1360
q20	699	328	310	310
q21	4927	3182	3339	3182
q22	353	291	280	280
Total cold run time: 121959 ms
Total hot run time: 39995 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4387	4237	4227	4227
q2	368	271	273	271
q3	3007	2788	2761	2761
q4	1872	1683	1630	1630
q5	5290	5294	5265	5265
q6	222	130	127	127
q7	2140	1754	1713	1713
q8	3207	3305	3303	3303
q9	8363	8356	8296	8296
q10	3858	3692	3730	3692
q11	585	498	483	483
q12	754	588	598	588
q13	17491	2979	3001	2979
q14	306	274	285	274
q15	519	473	473	473
q16	474	412	429	412
q17	1773	1474	1490	1474
q18	7688	7542	7423	7423
q19	1700	1534	1643	1534
q20	2012	1775	1771	1771
q21	4814	4789	4660	4660
q22	578	508	500	500
Total cold run time: 71408 ms
Total hot run time: 53856 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173521 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9349284e1f6dc60e97953a132ea0576afc5f1b0c, data reload: false

query1	910	367	368	367
query2	6473	1874	1830	1830
query3	6666	206	224	206
query4	22052	17742	17446	17446
query5	4190	485	466	466
query6	260	169	165	165
query7	4583	285	285	285
query8	246	198	200	198
query9	8588	2481	2466	2466
query10	434	286	272	272
query11	10643	10114	10150	10114
query12	137	84	83	83
query13	1646	371	371	371
query14	10350	7760	7644	7644
query15	225	168	171	168
query16	7824	327	332	327
query17	1782	574	549	549
query18	1976	285	287	285
query19	202	156	154	154
query20	92	82	82	82
query21	211	130	127	127
query22	4571	4190	4182	4182
query23	33898	33184	33296	33184
query24	11077	2828	2875	2828
query25	671	401	396	396
query26	1447	153	151	151
query27	2937	277	274	274
query28	7282	2053	2041	2041
query29	987	637	624	624
query30	276	151	152	151
query31	969	759	763	759
query32	97	55	56	55
query33	786	317	311	311
query34	912	498	490	490
query35	695	602	598	598
query36	1121	936	947	936
query37	151	83	84	83
query38	2856	2794	2787	2787
query39	865	842	846	842
query40	276	124	122	122
query41	47	46	46	46
query42	125	100	103	100
query43	536	473	477	473
query44	1185	745	727	727
query45	194	165	167	165
query46	1109	752	725	725
query47	1847	1794	1792	1792
query48	367	294	308	294
query49	1107	504	405	405
query50	786	396	394	394
query51	7029	6796	6717	6717
query52	104	92	95	92
query53	357	283	288	283
query54	1064	442	450	442
query55	75	75	76	75
query56	277	272	271	271
query57	1162	1045	1085	1045
query58	275	234	255	234
query59	2861	2662	2525	2525
query60	296	270	276	270
query61	94	91	101	91
query62	856	655	675	655
query63	319	288	289	288
query64	10634	2206	1670	1670
query65	3209	3146	3101	3101
query66	1351	353	353	353
query67	15805	15022	15122	15022
query68	5380	545	537	537
query69	679	430	343	343
query70	1160	1108	1086	1086
query71	464	283	276	276
query72	8183	5303	5153	5153
query73	782	333	322	322
query74	6157	5675	5668	5668
query75	4282	2715	2692	2692
query76	3859	913	963	913
query77	697	301	291	291
query78	12732	9642	9169	9169
query79	8127	526	526	526
query80	981	485	479	479
query81	577	221	220	220
query82	494	141	132	132
query83	340	171	169	169
query84	271	85	91	85
query85	706	310	341	310
query86	483	306	317	306
query87	3373	3184	3171	3171
query88	4791	2507	2503	2503
query89	488	389	373	373
query90	1857	191	196	191
query91	127	100	103	100
query92	68	51	50	50
query93	3246	497	495	495
query94	1123	221	219	219
query95	414	322	317	317
query96	607	294	279	279
query97	3239	3016	3034	3016
query98	225	197	191	191
query99	1541	1281	1265	1265
Total cold run time: 291888 ms
Total hot run time: 173521 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.36 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9349284e1f6dc60e97953a132ea0576afc5f1b0c, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.06	0.05
query4	1.68	0.08	0.08
query5	0.51	0.50	0.48
query6	1.14	0.73	0.73
query7	0.01	0.01	0.01
query8	0.05	0.05	0.04
query9	0.54	0.49	0.50
query10	0.56	0.55	0.55
query11	0.14	0.11	0.12
query12	0.15	0.12	0.13
query13	0.59	0.59	0.58
query14	0.75	0.78	0.77
query15	0.86	0.81	0.80
query16	0.37	0.37	0.36
query17	0.96	1.03	1.02
query18	0.22	0.22	0.21
query19	1.86	1.78	1.73
query20	0.01	0.01	0.01
query21	15.40	0.77	0.67
query22	4.68	7.77	1.46
query23	18.27	1.35	1.32
query24	2.17	0.22	0.22
query25	0.16	0.09	0.08
query26	0.30	0.22	0.21
query27	0.46	0.24	0.22
query28	13.26	1.02	1.02
query29	12.97	3.33	3.29
query30	0.26	0.06	0.06
query31	2.86	0.38	0.37
query32	3.28	0.48	0.47
query33	2.96	2.93	2.93
query34	17.10	4.42	4.37
query35	4.39	4.41	4.47
query36	0.64	0.48	0.47
query37	0.18	0.16	0.15
query38	0.15	0.14	0.15
query39	0.04	0.04	0.03
query40	0.16	0.12	0.13
query41	0.10	0.04	0.05
query42	0.05	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.64 s
Total hot run time: 30.36 s

@mrhhsg
Copy link
Member Author

mrhhsg commented Jul 17, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40040 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9349284e1f6dc60e97953a132ea0576afc5f1b0c, data reload: false

------ Round 1 ----------------------------------
q1	18118	4452	4358	4358
q2	2483	196	201	196
q3	12034	1202	1127	1127
q4	11175	737	779	737
q5	7597	2773	2732	2732
q6	222	144	144	144
q7	975	600	598	598
q8	9213	2101	2068	2068
q9	8846	6525	6560	6525
q10	8683	3803	3860	3803
q11	481	246	240	240
q12	384	235	231	231
q13	17770	3008	3020	3008
q14	289	229	234	229
q15	528	481	478	478
q16	483	379	381	379
q17	965	687	766	687
q18	8075	7583	7403	7403
q19	5875	1390	1288	1288
q20	684	317	327	317
q21	4933	3206	3211	3206
q22	358	288	286	286
Total cold run time: 120171 ms
Total hot run time: 40040 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4368	4327	4232	4232
q2	367	260	267	260
q3	2959	2778	2746	2746
q4	1884	1635	1592	1592
q5	5312	5322	5323	5322
q6	220	133	132	132
q7	2106	1740	1728	1728
q8	3196	3354	3305	3305
q9	8395	8360	8358	8358
q10	3927	3599	3756	3599
q11	596	497	491	491
q12	769	584	619	584
q13	17544	2999	2992	2992
q14	293	268	273	268
q15	507	475	475	475
q16	480	419	430	419
q17	1779	1478	1471	1471
q18	7709	7499	7581	7499
q19	1710	1571	1633	1571
q20	2008	1792	1795	1792
q21	7307	4756	4629	4629
q22	567	511	505	505
Total cold run time: 74003 ms
Total hot run time: 53970 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173540 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9349284e1f6dc60e97953a132ea0576afc5f1b0c, data reload: false

query1	914	367	359	359
query2	6462	1941	1856	1856
query3	6668	210	213	210
query4	27793	17601	17514	17514
query5	4248	496	486	486
query6	264	169	161	161
query7	4587	297	288	288
query8	252	198	182	182
query9	8468	2390	2382	2382
query10	441	293	273	273
query11	10556	10108	10077	10077
query12	139	83	82	82
query13	1650	369	368	368
query14	10250	7658	7626	7626
query15	214	167	165	165
query16	7410	337	310	310
query17	1792	555	526	526
query18	1730	280	270	270
query19	199	148	150	148
query20	89	85	80	80
query21	203	128	125	125
query22	4488	4189	4152	4152
query23	33770	33204	33228	33204
query24	11828	2927	2887	2887
query25	665	363	373	363
query26	1793	155	148	148
query27	2770	266	269	266
query28	7353	2002	1985	1985
query29	1023	608	598	598
query30	289	147	148	147
query31	948	763	746	746
query32	98	51	53	51
query33	772	306	298	298
query34	934	491	499	491
query35	665	593	579	579
query36	1090	967	931	931
query37	159	81	80	80
query38	2862	2730	2764	2730
query39	862	813	829	813
query40	272	122	118	118
query41	51	47	44	44
query42	118	97	99	97
query43	505	484	460	460
query44	1208	734	721	721
query45	199	159	163	159
query46	1104	752	726	726
query47	1870	1750	1784	1750
query48	358	297	287	287
query49	1194	408	402	402
query50	777	391	401	391
query51	6947	6851	6712	6712
query52	107	92	92	92
query53	365	297	284	284
query54	1010	454	443	443
query55	76	75	74	74
query56	287	286	284	284
query57	1141	1050	1060	1050
query58	248	241	259	241
query59	2926	2837	2854	2837
query60	305	275	274	274
query61	97	91	93	91
query62	845	631	641	631
query63	325	294	288	288
query64	10528	2234	1701	1701
query65	3180	3129	3111	3111
query66	1387	338	370	338
query67	15275	14963	14947	14947
query68	4590	544	538	538
query69	476	332	325	325
query70	1177	1159	1137	1137
query71	404	289	271	271
query72	6788	5676	5696	5676
query73	738	329	324	324
query74	6051	5647	5640	5640
query75	3520	2656	2723	2656
query76	2791	932	943	932
query77	459	304	310	304
query78	9810	9853	9023	9023
query79	2144	529	523	523
query80	1884	493	467	467
query81	572	219	227	219
query82	642	132	134	132
query83	282	164	168	164
query84	281	90	90	90
query85	2013	310	296	296
query86	501	337	321	321
query87	3248	3156	3132	3132
query88	3842	2381	2382	2381
query89	460	380	383	380
query90	1838	199	198	198
query91	132	103	99	99
query92	61	53	50	50
query93	1980	509	502	502
query94	1242	207	209	207
query95	406	312	314	312
query96	602	269	269	269
query97	3248	3038	3011	3011
query98	214	211	203	203
query99	1604	1248	1299	1248
Total cold run time: 283403 ms
Total hot run time: 173540 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.73 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9349284e1f6dc60e97953a132ea0576afc5f1b0c, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.23	0.06	0.06
query4	1.67	0.08	0.07
query5	0.50	0.50	0.50
query6	1.14	0.73	0.72
query7	0.02	0.02	0.01
query8	0.06	0.04	0.04
query9	0.55	0.48	0.50
query10	0.56	0.55	0.56
query11	0.14	0.11	0.12
query12	0.15	0.12	0.12
query13	0.59	0.58	0.59
query14	0.76	0.78	0.77
query15	0.86	0.84	0.83
query16	0.36	0.36	0.36
query17	1.04	1.03	0.98
query18	0.22	0.22	0.22
query19	1.81	1.68	1.76
query20	0.01	0.01	0.01
query21	15.39	0.76	0.66
query22	3.90	7.81	1.99
query23	18.30	1.34	1.30
query24	2.09	0.22	0.25
query25	0.15	0.08	0.08
query26	0.30	0.21	0.20
query27	0.45	0.23	0.23
query28	13.27	1.00	0.98
query29	12.65	3.29	3.31
query30	0.25	0.06	0.06
query31	2.88	0.40	0.39
query32	3.25	0.47	0.46
query33	2.94	2.87	2.92
query34	17.02	4.34	4.33
query35	4.40	4.53	4.44
query36	0.64	0.49	0.48
query37	0.18	0.16	0.16
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.14	0.12	0.12
query41	0.09	0.04	0.05
query42	0.05	0.05	0.04
query43	0.04	0.04	0.05
Total cold run time: 109.38 s
Total hot run time: 30.73 s

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

zhiqiang-hhhh
zhiqiang-hhhh reviewed Jul 17, 2024
View reviewed changes
be/src/vec/functions/function_width_bucket.cpp Outdated
@@ -86,12 +92,12 @@ class FunctionWidthBucket : public IFunction {
void _execute(const IColumn& expr_column, const IColumn& min_value_column,
const IColumn& max_value_column, const int64_t num_buckets,
IColumn& nested_column) const {
const ColumnType& expr_column_concrete = reinterpret_cast<const ColumnType&>(expr_column);
const ColumnType& min_value_column_concrete =
const auto& expr_column_concrete = reinterpret_cast<const ColumnType&>(expr_column);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not using assert_cast?

@mrhhsg
Copy link
Member Author

mrhhsg commented Jul 17, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39945 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 378217dbd3cec21ef9a538b24ec9c7c6fdce1d99, data reload: false

------ Round 1 ----------------------------------
q1	17625	4477	4328	4328
q2	2026	197	185	185
q3	10456	1173	1105	1105
q4	10195	776	758	758
q5	7673	2752	2666	2666
q6	229	153	143	143
q7	981	615	637	615
q8	9339	2104	2105	2104
q9	8720	6553	6626	6553
q10	8770	3750	3741	3741
q11	462	252	245	245
q12	397	242	236	236
q13	18816	2978	2992	2978
q14	273	235	242	235
q15	532	495	491	491
q16	508	383	378	378
q17	966	681	688	681
q18	8083	7561	7436	7436
q19	9013	1385	1339	1339
q20	701	317	323	317
q21	5031	3128	3201	3128
q22	337	283	290	283
Total cold run time: 121133 ms
Total hot run time: 39945 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4475	4320	4309	4309
q2	360	269	265	265
q3	3043	2707	2762	2707
q4	1903	1573	1603	1573
q5	5305	5342	5302	5302
q6	220	128	130	128
q7	2055	1659	1701	1659
q8	3201	3339	3305	3305
q9	8450	8388	8374	8374
q10	3889	3669	3737	3669
q11	593	493	477	477
q12	784	614	590	590
q13	16306	2991	2983	2983
q14	304	271	270	270
q15	519	465	481	465
q16	465	410	412	410
q17	1771	1501	1486	1486
q18	7543	7378	7380	7378
q19	1667	1533	1453	1453
q20	1985	1789	1794	1789
q21	4771	4784	4716	4716
q22	558	497	519	497
Total cold run time: 70167 ms
Total hot run time: 53805 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172117 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 378217dbd3cec21ef9a538b24ec9c7c6fdce1d99, data reload: false

query1	918	367	374	367
query2	6470	1807	1816	1807
query3	6658	206	216	206
query4	25605	17436	17411	17411
query5	4266	483	501	483
query6	272	156	188	156
query7	4589	293	281	281
query8	248	199	192	192
query9	8561	2458	2465	2458
query10	445	284	271	271
query11	12960	10028	10095	10028
query12	130	84	82	82
query13	1641	386	360	360
query14	10011	7576	7848	7576
query15	236	163	163	163
query16	7216	299	304	299
query17	1836	530	529	529
query18	1847	271	272	271
query19	208	149	155	149
query20	97	84	80	80
query21	199	129	124	124
query22	4422	4028	3941	3941
query23	33707	33058	33088	33058
query24	11955	2856	2925	2856
query25	641	368	366	366
query26	1789	170	148	148
query27	2642	266	271	266
query28	7412	2002	1998	1998
query29	1035	634	622	622
query30	292	149	146	146
query31	965	742	731	731
query32	92	51	55	51
query33	773	299	292	292
query34	953	474	486	474
query35	680	572	565	565
query36	1096	948	918	918
query37	145	77	85	77
query38	2905	2736	2720	2720
query39	853	836	795	795
query40	273	121	119	119
query41	47	46	45	45
query42	123	97	102	97
query43	487	476	442	442
query44	1253	738	728	728
query45	188	162	160	160
query46	1088	751	708	708
query47	1866	1785	1802	1785
query48	380	301	290	290
query49	1216	421	453	421
query50	777	393	396	393
query51	6872	6750	6820	6750
query52	113	87	92	87
query53	352	284	286	284
query54	1082	433	436	433
query55	74	73	74	73
query56	286	257	264	257
query57	1176	1027	1018	1018
query58	274	243	259	243
query59	2820	2693	2680	2680
query60	296	274	272	272
query61	100	93	95	93
query62	835	638	637	637
query63	325	288	295	288
query64	10643	2200	1664	1664
query65	3175	3090	3126	3090
query66	1387	333	339	333
query67	15565	14978	14872	14872
query68	4530	525	533	525
query69	474	330	321	321
query70	1153	1120	1040	1040
query71	395	271	278	271
query72	7478	5615	5497	5497
query73	741	320	317	317
query74	6122	5671	5703	5671
query75	3443	2681	2657	2657
query76	2721	963	913	913
query77	463	306	364	306
query78	12120	9520	9025	9025
query79	2884	517	516	516
query80	1210	476	465	465
query81	572	218	227	218
query82	579	131	138	131
query83	295	164	169	164
query84	269	84	83	83
query85	712	303	287	287
query86	500	291	307	291
query87	3368	3079	3065	3065
query88	3987	2367	2364	2364
query89	487	386	374	374
query90	1952	186	187	186
query91	127	98	97	97
query92	67	50	48	48
query93	3795	506	495	495
query94	1227	212	206	206
query95	396	372	307	307
query96	611	277	269	269
query97	3180	3032	2998	2998
query98	219	198	185	185
query99	1684	1294	1246	1246
Total cold run time: 287604 ms
Total hot run time: 172117 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.89 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 378217dbd3cec21ef9a538b24ec9c7c6fdce1d99, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.06
query4	1.68	0.11	0.10
query5	0.48	0.48	0.48
query6	1.13	0.73	0.73
query7	0.02	0.01	0.02
query8	0.04	0.04	0.04
query9	0.55	0.50	0.50
query10	0.54	0.54	0.53
query11	0.15	0.12	0.11
query12	0.15	0.12	0.12
query13	0.59	0.58	0.58
query14	0.77	0.76	0.78
query15	0.86	0.81	0.81
query16	0.37	0.35	0.38
query17	1.01	0.99	1.01
query18	0.23	0.22	0.21
query19	1.82	1.70	1.73
query20	0.01	0.01	0.01
query21	15.38	0.74	0.66
query22	4.50	6.67	2.31
query23	18.31	1.43	1.18
query24	2.10	0.23	0.23
query25	0.14	0.09	0.09
query26	0.31	0.20	0.21
query27	0.45	0.23	0.22
query28	13.30	1.02	1.00
query29	12.58	3.30	3.32
query30	0.25	0.06	0.06
query31	2.87	0.39	0.38
query32	3.27	0.47	0.47
query33	2.90	2.87	2.93
query34	17.11	4.34	4.38
query35	4.47	4.39	4.41
query36	0.66	0.46	0.48
query37	0.20	0.16	0.16
query38	0.16	0.15	0.15
query39	0.04	0.03	0.04
query40	0.15	0.11	0.12
query41	0.10	0.04	0.05
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 110.1 s
Total hot run time: 30.89 s

@mrhhsg
Copy link
Member Author

mrhhsg commented Jul 18, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39555 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 378217dbd3cec21ef9a538b24ec9c7c6fdce1d99, data reload: false

------ Round 1 ----------------------------------
q1	17624	4313	4267	4267
q2	2023	192	188	188
q3	10447	1240	1124	1124
q4	10182	807	766	766
q5	7606	2678	2647	2647
q6	224	134	137	134
q7	945	597	606	597
q8	9203	2055	2030	2030
q9	8744	6541	6513	6513
q10	8893	3762	3784	3762
q11	459	262	244	244
q12	458	225	222	222
q13	17768	3018	3031	3018
q14	277	230	239	230
q15	533	489	483	483
q16	500	374	368	368
q17	948	695	726	695
q18	7930	7384	7305	7305
q19	7149	1269	1322	1269
q20	661	314	328	314
q21	4900	3101	3271	3101
q22	341	278	287	278
Total cold run time: 117815 ms
Total hot run time: 39555 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4368	4418	4227	4227
q2	359	262	266	262
q3	3007	2837	2879	2837
q4	1980	1660	1677	1660
q5	5726	5508	5470	5470
q6	231	138	136	136
q7	2179	1881	1858	1858
q8	3257	3445	3414	3414
q9	8766	8747	8918	8747
q10	4055	3904	3777	3777
q11	627	499	487	487
q12	835	680	620	620
q13	16052	3207	3133	3133
q14	312	299	291	291
q15	531	477	487	477
q16	481	442	434	434
q17	1784	1529	1483	1483
q18	8197	8033	7878	7878
q19	1719	1608	1536	1536
q20	2308	1862	1839	1839
q21	6505	4848	4746	4746
q22	725	525	504	504
Total cold run time: 74004 ms
Total hot run time: 55816 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174597 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 378217dbd3cec21ef9a538b24ec9c7c6fdce1d99, data reload: false

query1	916	366	362	362
query2	6450	1962	1852	1852
query3	6657	204	222	204
query4	28117	17542	17367	17367
query5	3632	477	471	471
query6	258	189	159	159
query7	4581	292	285	285
query8	238	188	188	188
query9	8499	2452	2437	2437
query10	438	278	275	275
query11	10672	10105	10144	10105
query12	119	88	85	85
query13	1650	376	373	373
query14	8556	8577	7726	7726
query15	220	173	165	165
query16	7650	311	310	310
query17	1801	572	553	553
query18	1905	293	284	284
query19	207	159	158	158
query20	96	83	82	82
query21	211	123	124	123
query22	4333	4154	4039	4039
query23	33844	33687	33555	33555
query24	10933	3097	2953	2953
query25	593	379	389	379
query26	715	151	146	146
query27	2251	280	285	280
query28	6172	2106	2060	2060
query29	916	630	644	630
query30	255	156	151	151
query31	953	778	744	744
query32	99	55	58	55
query33	720	288	307	288
query34	906	497	503	497
query35	693	593	597	593
query36	1131	1006	991	991
query37	137	83	83	83
query38	2920	2852	2824	2824
query39	941	846	837	837
query40	195	120	118	118
query41	46	44	42	42
query42	115	97	99	97
query43	529	476	454	454
query44	1151	731	738	731
query45	198	162	159	159
query46	1076	781	729	729
query47	1849	1789	1740	1740
query48	372	300	298	298
query49	830	405	432	405
query50	777	391	393	391
query51	6822	6795	6970	6795
query52	110	95	90	90
query53	363	287	281	281
query54	864	443	447	443
query55	78	76	75	75
query56	289	262	270	262
query57	1138	1065	1092	1065
query58	266	247	252	247
query59	2937	2630	2628	2628
query60	309	276	275	275
query61	92	92	90	90
query62	781	643	650	643
query63	320	289	282	282
query64	9091	2194	7441	2194
query65	3165	3090	3125	3090
query66	741	328	335	328
query67	15554	15091	15069	15069
query68	4557	535	536	535
query69	666	452	334	334
query70	1114	1135	1136	1135
query71	431	308	284	284
query72	7802	5880	5608	5608
query73	758	322	316	316
query74	6058	5718	5594	5594
query75	3501	2710	2688	2688
query76	3222	939	915	915
query77	639	295	300	295
query78	9735	9056	10755	9056
query79	5657	528	530	528
query80	1130	477	462	462
query81	587	227	219	219
query82	454	141	138	138
query83	203	169	171	169
query84	275	88	86	86
query85	1316	304	291	291
query86	406	283	303	283
query87	3305	3090	3132	3090
query88	4235	2385	2373	2373
query89	500	400	391	391
query90	1870	198	187	187
query91	130	98	103	98
query92	60	48	51	48
query93	1838	503	501	501
query94	1111	213	216	213
query95	403	310	316	310
query96	596	278	269	269
query97	3190	3049	3039	3039
query98	207	203	209	203
query99	1577	1249	1275	1249
Total cold run time: 278976 ms
Total hot run time: 174597 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.56 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 378217dbd3cec21ef9a538b24ec9c7c6fdce1d99, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.06	0.07
query5	0.50	0.50	0.48
query6	1.13	0.73	0.73
query7	0.02	0.02	0.02
query8	0.05	0.04	0.04
query9	0.54	0.50	0.48
query10	0.56	0.54	0.54
query11	0.17	0.11	0.12
query12	0.15	0.12	0.12
query13	0.60	0.58	0.58
query14	0.75	0.78	0.79
query15	0.87	0.83	0.83
query16	0.38	0.37	0.35
query17	0.98	1.04	0.98
query18	0.25	0.21	0.21
query19	1.88	1.84	1.78
query20	0.02	0.01	0.01
query21	15.42	0.76	0.66
query22	3.71	8.09	1.83
query23	18.29	1.41	1.23
query24	2.11	0.24	0.23
query25	0.15	0.08	0.08
query26	0.30	0.21	0.21
query27	0.45	0.23	0.24
query28	13.20	1.03	1.00
query29	12.64	3.30	3.27
query30	0.25	0.06	0.05
query31	2.86	0.40	0.38
query32	3.28	0.48	0.47
query33	2.91	2.91	2.92
query34	17.04	4.40	4.37
query35	4.43	4.43	4.39
query36	0.65	0.47	0.49
query37	0.18	0.16	0.15
query38	0.16	0.15	0.15
query39	0.04	0.04	0.04
query40	0.16	0.13	0.11
query41	0.08	0.05	0.04
query42	0.06	0.05	0.04
query43	0.05	0.03	0.04
Total cold run time: 109.3 s
Total hot run time: 30.56 s

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 18, 2024
@yiguolei yiguolei merged commit b69b708 into apache:master Jul 18, 2024
25 of 27 checks passed
dataroaring pushed a commit that referenced this pull request Jul 19, 2024
@mrhhsg @dataroaring
[fix](function) the bucket number arg of width_bucket should be a pos…
8e13d1a 
…itive integer value (#37892)

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
@mrhhsg mrhhsg deleted the fix_width_bucket branch July 24, 2024 07:20
mrhhsg added a commit to mrhhsg/doris that referenced this pull request Jul 24, 2024
@mrhhsg
[fix](function) the bucket number arg of width_bucket should be a pos…
ea86ff0 
…itive integer value (apache#37892)

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
@mrhhsg mrhhsg mentioned this pull request Jul 24, 2024
Merged
yiguolei pushed a commit that referenced this pull request Jul 25, 2024
@mrhhsg
[fix](function) the bucket number arg of width_bucket should be a pos…
d19b3a5 
…itive integer value (#37892) (#38295)

## Proposed changes

pick #37892
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiang-hhhh zhiqiang-hhhh zhiqiang-hhhh left review comments

@yiguolei yiguolei yiguolei approved these changes

@suxiaogang223 suxiaogang223 suxiaogang223 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.1-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mrhhsg @doris-robot @yiguolei @suxiaogang223 @zhiqiang-hhhh @dataroaring