-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](load) change tablet schema pointer to shared_ptr in memtable #37927
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40356 ms
|
TPC-DS: Total hot run time: 172653 ms
|
ClickBench: Total hot run time: 30.48 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6acb956
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39764 ms
|
TPC-DS: Total hot run time: 173967 ms
|
ClickBench: Total hot run time: 30.53 s
|
PR approved by at least one committer and no changes requested. |
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40182 ms
|
TPC-DS: Total hot run time: 174618 ms
|
ClickBench: Total hot run time: 30.82 s
|
…37927) ## Proposed changes Fix potential use-after-free in memtable->_tablet_schema.
Proposed changes
Fix potential use-after-free in memtable->_tablet_schema.