Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](nereids)acos function should return null literal instead of NaN value #37932

Merged
merged 1 commit into from
Jul 17, 2024
Merged

[fix](nereids)acos function should return null literal instead of NaN value #37932

merged 1 commit into from
Jul 17, 2024

Conversation

starocean999
Copy link
Contributor

select acos(cast(1.1 as double)) should return NULL instead of NaN

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@starocean999
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40432 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 49d4681ed7c3286adab83a82c8fa7e0628d154e0, data reload: false

------ Round 1 ----------------------------------
q1	17932	4608	4476	4476
q2	2491	197	189	189
q3	11488	1216	1136	1136
q4	10448	863	788	788
q5	7671	2766	2740	2740
q6	221	141	138	138
q7	970	612	619	612
q8	9627	2079	2104	2079
q9	8898	6587	6633	6587
q10	8758	3842	3773	3773
q11	439	240	237	237
q12	396	219	225	219
q13	18876	2964	2991	2964
q14	287	235	243	235
q15	527	485	480	480
q16	485	385	377	377
q17	981	687	646	646
q18	8155	7474	7493	7474
q19	6224	1475	1430	1430
q20	702	344	332	332
q21	4927	3283	3238	3238
q22	350	289	282	282
Total cold run time: 120853 ms
Total hot run time: 40432 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4378	4397	4258	4258
q2	363	277	261	261
q3	3000	2775	2755	2755
q4	1908	1590	1584	1584
q5	5342	5331	5340	5331
q6	222	128	128	128
q7	2117	1743	1758	1743
q8	3184	3360	3329	3329
q9	8488	8421	8446	8421
q10	3916	3703	3696	3696
q11	592	510	487	487
q12	767	590	635	590
q13	17676	2956	2989	2956
q14	302	272	273	272
q15	516	492	489	489
q16	477	410	426	410
q17	1767	1466	1454	1454
q18	7700	7482	7458	7458
q19	1664	1537	1582	1537
q20	1997	1838	1781	1781
q21	4842	4784	4668	4668
q22	578	502	508	502
Total cold run time: 71796 ms
Total hot run time: 54110 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172437 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 49d4681ed7c3286adab83a82c8fa7e0628d154e0, data reload: false

query1	924	374	369	369
query2	6464	1919	1814	1814
query3	6665	215	216	215
query4	23009	17448	17491	17448
query5	4189	487	492	487
query6	289	175	175	175
query7	4608	292	282	282
query8	236	193	189	189
query9	8510	2391	2375	2375
query10	433	294	272	272
query11	11922	10082	10171	10082
query12	130	84	81	81
query13	1639	379	365	365
query14	10477	7020	7631	7020
query15	227	174	168	168
query16	7816	326	315	315
query17	1809	588	540	540
query18	1897	289	281	281
query19	198	155	158	155
query20	89	87	83	83
query21	206	128	125	125
query22	4440	4092	4006	4006
query23	33857	33095	33074	33074
query24	11951	2932	2912	2912
query25	673	380	401	380
query26	1778	154	148	148
query27	2974	282	278	278
query28	7774	1999	1989	1989
query29	1101	639	635	635
query30	291	155	151	151
query31	984	735	735	735
query32	87	57	56	56
query33	793	307	312	307
query34	957	491	507	491
query35	701	573	571	571
query36	1116	941	932	932
query37	281	79	82	79
query38	2896	2768	2789	2768
query39	873	842	802	802
query40	282	125	121	121
query41	52	48	47	47
query42	120	101	111	101
query43	504	476	454	454
query44	1194	731	722	722
query45	191	167	166	166
query46	1102	713	715	713
query47	1885	1780	1767	1767
query48	372	289	296	289
query49	1209	425	423	423
query50	787	396	392	392
query51	6866	6823	6806	6806
query52	106	92	93	92
query53	363	287	291	287
query54	1004	456	457	456
query55	77	76	75	75
query56	324	289	295	289
query57	1161	1042	1071	1042
query58	272	255	255	255
query59	3028	2653	2694	2653
query60	429	286	291	286
query61	99	107	91	91
query62	856	675	669	669
query63	321	284	281	281
query64	10481	2232	1692	1692
query65	3196	3119	3144	3119
query66	1368	341	338	338
query67	15767	14935	14950	14935
query68	8753	557	557	557
query69	717	484	349	349
query70	1218	1085	1159	1085
query71	549	278	274	274
query72	8946	5373	5343	5343
query73	1500	330	324	324
query74	6314	5700	5815	5700
query75	5445	2650	2663	2650
query76	5207	985	930	930
query77	803	305	296	296
query78	9821	9270	8938	8938
query79	11147	523	529	523
query80	979	489	494	489
query81	581	228	232	228
query82	273	130	133	130
query83	395	168	163	163
query84	276	85	89	85
query85	1118	297	295	295
query86	358	301	319	301
query87	3324	3228	3135	3135
query88	5065	2402	2377	2377
query89	492	386	389	386
query90	2089	199	215	199
query91	129	101	103	101
query92	62	50	48	48
query93	6027	504	503	503
query94	1485	217	210	210
query95	441	322	320	320
query96	606	273	277	273
query97	3213	3067	3115	3067
query98	222	209	192	192
query99	1497	1250	1295	1250
Total cold run time: 307732 ms
Total hot run time: 172437 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.21 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 49d4681ed7c3286adab83a82c8fa7e0628d154e0, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.03	0.04
query3	0.22	0.04	0.05
query4	1.68	0.07	0.06
query5	0.47	0.47	0.49
query6	1.15	0.74	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.55	0.48	0.50
query10	0.55	0.55	0.54
query11	0.15	0.12	0.12
query12	0.15	0.13	0.13
query13	0.59	0.59	0.59
query14	0.76	0.81	0.77
query15	0.85	0.83	0.82
query16	0.37	0.36	0.36
query17	1.03	0.96	0.94
query18	0.23	0.22	0.22
query19	1.84	1.72	1.78
query20	0.01	0.00	0.01
query21	15.40	0.74	0.67
query22	4.60	7.24	1.50
query23	18.30	1.30	1.26
query24	2.13	0.23	0.22
query25	0.14	0.09	0.09
query26	0.29	0.22	0.22
query27	0.45	0.24	0.23
query28	13.27	1.03	1.00
query29	12.62	3.38	3.31
query30	0.25	0.06	0.05
query31	2.86	0.39	0.38
query32	3.30	0.49	0.48
query33	2.88	2.96	2.89
query34	16.97	4.37	4.33
query35	4.46	4.42	4.41
query36	0.65	0.50	0.48
query37	0.19	0.16	0.16
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.15	0.12	0.12
query41	0.09	0.04	0.05
query42	0.05	0.04	0.04
query43	0.05	0.04	0.04
Total cold run time: 110.1 s
Total hot run time: 30.21 s

@starocean999 starocean999 marked this pull request as ready for review July 17, 2024 06:33
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@starocean999 starocean999 mentioned this pull request Jul 17, 2024
Merged
@morrySnow morrySnow merged commit dee9715 into apache:master Jul 17, 2024
28 of 30 checks passed
yiguolei pushed a commit that referenced this pull request Jul 18, 2024
@starocean999
[fix](nereids)acos function should return null literal instead of NaN…
ebc178a 
… value (#37996)

pick from master #37932

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
dataroaring pushed a commit that referenced this pull request Jul 19, 2024
@starocean999 @dataroaring
[fix](nereids) acos function should return null literal instead of Na…
1eb136d 
…N value (#37932)

acos(cast(1.1 as double)) should return NULL instead of NaN
@morrySnow morrySnow added the usercase Important user case type label label Aug 2, 2024
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@924060929 924060929 924060929 approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.1-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@starocean999 @doris-robot @924060929 @morrySnow @yiguolei @dataroaring