Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test](inverted index)Add cases for inverted index format v2 #38132

Merged
merged 1 commit into from
Jul 22, 2024
Merged

[test](inverted index)Add cases for inverted index format v2 #38132

merged 1 commit into from
Jul 22, 2024

Conversation

qidaye
Copy link
Contributor

@qidaye qidaye commented Jul 19, 2024 •
edited
Loading

Proposed changes

  1. Add exception when trying to change index storage format
  2. Add test cases for index format v2
    • test_add_build_index_with_format_v2
    • test_create_table_with_format_v2
    • test_cumulative_compaction_with_format_v2
    • test_drop_column_with_format_v2
    • test_drop_index_with_format_v2
    • test_index_change_format
    • test_mor_table_with_format_v2
    • test_mow_table_with_format_v2
    • test_recover_with_format_v2
    • test_rename_column_with_format_v2
    • test_single_replica_compaction_with_format_v2
  3. There is a test case test_rename_column_with_format_v2 for [fix](inverted index)Support rename column with inverted index #38079

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@qidaye
Copy link
Contributor Author

qidaye commented Jul 19, 2024

run buildall

@qidaye qidaye mentioned this pull request Jul 19, 2024
Merged
@qidaye
Copy link
Contributor Author

qidaye commented Jul 19, 2024

run performance

@qidaye qidaye force-pushed the format_v2_cases branch from c4c99c9 to 68e2d97 Compare July 19, 2024 09:18
@qidaye
Copy link
Contributor Author

qidaye commented Jul 19, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40107 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 68e2d9718486052a5fa616b6347a2a204d23986e, data reload: false

------ Round 1 ----------------------------------
q1	16909	4472	4286	4286
q2	1820	199	189	189
q3	10013	1185	1076	1076
q4	9954	751	791	751
q5	7238	2739	2708	2708
q6	226	142	138	138
q7	973	595	612	595
q8	8846	2084	2102	2084
q9	6766	6615	6636	6615
q10	7876	3828	3806	3806
q11	496	239	237	237
q12	407	232	230	230
q13	16635	2970	2978	2970
q14	281	237	256	237
q15	516	474	498	474
q16	508	376	373	373
q17	978	614	683	614
q18	8206	7581	7438	7438
q19	8088	1485	1447	1447
q20	688	328	331	328
q21	5011	3225	3280	3225
q22	346	286	286	286
Total cold run time: 112781 ms
Total hot run time: 40107 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4432	4238	4253	4238
q2	377	278	268	268
q3	3021	2757	2767	2757
q4	1854	1641	1584	1584
q5	5305	5318	5301	5301
q6	218	133	135	133
q7	2110	1745	1758	1745
q8	3222	3337	3364	3337
q9	8365	8388	8358	8358
q10	3927	3685	3668	3668
q11	595	475	521	475
q12	780	659	610	610
q13	15684	2990	3003	2990
q14	304	279	276	276
q15	522	480	482	480
q16	494	423	408	408
q17	1790	1487	1483	1483
q18	7601	7493	7388	7388
q19	1757	1411	1472	1411
q20	2002	1795	1791	1791
q21	4748	4785	4742	4742
q22	561	515	488	488
Total cold run time: 69669 ms
Total hot run time: 53931 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174004 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 68e2d9718486052a5fa616b6347a2a204d23986e, data reload: false

query1	914	377	368	368
query2	6457	1904	1801	1801
query3	6654	212	223	212
query4	28573	17646	17554	17554
query5	4173	475	471	471
query6	273	174	174	174
query7	4592	288	300	288
query8	239	201	190	190
query9	8557	2373	2348	2348
query10	435	271	261	261
query11	10828	10120	10173	10120
query12	124	85	83	83
query13	1630	366	362	362
query14	9370	7729	7756	7729
query15	220	166	167	166
query16	7123	506	494	494
query17	1567	539	525	525
query18	1533	273	272	272
query19	197	151	146	146
query20	89	80	83	80
query21	207	125	127	125
query22	4364	4226	4036	4036
query23	33948	33149	33147	33147
query24	11179	2902	2929	2902
query25	585	370	378	370
query26	744	146	144	144
query27	2254	267	271	267
query28	6234	1991	1988	1988
query29	862	624	620	620
query30	287	156	148	148
query31	960	734	754	734
query32	128	57	55	55
query33	774	337	332	332
query34	902	473	484	473
query35	871	743	728	728
query36	1103	924	940	924
query37	129	79	76	76
query38	2868	2754	2799	2754
query39	883	797	825	797
query40	201	119	117	117
query41	50	44	44	44
query42	119	99	103	99
query43	492	462	441	441
query44	1223	715	713	713
query45	190	163	169	163
query46	1089	723	736	723
query47	1884	1788	1795	1788
query48	383	284	287	284
query49	1038	410	416	410
query50	811	398	384	384
query51	6833	6824	6812	6812
query52	106	91	95	91
query53	355	290	286	286
query54	964	445	443	443
query55	76	73	71	71
query56	290	276	281	276
query57	1174	1065	1075	1065
query58	260	272	245	245
query59	2979	2533	2507	2507
query60	296	294	273	273
query61	104	100	96	96
query62	842	656	659	656
query63	318	287	295	287
query64	9294	2188	7411	2188
query65	3157	3107	3126	3107
query66	787	354	342	342
query67	15535	15098	14972	14972
query68	4566	541	534	534
query69	457	340	326	326
query70	1183	1165	1145	1145
query71	403	278	280	278
query72	7187	5456	5811	5456
query73	751	328	334	328
query74	6189	5770	5740	5740
query75	3446	2665	2706	2665
query76	2846	1059	885	885
query77	508	314	307	307
query78	9676	9225	8949	8949
query79	2539	517	516	516
query80	2203	465	490	465
query81	586	227	218	218
query82	1439	144	142	142
query83	290	172	166	166
query84	261	96	88	88
query85	1478	326	309	309
query86	478	322	322	322
query87	3318	3131	3180	3131
query88	3984	2382	2340	2340
query89	478	376	382	376
query90	1851	194	190	190
query91	129	102	102	102
query92	61	53	51	51
query93	2305	512	504	504
query94	1239	372	298	298
query95	397	327	314	314
query96	610	265	272	265
query97	3211	3021	3008	3008
query98	218	208	201	201
query99	1521	1305	1238	1238
Total cold run time: 279488 ms
Total hot run time: 174004 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.11 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 68e2d9718486052a5fa616b6347a2a204d23986e, data reload: false

query1	0.04	0.03	0.03
query2	0.09	0.04	0.04
query3	0.22	0.04	0.05
query4	1.67	0.06	0.06
query5	0.49	0.49	0.49
query6	1.13	0.72	0.73
query7	0.02	0.01	0.01
query8	0.04	0.04	0.04
query9	0.55	0.48	0.49
query10	0.54	0.55	0.53
query11	0.16	0.11	0.11
query12	0.14	0.12	0.12
query13	0.59	0.59	0.59
query14	0.76	0.80	0.77
query15	0.84	0.80	0.82
query16	0.35	0.38	0.37
query17	1.05	1.04	1.02
query18	0.22	0.22	0.23
query19	1.91	1.70	1.65
query20	0.01	0.01	0.01
query21	15.40	0.73	0.65
query22	4.59	6.74	1.58
query23	18.30	1.44	1.26
query24	2.11	0.22	0.23
query25	0.15	0.09	0.08
query26	0.29	0.22	0.21
query27	0.45	0.22	0.23
query28	13.24	1.00	1.00
query29	12.60	3.27	3.28
query30	0.26	0.06	0.05
query31	2.87	0.40	0.38
query32	3.27	0.47	0.46
query33	2.90	2.86	2.85
query34	17.15	4.33	4.36
query35	4.41	4.45	4.40
query36	0.64	0.48	0.51
query37	0.18	0.15	0.16
query38	0.15	0.15	0.14
query39	0.05	0.03	0.04
query40	0.14	0.12	0.12
query41	0.09	0.05	0.05
query42	0.05	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 110.15 s
Total hot run time: 30.11 s

@qidaye qidaye force-pushed the format_v2_cases branch from 68e2d97 to cfdc246 Compare July 19, 2024 10:21
@qidaye
Copy link
Contributor Author

qidaye commented Jul 19, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40151 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cfdc2464fd71d40497af2c5a3d862a4bd0ea1f1f, data reload: false

------ Round 1 ----------------------------------
q1	19214	4532	4297	4297
q2	2026	200	195	195
q3	10447	1185	1173	1173
q4	10188	761	802	761
q5	7574	2702	2816	2702
q6	223	136	136	136
q7	963	599	601	599
q8	9216	2106	2128	2106
q9	8895	6595	6641	6595
q10	8667	3785	3786	3785
q11	439	239	254	239
q12	393	232	224	224
q13	18801	3024	2991	2991
q14	272	242	242	242
q15	522	481	473	473
q16	479	390	371	371
q17	986	673	796	673
q18	8211	7555	7376	7376
q19	6877	1438	1422	1422
q20	727	324	332	324
q21	4999	3260	3182	3182
q22	354	285	285	285
Total cold run time: 120473 ms
Total hot run time: 40151 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4368	4260	4299	4260
q2	370	277	272	272
q3	3011	2827	2785	2785
q4	1916	1594	1651	1594
q5	5320	5319	5330	5319
q6	221	131	136	131
q7	2160	1738	1743	1738
q8	3202	3390	3330	3330
q9	8478	8450	8424	8424
q10	3895	3656	3677	3656
q11	593	480	484	480
q12	772	595	589	589
q13	17564	3006	2990	2990
q14	311	276	276	276
q15	519	481	478	478
q16	487	426	444	426
q17	1835	1480	1483	1480
q18	7806	7521	7312	7312
q19	1672	1389	1533	1389
q20	1971	1798	1769	1769
q21	4889	4850	4719	4719
q22	577	520	496	496
Total cold run time: 71937 ms
Total hot run time: 53913 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174172 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cfdc2464fd71d40497af2c5a3d862a4bd0ea1f1f, data reload: false

query1	918	398	386	386
query2	6437	1861	1854	1854
query3	6644	210	220	210
query4	28592	17703	17566	17566
query5	4249	468	476	468
query6	277	172	175	172
query7	4608	283	283	283
query8	239	198	185	185
query9	8600	2427	2418	2418
query10	448	296	267	267
query11	12052	10134	10293	10134
query12	140	89	82	82
query13	1652	379	376	376
query14	10227	7817	7716	7716
query15	223	170	167	167
query16	7600	429	466	429
query17	1591	562	514	514
query18	1757	286	288	286
query19	200	147	149	147
query20	88	81	83	81
query21	214	141	130	130
query22	4215	3998	3992	3992
query23	34020	33159	33115	33115
query24	11920	2934	2833	2833
query25	647	361	363	361
query26	1796	148	152	148
query27	2864	273	272	272
query28	7333	2009	1996	1996
query29	1065	642	616	616
query30	293	156	161	156
query31	941	736	713	713
query32	93	52	55	52
query33	769	322	324	322
query34	940	470	487	470
query35	849	729	734	729
query36	1096	931	938	931
query37	147	78	78	78
query38	2880	2783	2814	2783
query39	864	821	821	821
query40	272	121	116	116
query41	74	44	44	44
query42	128	95	103	95
query43	496	452	447	447
query44	1219	731	731	731
query45	191	161	162	161
query46	1092	740	704	704
query47	1883	1763	1788	1763
query48	366	295	284	284
query49	1178	407	414	407
query50	776	394	394	394
query51	7013	6793	6859	6793
query52	102	98	96	96
query53	361	287	290	287
query54	957	448	456	448
query55	75	76	75	75
query56	302	255	274	255
query57	1134	1096	1059	1059
query58	252	280	277	277
query59	2757	2559	2634	2559
query60	316	295	276	276
query61	96	92	98	92
query62	839	654	654	654
query63	320	291	283	283
query64	10626	2218	1719	1719
query65	3264	3175	3113	3113
query66	1339	332	330	330
query67	15536	15134	15005	15005
query68	4644	533	545	533
query69	572	418	370	370
query70	1169	1117	1142	1117
query71	415	273	281	273
query72	7892	5655	5572	5572
query73	770	328	323	323
query74	6241	5687	5723	5687
query75	3600	2687	2721	2687
query76	3052	977	971	971
query77	695	312	303	303
query78	10109	9248	9195	9195
query79	2290	525	523	523
query80	1462	497	483	483
query81	604	228	236	228
query82	703	136	141	136
query83	275	175	179	175
query84	265	97	92	92
query85	1992	389	364	364
query86	478	306	305	305
query87	3326	3107	3143	3107
query88	3998	2373	2421	2373
query89	496	392	379	379
query90	1833	203	196	196
query91	138	111	115	111
query92	66	51	56	51
query93	2202	514	516	514
query94	1257	305	297	297
query95	410	328	334	328
query96	613	274	266	266
query97	3172	3038	3034	3034
query98	225	214	206	206
query99	1684	1283	1247	1247
Total cold run time: 289100 ms
Total hot run time: 174172 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.71 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cfdc2464fd71d40497af2c5a3d862a4bd0ea1f1f, data reload: false

query1	0.04	0.04	0.04
query2	0.09	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.08	0.08
query5	0.50	0.48	0.49
query6	1.13	0.72	0.73
query7	0.03	0.02	0.01
query8	0.05	0.05	0.04
query9	0.54	0.48	0.49
query10	0.53	0.55	0.54
query11	0.15	0.12	0.12
query12	0.14	0.12	0.12
query13	0.59	0.60	0.59
query14	0.77	0.79	0.79
query15	0.86	0.82	0.82
query16	0.36	0.37	0.36
query17	1.01	1.05	1.04
query18	0.23	0.22	0.23
query19	1.86	1.81	1.76
query20	0.02	0.01	0.01
query21	15.40	0.76	0.66
query22	4.12	6.97	1.81
query23	18.23	1.43	1.34
query24	2.11	0.22	0.22
query25	0.16	0.08	0.09
query26	0.30	0.21	0.21
query27	0.46	0.23	0.22
query28	13.26	1.01	0.99
query29	12.60	3.27	3.27
query30	0.25	0.06	0.05
query31	2.88	0.39	0.39
query32	3.28	0.49	0.46
query33	2.90	2.88	2.89
query34	17.07	4.34	4.34
query35	4.46	4.43	4.41
query36	0.65	0.50	0.49
query37	0.19	0.15	0.15
query38	0.14	0.14	0.15
query39	0.05	0.03	0.03
query40	0.14	0.13	0.12
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.66 s
Total hot run time: 30.71 s

@qidaye qidaye force-pushed the format_v2_cases branch from cfdc246 to 57b77be Compare July 22, 2024 07:53
@qidaye
Copy link
Contributor Author

qidaye commented Jul 22, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39918 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 57b77be7e61e4e5ed206c0f901187816a25ceb3b, data reload: false

------ Round 1 ----------------------------------
q1	18142	4469	4479	4469
q2	2715	199	203	199
q3	11254	1158	1164	1158
q4	10305	709	748	709
q5	7780	2709	2676	2676
q6	226	141	139	139
q7	962	602	607	602
q8	9303	2048	2074	2048
q9	8821	6597	6553	6553
q10	8717	3773	3746	3746
q11	454	232	240	232
q12	397	225	219	219
q13	17768	3005	2981	2981
q14	277	241	226	226
q15	534	476	482	476
q16	485	398	395	395
q17	956	752	638	638
q18	8164	7422	7337	7337
q19	4396	1344	1403	1344
q20	658	320	317	317
q21	4977	3172	3228	3172
q22	341	282	283	282
Total cold run time: 117632 ms
Total hot run time: 39918 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4332	4231	4213	4213
q2	366	273	275	273
q3	2986	2734	2792	2734
q4	1870	1625	1551	1551
q5	5254	5316	5312	5312
q6	220	128	131	128
q7	2147	1686	1775	1686
q8	3198	3341	3300	3300
q9	8397	8381	8418	8381
q10	3907	3632	3661	3632
q11	599	495	496	495
q12	792	623	601	601
q13	16285	3005	2960	2960
q14	300	276	267	267
q15	524	478	489	478
q16	478	419	409	409
q17	1793	1472	1451	1451
q18	7718	7620	7363	7363
q19	1675	1531	1562	1531
q20	2008	1807	1788	1788
q21	4776	4759	4757	4757
q22	573	484	486	484
Total cold run time: 70198 ms
Total hot run time: 53794 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172179 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 57b77be7e61e4e5ed206c0f901187816a25ceb3b, data reload: false

query1	907	369	362	362
query2	6441	1993	1903	1903
query3	6665	204	211	204
query4	28363	17615	17257	17257
query5	4212	478	489	478
query6	266	179	163	163
query7	4589	291	289	289
query8	238	201	217	201
query9	8559	2430	2408	2408
query10	445	290	289	289
query11	10719	10102	10143	10102
query12	134	89	93	89
query13	1646	368	374	368
query14	9465	7578	6984	6984
query15	217	166	167	166
query16	7722	454	498	454
query17	1301	560	544	544
query18	1738	281	291	281
query19	201	152	148	148
query20	91	82	85	82
query21	211	130	124	124
query22	4173	4024	4017	4017
query23	33975	33124	33085	33085
query24	12234	2942	2929	2929
query25	688	385	392	385
query26	1793	154	151	151
query27	2975	269	279	269
query28	7671	1992	1975	1975
query29	1139	649	629	629
query30	296	149	148	148
query31	951	739	742	739
query32	102	55	54	54
query33	782	346	341	341
query34	892	472	502	472
query35	881	728	735	728
query36	1101	928	928	928
query37	283	82	82	82
query38	2950	2730	2750	2730
query39	849	805	778	778
query40	282	118	116	116
query41	46	45	46	45
query42	117	101	99	99
query43	509	465	452	452
query44	1219	742	713	713
query45	187	159	156	156
query46	1106	751	714	714
query47	1865	1768	1790	1768
query48	361	289	289	289
query49	1176	406	407	406
query50	797	386	395	386
query51	6814	6689	6600	6600
query52	104	86	91	86
query53	352	291	287	287
query54	979	460	444	444
query55	74	71	73	71
query56	287	268	265	265
query57	1170	1064	1043	1043
query58	262	248	274	248
query59	2788	2674	2645	2645
query60	322	283	278	278
query61	96	93	96	93
query62	834	646	658	646
query63	332	291	280	280
query64	10526	2237	1682	1682
query65	3148	3128	3076	3076
query66	1330	328	329	328
query67	15486	14976	15075	14976
query68	6053	530	537	530
query69	727	449	356	356
query70	1160	1065	1155	1065
query71	496	279	277	277
query72	8904	5145	5160	5145
query73	778	329	331	329
query74	6239	5692	5749	5692
query75	4738	2686	2638	2638
query76	4117	970	905	905
query77	714	312	306	306
query78	9836	9068	9871	9068
query79	4938	513	523	513
query80	1141	478	473	473
query81	581	220	222	220
query82	1480	139	136	136
query83	396	169	165	165
query84	283	88	91	88
query85	1541	320	358	320
query86	335	314	313	313
query87	3331	3124	3069	3069
query88	5011	2458	2456	2456
query89	495	392	390	390
query90	1896	196	195	195
query91	133	101	102	101
query92	61	50	50	50
query93	5034	508	494	494
query94	1088	288	282	282
query95	411	321	321	321
query96	602	286	283	283
query97	3194	3040	3038	3038
query98	232	199	191	191
query99	1567	1242	1264	1242
Total cold run time: 297946 ms
Total hot run time: 172179 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.36 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 57b77be7e61e4e5ed206c0f901187816a25ceb3b, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.06	0.05
query4	1.68	0.07	0.08
query5	0.49	0.49	0.50
query6	1.14	0.72	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.48	0.50
query10	0.55	0.55	0.55
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.61	0.59	0.58
query14	0.76	0.79	0.78
query15	0.84	0.82	0.81
query16	0.35	0.34	0.35
query17	0.98	0.97	1.05
query18	0.23	0.22	0.21
query19	1.82	1.68	1.72
query20	0.01	0.01	0.01
query21	15.40	0.73	0.64
query22	4.80	6.85	1.61
query23	18.24	1.42	1.30
query24	2.10	0.23	0.24
query25	0.17	0.09	0.09
query26	0.30	0.21	0.21
query27	0.46	0.24	0.24
query28	13.19	1.04	1.01
query29	12.60	3.38	3.38
query30	0.25	0.06	0.06
query31	2.86	0.39	0.39
query32	3.29	0.48	0.47
query33	2.89	2.93	2.84
query34	17.19	4.38	4.32
query35	4.41	4.42	4.41
query36	0.66	0.48	0.48
query37	0.19	0.17	0.16
query38	0.16	0.15	0.14
query39	0.04	0.04	0.04
query40	0.16	0.14	0.12
query41	0.10	0.05	0.06
query42	0.06	0.05	0.04
query43	0.04	0.05	0.04
Total cold run time: 110.28 s
Total hot run time: 30.36 s

@qidaye
Copy link
Contributor Author

qidaye commented Jul 22, 2024

run external

@qidaye
Copy link
Contributor Author

qidaye commented Jul 22, 2024

run p0

@qidaye
Copy link
Contributor Author

qidaye commented Jul 22, 2024

run cloud_p0

airborne12
airborne12 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zzzxl1993
zzzxl1993 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@zzzxl1993 zzzxl1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@qidaye qidaye merged commit 5b5a704 into apache:master Jul 22, 2024
27 of 29 checks passed
@qidaye qidaye deleted the format_v2_cases branch July 22, 2024 13:12
qidaye added a commit to qidaye/incubator-doris that referenced this pull request Jul 22, 2024
@qidaye
[test](inverted index)Add cases for inverted index format v2 (apache#…
626c506 
…38132)

## Proposed changes

1. Add exception when trying to change index storage format
2. Add test cases for index format v2
    - test_add_build_index_with_format_v2
    - test_create_table_with_format_v2
    - test_cumulative_compaction_with_format_v2
    - test_drop_column_with_format_v2
    - test_drop_index_with_format_v2
    - test_index_change_format
    - test_mor_table_with_format_v2
    - test_mow_table_with_format_v2
    - test_recover_with_format_v2
    - test_rename_column_with_format_v2
    - test_single_replica_compaction_with_format_v2
3. There is a test case `test_rename_column_with_format_v2` for apache#38079
@qidaye qidaye mentioned this pull request Jul 22, 2024
Merged
dataroaring pushed a commit that referenced this pull request Jul 24, 2024
@qidaye @dataroaring
[test](inverted index)Add cases for inverted index format v2 (#38132)
3650189 
## Proposed changes

1. Add exception when trying to change index storage format
2. Add test cases for index format v2
    - test_add_build_index_with_format_v2
    - test_create_table_with_format_v2
    - test_cumulative_compaction_with_format_v2
    - test_drop_column_with_format_v2
    - test_drop_index_with_format_v2
    - test_index_change_format
    - test_mor_table_with_format_v2
    - test_mow_table_with_format_v2
    - test_recover_with_format_v2
    - test_rename_column_with_format_v2
    - test_single_replica_compaction_with_format_v2
3. There is a test case `test_rename_column_with_format_v2` for #38079
qidaye added a commit to qidaye/incubator-doris that referenced this pull request Aug 1, 2024
@qidaye
[test](inverted index)Add cases for inverted index format v2 (apache#…
90971c1 
…38132)

## Proposed changes

1. Add exception when trying to change index storage format
2. Add test cases for index format v2
    - test_add_build_index_with_format_v2
    - test_create_table_with_format_v2
    - test_cumulative_compaction_with_format_v2
    - test_drop_column_with_format_v2
    - test_drop_index_with_format_v2
    - test_index_change_format
    - test_mor_table_with_format_v2
    - test_mow_table_with_format_v2
    - test_recover_with_format_v2
    - test_rename_column_with_format_v2
    - test_single_replica_compaction_with_format_v2
3. There is a test case `test_rename_column_with_format_v2` for apache#38079
yiguolei pushed a commit that referenced this pull request Aug 2, 2024
@qidaye
[test](inverted index)Add cases for inverted index format v2 (#38132)(#…
f21d7e3 
…38443) (#38222)

## Proposed changes

backport #38132 #38443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airborne12 airborne12 airborne12 approved these changes

@zzzxl1993 zzzxl1993 zzzxl1993 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.1-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qidaye @doris-robot @airborne12 @zzzxl1993 @yiguolei @dataroaring