[Spill To Disk] Analytic_Eval_Node Support Spill Disk and Del Some Unless Code #3820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c_Eval_Node, FE can open enable spilling by
set enable_spilling = true;
Now, Sort Node and Analytic_Eval_Node can spill to disk.
2. Delete merge merge_sorter code we do not use now.
3. Replace buffered_tuple_stream by buffered_tuple_stream2 in Analytic_Eval_Node and support spill to disk. Delete the useless code of buffered_block_mgr and buffered_tuple_stream.
4. Add DataStreamRecvr Profile. Move the counter belong to DataStreamRecvr from fragment to DataStreamRecvr Profile to make clear of Running Profile.
wutiangan
reviewed
Jun 10, 2020
| _sub_plan_query_statistics_recvr(sub_plan_query_statistics_recvr) { | ||
| _mem_tracker.reset(new MemTracker(-1, "DataStreamRecvr", parent_tracker)); | ||
| _profile.reset(new RuntimeProfile(nullptr, "DataStreamRecvr")); | ||
| profile->add_child(_profile.get(), true, nullptr); |
Contributor
There was a problem hiding this comment.
Suggested change
| profile->add_child(_profile.get(), true, nullptr); | |
| _profile->add_child(_profile.get(), true, nullptr); |
Contributor
Author
There was a problem hiding this comment.
@wutiangan Hello, The profile is the param of the method DataStreamRecvr constructed function. _profile is the unique_ptr of the RunningProile be long to the object DataStreamRecvr.
So they are indeed different, the suggest change may cause problem.
chaoyli
requested changes
Jun 10, 2020
| _block_write_threshold(tmp_file_mgr->num_active_tmp_devices() * 2), | ||
| // _disable_spill(state->query_ctx().disable_spilling), | ||
| _disable_spill(false), | ||
| _disable_spill(state->disable_spill()), |
Contributor
There was a problem hiding this comment.
use enable_spill is better which is compatible to fe
Contributor
Author
There was a problem hiding this comment.
ok，i will change the bool var
chaoyli
approved these changes
Jun 12, 2020
kangkaisen
reviewed
Jun 12, 2020
kangkaisen
reviewed
Jun 12, 2020
kangkaisen
reviewed
Jun 12, 2020
kangkaisen
reviewed
Jun 12, 2020
morningman
added
approved
Closed
csun5285
pushed a commit
to csun5285/doris
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add enable spilling in query option, upport spill disk in Analytic_Eval_Node, FE can open enable spilling by
Now, Sort Node and Analytic_Eval_Node can spill to disk.
2. Delete merge merge_sorter code we do not use now.
3. Replace buffered_tuple_stream by buffered_tuple_stream2 in Analytic_Eval_Node and support spill to disk. Delete the useless code of buffered_block_mgr and buffered_tuple_stream.
4. Add DataStreamRecvr Profile. Move the counter belong to DataStreamRecvr from fragment to DataStreamRecvr Profile to make clear of Running Profile.