[fix](serde)fix the bug in DataTypeNullableSerDe.deserialize_column_from_fixed_json #38245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39840 ms |
TPC-DS: Total hot run time: 173945 ms |
ClickBench: Total hot run time: 30.29 s |
hubgeter
force-pushed
the
fix_nullable_serde_fixed_value
branch
from
b97b34c
to
8903bcf
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
TPC-H: Total hot run time: 41830 ms |
TPC-DS: Total hot run time: 169221 ms |
ClickBench: Total hot run time: 30 s |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
kaka11chen
reviewed
Jul 31, 2024
|
run buildall |
github-actions
bot
removed
the
approved
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 42288 ms |
TPC-DS: Total hot run time: 171261 ms |
ClickBench: Total hot run time: 30.38 s |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
hubgeter
added a commit
to hubgeter/doris
that referenced
this pull request
Aug 2, 2024
…rom_fixed_json (apache#38245) ## Proposed changes fix a bug in DataTypeNullableSerDe.deserialize_column_from_fixed_json. The expected behavior of the `deserialize_column_from_fixed_json` function is to `insert` n values into the column. However, when the `DataTypeNullableSerDe` class implements this function, the null_map column is `resize` to n, which does not insert n values into it. Since this function is only used by the `_fill_partition_columns` of the `parquet/orc reader` and is not called repeatedly for a `get_next_block`, this bug is covered up. before pr : apache#37377
yiguolei
pushed a commit
that referenced
this pull request
Aug 5, 2024
dataroaring
pushed a commit
that referenced
this pull request
Aug 11, 2024
…rom_fixed_json (#38245) ## Proposed changes fix a bug in DataTypeNullableSerDe.deserialize_column_from_fixed_json. The expected behavior of the `deserialize_column_from_fixed_json` function is to `insert` n values into the column. However, when the `DataTypeNullableSerDe` class implements this function, the null_map column is `resize` to n, which does not insert n values into it. Since this function is only used by the `_fill_partition_columns` of the `parquet/orc reader` and is not called repeatedly for a `get_next_block`, this bug is covered up. before pr : #37377
dataroaring
pushed a commit
that referenced
this pull request
Aug 16, 2024
…rom_fixed_json (#38245) ## Proposed changes fix a bug in DataTypeNullableSerDe.deserialize_column_from_fixed_json. The expected behavior of the `deserialize_column_from_fixed_json` function is to `insert` n values into the column. However, when the `DataTypeNullableSerDe` class implements this function, the null_map column is `resize` to n, which does not insert n values into it. Since this function is only used by the `_fill_partition_columns` of the `parquet/orc reader` and is not called repeatedly for a `get_next_block`, this bug is covered up. before pr : #37377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
fix a bug in DataTypeNullableSerDe.deserialize_column_from_fixed_json.
The expected behavior of the
deserialize_column_from_fixed_jsonfunction is toinsertn values into the column.However, when the
DataTypeNullableSerDeclass implements this function, the null_map column isresizeto n, which does not insert n values into it. Since this function is only used by the_fill_partition_columnsof theparquet/orc readerand is not called repeatedly for aget_next_block, this bug is covered up.before pr : #37377