[Fix](recycler) recycler need index_suffix and inverted index storage format to delete idx file #38306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
eldenmoon
reviewed
Jul 25, 2024
w41ter
reviewed
Jul 25, 2024
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
w41ter
approved these changes
Jul 25, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
platoneko
approved these changes
Jul 25, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jul 31, 2024
… format to delete idx file (#38306) ## Proposed changes Recycler did not correctly delete idx file for inverted index format V2 and variant data type.
gavinchou
reviewed
Aug 5, 2024
| @@ -226,6 +226,8 @@ class InstanceRecycler { | |||
|
|
|||
| // TODO(plat1ko): Add new accessor to map in runtime for new created storage vaults | |||
| std::unordered_map<std::string, std::shared_ptr<StorageVaultAccessor>> accessor_map_; | |||
| using InvertedIndexInfo = | |||
airborne12
added a commit
that referenced
this pull request
Dec 4, 2024
Related PR: #38306 Problem Summary: Non inverted index storage format for old version will cause leaking recycling idx files.
16 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
Related PR: #38306 Problem Summary: Non inverted index storage format for old version will cause leaking recycling idx files.
BiteTheDDDDt
pushed a commit
to BiteTheDDDDt/incubator-doris
that referenced
this pull request
Feb 7, 2025
Related PR: apache#38306 Problem Summary: Non inverted index storage format for old version will cause leaking recycling idx files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Recycler did not correctly delete idx file for inverted index format V2 and variant data type.