[feature](compaction) Add an http action for visibility of compaction score on each tablet #38489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
TangSiyang2001
changed the title
|
clang-tidy review says "All clean, LGTM! 👍" |
TangSiyang2001
force-pushed
the
tablet-compaction-score-http
branch
from
776eb5f
to
1f013b9
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
TangSiyang2001
force-pushed
the
tablet-compaction-score-http
branch
3 times, most recently
from
1302446
to
2caa8c2
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
TangSiyang2001
force-pushed
the
tablet-compaction-score-http
branch
from
2caa8c2
to
702fb89
Compare
|
run compile |
|
clang-tidy review says "All clean, LGTM! 👍" |
TangSiyang2001
force-pushed
the
tablet-compaction-score-http
branch
from
702fb89
to
b9a5314
Compare
|
run compile |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
TangSiyang2001
force-pushed
the
tablet-compaction-score-http
branch
from
b9a5314
to
a047be1
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
TPC-H: Total hot run time: 41594 ms |
TPC-DS: Total hot run time: 169610 ms |
ClickBench: Total hot run time: 30.28 s |
luwei16
reviewed
Aug 1, 2024
| score_key.SetString(key_name.data(), key_name.size()); | ||
|
|
||
| rapidjson::Value score_val; | ||
| auto score = |
There was a problem hiding this comment.
no need to distinguish between base and cumu
|
clang-tidy review says "All clean, LGTM! 👍" |
TangSiyang2001
force-pushed
the
tablet-compaction-score-http
branch
from
c6a7a4d
to
646d360
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
TangSiyang2001
force-pushed
the
tablet-compaction-score-http
branch
from
ebbda17
to
356ef16
Compare
|
run buildall |
|
TeamCity be ut coverage result: |
|
run performance |
gavinchou
previously approved these changes
Sep 10, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
github-actions
bot
removed
the
approved
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38774 ms |
TPC-DS: Total hot run time: 192876 ms |
ClickBench: Total hot run time: 31.65 s |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
dataroaring
added
dev/2.1.x
and removed
approved
TangSiyang2001
added a commit
to TangSiyang2001/doris
that referenced
this pull request
Sep 13, 2024
… score on each tablet (apache#38489) As title. Usage: 1. `curl http://be_ip:be_host/api/compaction_score?top_n=10` Returns a json object contains compaction score for top n, n=top_n. ``` [ { "compaction_score": "5", "tablet_id": "42595" }, { "compaction_score": "5", "tablet_id": "42587" }, { "compaction_score": "5", "tablet_id": "42593" }, { "compaction_score": "5", "tablet_id": "42597" }, { "compaction_score": "5", "tablet_id": "42589" }, { "compaction_score": "5", "tablet_id": "42599" }, { "compaction_score": "5", "tablet_id": "42601" }, { "compaction_score": "5", "tablet_id": "42591" }, { "compaction_score": "5", "tablet_id": "42585" }, { "compaction_score": "4", "tablet_id": "10034" } ] ``` If top_n is not specified, return all compaction score for all tablets. If top_n is illegal, raise an error. ``` invalid argument: top_n=wrong ``` 2. `curl http://be_ip:be_host/api/compaction_score?sync_meta=true` `sync_meta` is only available on cloud mode, will sync meta from meta service. It can cooperate with top_n. If add param `sync_meta` on non-cloud mode, will raise an error. ``` sync meta is only available for cloud mode ``` 3. In the future, this endpoint may extend other utility, like fetching tablet compaction score by table id, etc.
yiguolei
pushed a commit
that referenced
this pull request
Sep 21, 2024
… score on each tablet (#38489) (#40826) pick: #38489 Usage: 1. `curl http://be_ip:be_host/api/compaction_score?top_n=10` Returns a json object contains compaction score for top n, n=top_n. ``` [ { "compaction_score": "5", "tablet_id": "42595" }, { "compaction_score": "5", "tablet_id": "42587" }, { "compaction_score": "5", "tablet_id": "42593" }, { "compaction_score": "5", "tablet_id": "42597" }, { "compaction_score": "5", "tablet_id": "42589" }, { "compaction_score": "5", "tablet_id": "42599" }, { "compaction_score": "5", "tablet_id": "42601" }, { "compaction_score": "5", "tablet_id": "42591" }, { "compaction_score": "5", "tablet_id": "42585" }, { "compaction_score": "4", "tablet_id": "10034" } ] ``` If top_n is not specified, return all compaction score for all tablets. If top_n is illegal, raise an error. ``` invalid argument: top_n=wrong ``` 2. `curl http://be_ip:be_host/api/compaction_score?sync_meta=true` `sync_meta` is only available on cloud mode, will sync meta from meta service. It can cooperate with top_n. If add param `sync_meta` on non-cloud mode, will raise an error. ``` sync meta is only available for cloud mode ``` 3. In the future, this endpoint may extend other utility, like fetching tablet compaction score by table id, etc. ## Proposed changes Issue Number: close #xxx <!--Describe your changes.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As title.
Usage:
curl http://be_ip:be_host/api/compaction_score?top_n=10Returns a json object contains compaction score for top n, n=top_n.
If top_n is not specified, return all compaction score for all tablets.
If top_n is illegal, raise an error.
curl http://be_ip:be_host/api/compaction_score?sync_meta=truesync_metais only available on cloud mode, will sync meta from meta service. It can cooperate with top_n.If add param
sync_metaon non-cloud mode, will raise an error.