-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[optimize] Optimize spark load/broker load reading parquet format file #3878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
morningman
merged 8 commits into
apache:master
from
xy720:spark_load_parquet_buffer_reader
Jun 23, 2020
Merged
[optimize] Optimize spark load/broker load reading parquet format file #3878
morningman
merged 8 commits into
apache:master
from
xy720:spark_load_parquet_buffer_reader
Jun 23, 2020
+415
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Great job |
kangkaisen
reviewed
Jun 16, 2020
Contributor
|
@xy720 Hi, Please add the UT for new BufferedReader class, Thanks. |
morningman
reviewed
Jun 16, 2020
35f1391 to
9165165
Compare
morningman
reviewed
Jun 20, 2020
morningman
previously approved these changes
Jun 22, 2020
Contributor
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wutiangan
reviewed
Jun 22, 2020
wutiangan
reviewed
Jun 22, 2020
morningman
approved these changes
Jun 22, 2020
Contributor
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
area/broker
Issues or PRs related to broker
area/load
Issues or PRs related to all kinds of load
kind/improvement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the description in #3877 .
spark load #3433