Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt](catalog) merge scan range to avoid too many splits (#38311) #38964

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

morningman
Copy link
Contributor

bp #38311

PR apache#34032 introduce a new method to get splits batch by batch,
but it removed a logic that BE will merge scan ranges to avoid too many
scan ranges being scheduled.

This PR mainly changes:
1. Add scan range merging logic back.
2. Change the default file split size from 8MB to 64MB, to avoid too
many small split.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morningman
Copy link
Contributor Author

run buildall

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

LOG(INFO) << "Merge " << scan_ranges.size() << " scan ranges to " << merged_ranges.size();
}

protected:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]

Suggested change
protected:
Additional context

be/src/vec/exec/scan/split_source_connector.h:46: previously declared here

protected:
^

@morningman
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.40% (9268/25459)
Line Coverage: 27.92% (75821/271592)
Region Coverage: 26.77% (39004/145712)
Branch Coverage: 23.49% (19795/84282)
Coverage Report: http://coverage.selectdb-in.cc/coverage/91c284b5447e3a4e9be632cbd0967e1d18c4421a_91c284b5447e3a4e9be632cbd0967e1d18c4421a/report/index.html

@morningman morningman merged commit bc644cb into apache:branch-2.1 Aug 6, 2024
19 of 21 checks passed
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants