Skip to content

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Aug 7, 2024

Proposed changes

fix a typo in #37670

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@bobhan1
Copy link
Contributor Author

bobhan1 commented Aug 7, 2024

run buildall

@github-actions github-actions bot added the doing label Aug 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 42019 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b29360a21d7a0a405b578551afee7ff5daa8afc2, data reload: false

------ Round 1 ----------------------------------
q1	18223	4275	4213	4213
q2	2550	205	202	202
q3	11180	1254	1393	1254
q4	10660	858	948	858
q5	8218	3077	3050	3050
q6	231	140	138	138
q7	1103	630	608	608
q8	9442	1987	1963	1963
q9	8473	6606	6605	6605
q10	8723	3869	3866	3866
q11	426	253	250	250
q12	421	225	227	225
q13	17765	2950	2932	2932
q14	275	236	250	236
q15	530	478	498	478
q16	498	419	385	385
q17	1000	955	950	950
q18	8222	7386	7278	7278
q19	1421	1236	1229	1229
q20	567	325	332	325
q21	5298	4693	4754	4693
q22	347	281	281	281
Total cold run time: 115573 ms
Total hot run time: 42019 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4103	4087	4073	4073
q2	336	235	226	226
q3	3026	3018	2995	2995
q4	1895	1888	1908	1888
q5	5257	5288	5276	5276
q6	222	130	131	130
q7	2058	1659	1732	1659
q8	3233	3265	3245	3245
q9	8263	8294	8247	8247
q10	3791	3865	3873	3865
q11	544	446	447	446
q12	729	565	565	565
q13	10760	2912	2946	2912
q14	288	257	264	257
q15	513	477	488	477
q16	448	408	400	400
q17	1752	1734	1736	1734
q18	7754	7384	7365	7365
q19	1714	1723	1716	1716
q20	1998	1757	1747	1747
q21	5416	5141	5133	5133
q22	507	454	452	452
Total cold run time: 64607 ms
Total hot run time: 54808 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 169339 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b29360a21d7a0a405b578551afee7ff5daa8afc2, data reload: false

query1	917	369	369	369
query2	6486	1714	1714	1714
query3	6669	212	221	212
query4	19572	17569	17621	17569
query5	4262	522	512	512
query6	272	161	163	161
query7	4603	303	287	287
query8	262	215	187	187
query9	8494	2339	2322	2322
query10	454	282	259	259
query11	10687	10222	10282	10222
query12	137	90	87	87
query13	1630	381	386	381
query14	9257	7522	6694	6694
query15	202	173	172	172
query16	7110	425	456	425
query17	958	595	547	547
query18	1837	282	283	282
query19	199	148	149	148
query20	94	86	93	86
query21	207	102	101	101
query22	4469	4301	4282	4282
query23	33708	33245	33282	33245
query24	10314	3109	3036	3036
query25	706	401	421	401
query26	1790	154	156	154
query27	2952	277	279	277
query28	6962	1954	1945	1945
query29	1325	432	426	426
query30	285	151	152	151
query31	929	760	777	760
query32	101	58	60	58
query33	706	326	318	318
query34	896	484	475	475
query35	852	721	737	721
query36	1046	873	864	864
query37	293	79	81	79
query38	2869	2777	2776	2776
query39	866	823	815	815
query40	287	116	113	113
query41	53	46	49	46
query42	116	101	104	101
query43	471	427	420	420
query44	1174	722	724	722
query45	208	177	177	177
query46	1091	814	781	781
query47	1866	1747	1749	1747
query48	365	290	302	290
query49	1291	411	416	411
query50	903	436	425	425
query51	6818	6691	6731	6691
query52	100	90	89	89
query53	258	184	180	180
query54	630	448	459	448
query55	76	73	74	73
query56	263	244	256	244
query57	1185	1062	1043	1043
query58	278	260	269	260
query59	2603	2557	2478	2478
query60	295	281	282	281
query61	97	111	89	89
query62	904	659	664	659
query63	224	180	175	175
query64	5857	1920	1868	1868
query65	3161	3102	3126	3102
query66	1419	344	326	326
query67	15359	14725	14822	14725
query68	4512	573	580	573
query69	655	346	336	336
query70	1060	1038	1088	1038
query71	471	275	278	275
query72	7809	2683	2449	2449
query73	778	326	336	326
query74	6013	5739	5607	5607
query75	3815	2704	2677	2677
query76	3020	1142	1272	1142
query77	711	308	316	308
query78	9539	8907	9019	8907
query79	2685	520	531	520
query80	1221	535	489	489
query81	557	229	224	224
query82	1407	133	130	130
query83	386	178	183	178
query84	279	77	84	77
query85	1583	293	287	287
query86	450	294	293	293
query87	3282	3062	3205	3062
query88	3714	2389	2412	2389
query89	379	280	292	280
query90	2017	192	187	187
query91	123	116	102	102
query92	63	51	51	51
query93	2174	627	618	618
query94	1022	268	302	268
query95	374	269	260	260
query96	599	277	279	277
query97	3240	3075	3066	3066
query98	223	203	189	189
query99	1575	1270	1289	1270
Total cold run time: 268466 ms
Total hot run time: 169339 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.37 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b29360a21d7a0a405b578551afee7ff5daa8afc2, data reload: false

query1	0.05	0.04	0.04
query2	0.07	0.03	0.04
query3	0.23	0.05	0.04
query4	1.66	0.08	0.07
query5	0.49	0.48	0.50
query6	1.13	0.72	0.71
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.57	0.52	0.50
query10	0.56	0.57	0.57
query11	0.15	0.11	0.12
query12	0.15	0.13	0.12
query13	0.61	0.60	0.59
query14	0.78	0.78	0.78
query15	0.93	0.86	0.86
query16	0.35	0.35	0.36
query17	1.02	1.00	1.00
query18	0.22	0.20	0.21
query19	1.88	1.75	1.71
query20	0.01	0.01	0.00
query21	15.41	0.74	0.65
query22	4.21	7.34	1.81
query23	17.95	1.28	1.26
query24	2.28	0.23	0.22
query25	0.19	0.08	0.08
query26	0.32	0.22	0.22
query27	0.46	0.23	0.23
query28	13.18	0.99	0.96
query29	12.52	3.27	3.30
query30	0.24	0.06	0.05
query31	2.87	0.40	0.41
query32	3.22	0.49	0.48
query33	2.90	2.97	2.92
query34	15.44	4.27	4.27
query35	4.30	4.30	4.26
query36	0.68	0.49	0.49
query37	0.20	0.16	0.16
query38	0.16	0.15	0.15
query39	0.05	0.04	0.03
query40	0.16	0.13	0.13
query41	0.09	0.04	0.04
query42	0.05	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 107.85 s
Total hot run time: 30.37 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit f9b7cd9 into apache:master Aug 7, 2024
dataroaring pushed a commit that referenced this pull request Aug 7, 2024
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Aug 14, 2024
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.1-merged doing p0_w reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants