Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[branch-2.1][fix](expr) Enhance SQL Expression Handling by Introducing printSqlInParens to CompoundPredicate #39082

Merged
merged 2 commits into from
Aug 14, 2024
Merged

[branch-2.1][fix](expr) Enhance SQL Expression Handling by Introducing printSqlInParens to CompoundPredicate #39082

merged 2 commits into from
Aug 14, 2024

Commits on Aug 13, 2024

  1. [fix](expr) Enhance SQL Expression Handling by Introducing printSqlIn… 

    …Parens to CompoundPredicate (apache#39064)

This PR enhances SQL expression handling by introducing a printSqlInParens flag to the CompoundPredicate class and setting it to true. This ensures that expressions in a CompoundPredicate are always enclosed in parentheses, similar to how it is handled in a BinaryPredicate. . By removing redundant handling of CompoundPredicate, the logic for handling SQL generation in the JdbcScanNode node has been simplified as the updated toSql method now handles this uniformly across expressions.
    @zy-kkk
    zy-kkk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    b23347e View commit details
    Browse the repository at this point in the history

  2. fix ut

    @zy-kkk
    zy-kkk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    88dbbd9 View commit details
    Browse the repository at this point in the history