Skip to content

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Jun 19, 2020

When we get default system time zone, it will return PRC, which is not supported by us, thus
will cause dynamic partition create failed. Fix #3919

This CL mainly changes:

  1. Use a unified method to get the system default time zone
  2. Now the default variable system_time_zone and time_zone is set to the default system
    time zone, which is Asia/Shanghai.
  3. Modify related unit test.
  4. Support time zone PRC.

@morningman morningman added kind/fix Categorizes issue or PR as related to a bug. area/catalog Issues or PRs related to catalog management labels Jun 19, 2020
@morningman morningman changed the title [Bug] Checkpoint thread is not running [Bug] Unify the timezone Jun 19, 2020
}

// NOTICE: In most cases, you should use getCurrentCatalog() to get the catalog.
// getServiingCatalog() is only used for Checkpoint thread and some special places
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getServingCatalog

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I moved the change to PR #3229
I will rebase after that PR merged.

Copy link
Contributor Author

@morningman morningman Jun 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for review.

@morningman morningman force-pushed the checkpoint_thread_missing branch from a543f78 to d42573f Compare June 20, 2020 03:40
@morningman morningman force-pushed the checkpoint_thread_missing branch from d42573f to 4a40cc1 Compare June 21, 2020 08:57
@WingsGo
Copy link
Contributor

WingsGo commented Jun 21, 2020

LGTM

Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Jun 23, 2020
@morningman morningman merged commit df8f9cc into apache:master Jun 24, 2020
suxiaogang223 pushed a commit to suxiaogang223/doris that referenced this pull request Jul 15, 2025
…pdate delete bitmap update lock be able to be in different fdb txns apache#45206 (apache#45559) (apache#3910)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/catalog Issues or PRs related to catalog management kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Create table with dynamic partition encounter exception

4 participants