[fix](ES Catalog)Check isArray before parse json to array #39104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39315 ms |
TPC-H: Total hot run time: 39382 ms |
TPC-DS: Total hot run time: 203896 ms |
ClickBench: Total hot run time: 31.06 s |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
github-actions
bot
removed
the
approved
Contributor
Author
|
run buildall |
qidaye
force-pushed
the
fix_es_catalog_core
branch
from
f3dee95 to
cc42cd6
Compare
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39465 ms |
TPC-DS: Total hot run time: 200441 ms |
ClickBench: Total hot run time: 30.05 s |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
qidaye
added a commit
to qidaye/incubator-doris
that referenced
this pull request
Aug 13, 2024
## Proposed changes Elasticsearch does not have an explicit array type, but one of its fields can contain [0 or more values](https://www.elastic.co/guide/en/elasticsearch/reference/current/array.html). When the field has one value and we map it as array type in Doris, it will run into segment fault while parsing it. So we add a check before we parse json to array. Issue Number: close apache#39102
qidaye
added a commit
to qidaye/incubator-doris
that referenced
this pull request
Aug 13, 2024
## Proposed changes Elasticsearch does not have an explicit array type, but one of its fields can contain [0 or more values](https://www.elastic.co/guide/en/elasticsearch/reference/current/array.html). When the field has one value and we map it as array type in Doris, it will run into segment fault while parsing it. So we add a check before we parse json to array. Issue Number: close apache#39102
yiguolei
pushed a commit
that referenced
this pull request
Aug 13, 2024
xiaokang
pushed a commit
that referenced
this pull request
Aug 14, 2024
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Aug 14, 2024
## Proposed changes Elasticsearch does not have an explicit array type, but one of its fields can contain [0 or more values](https://www.elastic.co/guide/en/elasticsearch/reference/current/array.html). When the field has one value and we map it as array type in Doris, it will run into segment fault while parsing it. So we add a check before we parse json to array. Issue Number: close apache#39102
dataroaring
pushed a commit
that referenced
this pull request
Aug 17, 2024
## Proposed changes Elasticsearch does not have an explicit array type, but one of its fields can contain [0 or more values](https://www.elastic.co/guide/en/elasticsearch/reference/current/array.html). When the field has one value and we map it as array type in Doris, it will run into segment fault while parsing it. So we add a check before we parse json to array. Issue Number: close #39102
qidaye
added a commit
that referenced
this pull request
Sep 11, 2024
qidaye
added a commit
to qidaye/incubator-doris
that referenced
this pull request
Sep 11, 2024
…40614) Follow up apache#39104, when the field has one value and we map it as array type in Doris, we parse the single value to a single element array to make them queryable. close apache#40406
qidaye
added a commit
to qidaye/incubator-doris
that referenced
this pull request
Sep 11, 2024
…40614) Follow up apache#39104, when the field has one value and we map it as array type in Doris, we parse the single value to a single element array to make them queryable. close apache#40406
qidaye
added a commit
to qidaye/incubator-doris
that referenced
this pull request
Sep 11, 2024
…40614) Follow up apache#39104, when the field has one value and we map it as array type in Doris, we parse the single value to a single element array to make them queryable. close apache#40406
qidaye
added a commit
to qidaye/incubator-doris
that referenced
this pull request
Sep 11, 2024
…40614) Follow up apache#39104, when the field has one value and we map it as array type in Doris, we parse the single value to a single element array to make them queryable. close apache#40406
dataroaring
pushed a commit
that referenced
this pull request
Oct 9, 2024
Closed
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Elasticsearch does not have an explicit array type, but one of its fields can contain 0 or more values.
When the field has one value and we map it as array type in Doris, it will run into segment fault while parsing it.
So we add a check before we parse json to array.
Issue Number: close #39102