Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug](parquet)Fix the problem that the parquet reader reads the missing sub-columns of the struct and fails. (#38718) #39192

Conversation

hubgeter
Copy link
Contributor

bp #38718

Proposed changes

Fix the problem that the parquet reader reads the missing sub-columns of the struct and fails.
for example :
suppose we have a column array<struct<a:int>> . And this column has two data

[{1},{2},{3}]
[{4},{5}]

Then we add a subcolumn b to the struct . Now the column structure is like this array<struct<a:int,b:string>>
The expected data for the query is as follows, instead of an error :

[{1,null},{2,null},{3,null}]
[{4,null},{5,null}]

…ng sub-columns of the struct and fails. (apache#38718)

## Proposed changes

Fix the problem that the parquet reader reads the missing sub-columns of
the struct and fails.
for example : 
suppose we have a column `array<struct<a:int>>` . And this column has
two data
```
[{1},{2},{3}]
[{4},{5}]
```
Then we add a subcolumn b to the struct . Now the column structure is
like this `array<struct<a:int,b:string>>`
The expected data for the query is as follows, instead of an error  :
 
```
[{1,null},{2,null},{3,null}]
[{4,null},{5,null}]
```
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@hubgeter
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.51% (9316/25518)
Line Coverage: 28.02% (76320/272402)
Region Coverage: 26.82% (39195/146115)
Branch Coverage: 23.54% (19899/84550)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e63071991ebd8155994b6cd0803a3654b996b136_e63071991ebd8155994b6cd0803a3654b996b136/report/index.html

@morningman morningman merged commit 3da2d1c into apache:branch-2.1 Aug 11, 2024
20 of 22 checks passed
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants