Skip to content

[Bug] Enable to get TCP metrics for linux kernel 2.x #3921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 5 commits into from
Jun 24, 2020
Merged

[Bug] Enable to get TCP metrics for linux kernel 2.x #3921

morningman merged 5 commits into from
Jun 24, 2020

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Jun 21, 2020 •
edited
Loading

Fix #3920

CL:

  1. Parse the TCP metrics header in /proc/net/snmp to get the right position of the metrics.
  2. Add 2 new metrics: tcp_in_segs and tcp_out_segs

@morningman morningman added kind/fix Categorizes issue or PR as related to a bug. area/metrics Issues or PRs related to the metrics labels Jun 21, 2020
@morningman morningman self-assigned this Jun 21, 2020
yangzhg
yangzhg previously approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Jun 24, 2020
yangzhg
yangzhg approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 46c64f0 into apache:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yangzhg yangzhg yangzhg approved these changes

Assignees

@morningman morningman

Labels

approved Indicates a PR has been approved by one committer. area/metrics Issues or PRs related to the metrics kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Failed to get TCP metrics when linux kernel is 2.x

3 participants

@morningman @yangzhg @morningman-cmy